From: "Kasai Takanori" Subject: Re: [PATCH] qemu-dm monitor doesn't support the quit command Date: Wed, 17 Jan 2007 17:59:22 +0900 Message-ID: <021c01c73a15$cb803610$dab2220a@VF03007L> References: <15d001c725ca$326f3980$dab2220a@VF03007L><07ff01c727c6$ac8c1d20$dab2220a@VF03007L><103201c73463$e6af4000$dab2220a@VF03007L><20070110033427.GD6153@edwin-srv.sh.intel.com> <144c01c73578$742b2240$dab2220a@VF03007L> <014201c739e4$4d4913b0$dab2220a@VF03007L> <45ADB746.7040400@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-2022-jp"; reply-type=original Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Anthony Liguori Cc: xen-devel List-Id: xen-devel@lists.xenproject.org Hi Anthony, Thank you for reply. I want to achieve it by other methods. >> I made the patch that changed it from quit or q to quitdomain. I think >> that the HVM domain can be prevented being shutted down by the mistake >> in this patch. If there is any problem, please let me know. > > It seems to me that this is just one more thing to get us further away > from the upstream QEMU tree and to me, that's a bad thing. It's not > this one patch in particular but once you get enough of these, it starts > getting hairy. I also think certainly like that. > If you really thing the q command is poorly named, I think you should > make that case to the QEMU community. It really isn't a Xen specific issue. It is natural that there is quit command in original QEMU. I do not think the agreement in the QEMU community. > If this really is a problem for you, couldn't you just keep the patch > around for your own use? I haven't seen anyone else complain of this > issue before so I'm not sure it will do anything but confuse other people. It was thought that it was necessary for the user's using by the operational aspect. Thanks, -- Takanori Kasai