From: Ulf Samuelsson Date: Thu, 1 Feb 2007 19:26:40 +0100 Subject: [U-Boot-Users] [PATCH] AT91SAM9263 Board files References: <20070201001802.E0511353A8A@atlas.denx.de> Message-ID: <022e01c74631$4177caa0$01c4af0a@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > I'm not sure if you want to demonstrate something, and what, by > dumping to the mailing list such a list of "patches" that are no > patches at all because they violate all formal requirements as layed > down in the README. The rules are not there just for fun, but to > allow reviewing of the submitted code, and to make integration as > easy as possible. You leave me no choice but to reject your > submissions, or anybody could quote a precedent from this. > > And I think you knew this before. > > So why? No, I don't want to demonstrate anything. I would like U-Boot to include board support for the current AT91 boards. The AT91 product line says that they have no time to spend. The Atmel patches are based on U-Boot-1.1.5 and if I do "diff -purN" between 12.1.5 and the Atmel version I get around 1 MB of uncompressed patches. There are even files there which are larger than the mailing list limit. The CPU header files are ~ 100-200 kB. The USB host support is > 40 kB. This means that I cannot supply everything as a patch. I *must* due to the size of the patch supply as several patches, each below 40 kB. I wrote an application which splits a large file into one patch per file in the target system, so all patches can be applied in any order. The Atmel U-Boot contains 4 new boards, and the patch for Makefile and MAKEALL contains all four boards. If that needs to be split up into 4 patches, then there have to be a patch order for those two files. The main part of the patches are support for: * Atmel ARM926 based CPUs "cpu/arm926ejs/at91sam926x" directory. * Moving at45.c dataflash driver from the board directories to the "driver" directory. * Board support for 4 new boards. - at91rm9200ek - at91sam9260ek - at91sam9261ek - at91sam9263ek On top of the official patches, I would like to add some of my own including * Different partitioning of the dataflash, so that it is compatible with linux-2.6 and not linux-2.4. * "cmp" support for dataflash * "crc" support for dataflash * New board "at91rm9200df" * block erase of dataflash (faster erase of large blocks) Moving the dataflash to the "driver" directory will break all boards which has the dataflash driver in the board directory. When I checked, I think there are 3-4 boards in the current distribution which will be affected. In the end I would like to move all boards down to the "board/atmel" directory at the end of the I think it would be easier if we broke down things into smaller parts. First I would like to move of the dataflash support to the driver directory. Then adding patches for the ARM926 based cpu/board directories, but without any references to these patches in Makefiles/MAKEALL. At the end a patch which would make them buildable. This would during a short period give some "dangling" or unused code I know you don't like that, so how proceed with such a large patchset, where things depend on each other? I dont have any git server which I can use for this. Will try to get access to www.atmel.no like Haavard but I do not know know if it is possible and if it is, when it is possible. > Best regards, > > Wolfgang Denk Best Regards, Ulf Samuelsson ulf at atmel.com GSM: +46 (706) 22 44 57 Tel: +46 (8) 441 54 22 Fax: +46 (8) 441 54 29 Mail: Box 2033 174 02 Sundbyberg Visit: Kavalleriv?gen 24 174 58 Sundbyberg' Sweden