Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3238FC433F5 for ; Fri, 14 Jan 2022 14:04:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B7FB83496; Fri, 14 Jan 2022 15:04:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=akkea.ca header.i=@akkea.ca header.b="F5HPT29e"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="F5HPT29e"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7232C8344C; Fri, 14 Jan 2022 15:04:34 +0100 (CET) Received: from node.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 18FA38342C for ; Fri, 14 Jan 2022 15:04:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=akkea.ca Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=angus@akkea.ca Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id D8FF64E2006; Fri, 14 Jan 2022 14:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1642169068; bh=uwTShrulf7K3qD/p4+2oTcQfiwqLigCJAngeIfpA7NU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=F5HPT29ejlcb3Aq8Z6AQZDc0w6mIxnVX+tzstgJnmmb77Aq5IfVV1BRY+iwJvGJGG VBs5DAWWqyp4dJO8u2/FXnUdAXrIY4a7syurAF6dnoyN6Trb2BoJ1yINylrB9N+lYj evFBRTYi36GzBdDgdpveZjNEVuOXGzfrm0DvVqyM= Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZE5TituZwMzv; Fri, 14 Jan 2022 14:04:28 +0000 (UTC) Received: from www.akkea.ca (li1434-30.members.linode.com [45.33.107.30]) by node.akkea.ca (Postfix) with ESMTPSA id 21DC84E2003; Fri, 14 Jan 2022 14:04:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1642169068; bh=uwTShrulf7K3qD/p4+2oTcQfiwqLigCJAngeIfpA7NU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=F5HPT29ejlcb3Aq8Z6AQZDc0w6mIxnVX+tzstgJnmmb77Aq5IfVV1BRY+iwJvGJGG VBs5DAWWqyp4dJO8u2/FXnUdAXrIY4a7syurAF6dnoyN6Trb2BoJ1yINylrB9N+lYj evFBRTYi36GzBdDgdpveZjNEVuOXGzfrm0DvVqyM= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 14 Jan 2022 06:04:28 -0800 From: Angus Ainslie To: Dhananjay Phadke Cc: Jagan Teki , Vignesh R , u-boot@lists.denx.de, kernel@puri.sm Subject: Re: [PATCH v2] drivers: spi-nor: Add JEDEC id for W25Q16JV In-Reply-To: References: <20220113171726.1669216-1-angus@akkea.ca> Message-ID: <02560e4c7bbc0be08f7c9d0498dab6db@akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Dhananjay , Jagan, On 2022-01-13 10:30, Dhananjay Phadke wrote: > On 1/13/2022 9:17 AM, Angus Ainslie wrote: >> Add a JEDEC id for the Winbond W25Q16JV 16M-BIT serial flash memory >> with >> DUAL/QUAD SPI >> >> Changes since v1: >> >> Updated the name for more suffixes >> >> Signed-off-by: Angus Ainslie >> --- >> drivers/mtd/spi/spi-nor-ids.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/mtd/spi/spi-nor-ids.c >> b/drivers/mtd/spi/spi-nor-ids.c >> index b551ebd75e..3bd0ded443 100644 >> --- a/drivers/mtd/spi/spi-nor-ids.c >> +++ b/drivers/mtd/spi/spi-nor-ids.c >> @@ -314,6 +314,11 @@ const struct flash_info spi_nor_ids[] = { >> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | >> SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) >> }, >> + { >> + INFO("w25q16jv-im/jm", 0xef7015, 0, 64 * 1024, 32, >> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | >> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) >> + }, > > Shouldn't this be w25q16jvm, which seems to be unofficial convention > for > *-DTR parts? I was looking for naming convention for another Winbond > part - > > https://lore.kernel.org/u-boot/0c3e4727-0997-a4c5-dab1-b09ea8781c72@linux.microsoft.com/ > Would you like a v3 using this naming convention ? Thanks Angus >> { >> INFO("w25q32jv", 0xef7016, 0, 64 * 1024, 64, >> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |