Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7774C433F5 for ; Tue, 17 May 2022 21:51:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E54C984273; Tue, 17 May 2022 23:51:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jWYfhhyn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5AFAF84277; Tue, 17 May 2022 23:51:26 +0200 (CEST) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D6FD284269 for ; Tue, 17 May 2022 23:51:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=daniel.schwierzeck@gmail.com Received: by mail-ed1-x535.google.com with SMTP id c12so608871eds.10 for ; Tue, 17 May 2022 14:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=CHG0FrXP/xi+lwmvtFj+dfdnS4V2Y0CAuqWSHuFGU6g=; b=jWYfhhyn3o+UvL2KiA4fbCvyO9U4WR6yvGhObHMdzzh3zOkdJKVXwVz8OQX7+eJPFF hyZ9qdykx7AHvEjR1HubNbYSZkJKg+8LeTEseXvcL5OwZNqfaPOUb5UdOaBnqPn1EYmU w898zIfXx8g4NzdlvznrwrZzAutNxKrRFJJCRmBAabURVAxFrz12LRCoP1EfPppOGo4V MaCkCVOLnTCKeqObC1h3GnH7Cc9zA9OPuIVAf84blgOMeY7yX1QWOBQ9Y9+43HVS49l7 B2lY5bixRf6sWXz9aD55q05tUbWygpiWTWJXOqmBEU+rizv5nRrfhgjFDrQJNrhKgF/4 qdqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=CHG0FrXP/xi+lwmvtFj+dfdnS4V2Y0CAuqWSHuFGU6g=; b=y0gGXZrOXQmZHwLJDVjCNVgP2nOrZUMkqNwIKOFWeovaPyOW1CqCqqdHnz1SqlIoDj kEAcTFcNOCcbcqoUyS8GOUthqKqlshz6UiDjoSB+vaASAP0jX4//0N3KjfSCVnb4KA/F qA7HcFNlCEnNE6zSpMGmOellC9oDL+t09Sck/dbWju6S1EKZh01S/8iSaAXZX0nMnvhs e0AEyTSFnQkwFrLc9ayjF2HKKlIYKoBnMZ5YFd5V/CC8B9x4SsubFmdG2qwS9zjsbP8v Ckev7Titfbw+fz12FXBYYEyqsNZiXUg9wSkIVL/T6a9QyvfFAIGCbboeCNCE0ywn1wal GUNg== X-Gm-Message-State: AOAM53265bLIawCUn2NjoFmKfouDjR5IKBLWzhYPeIYrd34MN9psFHWW THwktMUs/8GQwUw4QpPoMps= X-Google-Smtp-Source: ABdhPJx2sGgec3Z79JN6p2Ws2I4kMKmXo2Y0RPJNL1aOKzZVtLpp9EV02s9zBeTMNgiyqV7BMatReA== X-Received: by 2002:a05:6402:42c8:b0:427:d087:29 with SMTP id i8-20020a05640242c800b00427d0870029mr21633047edc.53.1652824283505; Tue, 17 May 2022 14:51:23 -0700 (PDT) Received: from [192.168.10.30] (i5E86074D.versanet.de. [94.134.7.77]) by smtp.gmail.com with ESMTPSA id yl16-20020a17090693f000b006f3ef214e3bsm152982ejb.161.2022.05.17.14.51.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 May 2022 14:51:22 -0700 (PDT) Message-ID: <025edd88-31f3-5c4d-2e84-af50b447d5d4@gmail.com> Date: Tue, 17 May 2022 23:51:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v5 18/25] net: mediatek: use regmap api to modify ethsys registers Content-Language: en-US To: Weijie Gao , u-boot@lists.denx.de Cc: GSS_MTK_Uboot_upstream , Joe Hershberger , Ramon Fried References: <9d035f42944ab5730bfb04a8eb703425aa65cc80.1652667687.git.weijie.gao@mediatek.com> From: Daniel Schwierzeck In-Reply-To: <9d035f42944ab5730bfb04a8eb703425aa65cc80.1652667687.git.weijie.gao@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 16.05.22 04:43, Weijie Gao wrote: > The address returned by regmap_get_range() is not remapped. Directly r/w > to this address is ok for ARM platforms since it's idential to the virtual > address. > > But for MIPS platform only virtual address should be used for access. > To solve this issue, the regmap api regmap_read/regmap_write should be used > since they will remap address before accessing. > > Reviewed-by: Ramon Fried > Signed-off-by: Weijie Gao > --- > v5 changes: none > v4 changes: new > --- > drivers/net/mtk_eth.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > Reviewed-by: Daniel Schwierzeck -- - Daniel