Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D82FC433EF for ; Sat, 15 Jan 2022 17:28:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5BA0E83494; Sat, 15 Jan 2022 18:28:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Zn3qeJXn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E7DDC83504; Sat, 15 Jan 2022 18:28:51 +0100 (CET) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2E20E83494 for ; Sat, 15 Jan 2022 18:28:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qv1-xf31.google.com with SMTP id ee17so2209996qvb.6 for ; Sat, 15 Jan 2022 09:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XVhKWZwGPNDhtTzMPWh2cWCWfGemfWYi7JculHPvRWA=; b=Zn3qeJXnmdx2g5z3dkBSi/KE/G0S0nzD+EoTYXd3E9tcZPKzY8eldrVgCkN5QtB4FV qzcVolLcgtepSMibNnJfJDjIAkNBcRKUkaycVSZEAEpeoc1LbvCg4GMynpvXgugvYIiC T9M0O65hVGIZfAgdBkhAH5MJn7VwKPoOZ21CNqr+a3cbOrF9i/Db+X71IylMHRJSKki+ CEBRGqoOh7fJTXh9zYvHYcWjY4dFffiTBtZw5LAye2qX60uIOzoqhSZFP0kOAPSn+BPx DKBweHa6CQizP7wN9Ehm1L1ijaaCA7T4UHSIQeKskfWFOmFUKwsdMWBPvoMxS2xedsrX ViRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XVhKWZwGPNDhtTzMPWh2cWCWfGemfWYi7JculHPvRWA=; b=jBVuFi/zMZbOv8Mtl5dFWa7MCQVvN2du25vdrNRvVxiW7zB+cYMZpgyj8rEXDb9aG/ bLT4pcQF+KHR1fGwJUOi0AfK4SMitvg2tjnQI+/M8o7hzhQqO4WX3ziSJkzgFRx40F2+ XVq9nW5a59XDleLh9hyTRdZmAaH0rd0v6oSES/DIAlLsocezaYephiMWmI1w91VCE7Ps IRgOqA3UWtv9BOmVfsGAeNhNU/VWvhLwakHUgE31KesBCTvcW0jWsBW6IBcga7S7W2HI wXEOajxOIMxBBVfqnRll32N1GCCvQZCZHGCFkr/1c8hKDMl2y+cU95Fbm/j47sqZHccE 5csg== X-Gm-Message-State: AOAM530lnj7fiKijaKzzaj/1I3iwc3emdN8JEu0M6IMfscsQBLJpxTKl 2pds+68ruafa4o4Ld80E6TJTHPErIYA= X-Google-Smtp-Source: ABdhPJz7oLcAu4aJ8XMIuYa5WtjP4+dUjHadyl7QCsnbMKVLazEIznPgkXMXc6kdsdNGVFmVS7dItg== X-Received: by 2002:a05:6214:2302:: with SMTP id gc2mr12738388qvb.126.1642267727626; Sat, 15 Jan 2022 09:28:47 -0800 (PST) Received: from [192.168.1.201] (pool-108-18-137-133.washdc.fios.verizon.net. [108.18.137.133]) by smtp.googlemail.com with ESMTPSA id o5sm6042370qkp.132.2022.01.15.09.28.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jan 2022 09:28:47 -0800 (PST) Subject: Re: [PATCH v7 07/19] rockchip: rk3066: fix assigned-clocks rk3066_clk_set_rate To: Johan Jonker , kever.yang@rock-chips.com Cc: sjg@chromium.org, philipp.tomsich@vrull.eu, lukma@denx.de, u-boot@lists.denx.de References: <20220111211843.10958-1-jbx6244@gmail.com> <20220111211843.10958-8-jbx6244@gmail.com> From: Sean Anderson Message-ID: <02ab5b89-8cff-ca7e-26ba-a9d20a9d7ccb@gmail.com> Date: Sat, 15 Jan 2022 12:28:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20220111211843.10958-8-jbx6244@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 1/11/22 4:18 PM, Johan Jonker wrote: > The rk3066 cru node has a number of assigned-clocks properties > that call the .set_rate() function. Add them to the list so that > they return a 0 instead of -ENOENT. > > Signed-off-by: Johan Jonker > --- > drivers/clk/rockchip/clk_rk3066.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/clk/rockchip/clk_rk3066.c b/drivers/clk/rockchip/clk_rk3066.c > index 804aa43b..17777a45 100644 > --- a/drivers/clk/rockchip/clk_rk3066.c > +++ b/drivers/clk/rockchip/clk_rk3066.c > @@ -573,6 +573,15 @@ static ulong rk3066_clk_set_rate(struct clk *clk, ulong rate) > case SCLK_TSADC: > new_rate = rk3066_clk_saradc_set_clk(cru, rate, clk->id); > break; > + case PLL_CPLL: > + case PLL_GPLL: > + case ACLK_CPU: > + case HCLK_CPU: > + case PCLK_CPU: > + case ACLK_PERI: > + case HCLK_PERI: > + case PCLK_PERI: > + return 0; > default: > return -ENOENT; > } > These 3 patches look good, but I don't understand why they aren't squashed in with the first patch. --Sean