From: "flichtenheld (Code Review)" Date: Thu, 21 Nov 2024 13:10:07 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., marco@...2726..., openvpn-devel@lists.sourceforge.net Message-ID: <02b0d8925f05fb3a7a8c5a0fdf050aa839fa2726-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="puXQMVGEDVg="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle PUSH ... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrbff Cc: plaisthos , openvpn-devel --puXQMVGEDVg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: mrbff, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/808?usp=3Demail ) Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and ha= ndle PUSH UPDATE control messages to allow options updating at runtime. ...................................................................... Patch Set 1: Code-Review-1 (2 comments) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/808/comment/f6e72862_6ae239a4 : PS1, Line 5472: if (!apply_pull_filter(options, line)) ``` options.c: In function =E2=80=98apply_push_options=E2=80=99: options.c:5472:14: error: too few arguments to function =E2=80=98apply_pull= _filter=E2=80=99 5472 | if (!apply_pull_filter(options, line)) | ^~~~~~~~~~~~~~~~~ In file included from options.c:66: options_util.h:34:1: note: declared here 34 | apply_pull_filter(const struct options *o, | ^~~~~~~~~~~~~~~~~ ``` http://gerrit.openvpn.net/c/openvpn/+/808/comment/09d1a5a6_ed8662d7 : PS1, Line 5618: apply_push_options(struct context *c, ``` options.c:5456:1: error: conflicting types for =E2=80=98apply_push_options= =E2=80=99; have =E2=80=98_Bool(struct options *, struct buffer *, unsigned = int, unsigned int *, struct env_set *)=E2=80=99 5456 | apply_push_options(struct options *options, | ^~~~~~~~~~~~~~~~~~ In file included from ssl.h:40, from options.c:45: options.h:875:6: note: previous declaration of =E2=80=98apply_push_options= =E2=80=99 with type =E2=80=98_Bool(struct context *, struct options *, stru= ct buffer *, unsigned int, unsigned int *, struct env_set *, _Bool)=E2=80= =99 875 | bool apply_push_options(struct context *c, | ^~~~~~~~~~~~~~~~~~ ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a Gerrit-Change-Number: 808 Gerrit-PatchSet: 1 Gerrit-Owner: mrbff Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: mrbff Gerrit-Comment-Date: Thu, 21 Nov 2024 13:10:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --puXQMVGEDVg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: mrbff, plaisthos.

Patch set 1:Code-Review -1=

Vi= ew Change

2 comments:

  • File src/openvpn/options.c:

    =
    • Patch Set #1, Line 547= 2: if (!apply_p= ull_filter(options, line))

      ```
      options.c: In function =E2=80=98ap= ply_push_options=E2=80=99:
      options.c:5472:14: error: too few arguments t= o function =E2=80=98apply_pull_filter=E2=80=99
      5472 | if (!appl= y_pull_filter(options, line))
      | ^~~~~~~~~~~~~~~~~
      = In file included from options.c:66:
      options_util.h:34:1: note: declared = here
      34 | apply_pull_filter(const struct options *o,
      | ^~~~~= ~~~~~~~~~~~~
      ```
    • Patch Set #1, Line 5618: apply_push_options(struct context = *c,

      ```
      options.c:5456:1: error: conflicting types for =E2=80=98a= pply_push_options=E2=80=99; have =E2=80=98_Bool(struct options *, struct bu= ffer *, unsigned int, unsigned int *, struct env_set *)=E2=80=99
      5456 = | apply_push_options(struct options *options,
      | ^~~~~~~~~~~~~~~~~~=
      In file included from ssl.h:40,
      from options.c:45:<= br>options.h:875:6: note: previous declaration of =E2=80=98apply_push_optio= ns=E2=80=99 with type =E2=80=98_Bool(struct context *, struct options *, st= ruct buffer *, unsigned int, unsigned int *, struct env_set *, _Bool)=E2= =80=99
      875 | bool apply_push_options(struct context *c,
      | = ^~~~~~~~~~~~~~~~~~
      ```

To view, visit change 808. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595= c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 1
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: mrbff <marco@...2726...&g= t;
Gerrit-Comment-Date: Thu, 21 Nov 2024 13:10:07= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--puXQMVGEDVg=--