From: "Koenig, Christian" Subject: Re: [PATCH] drm/ttm: Refactor ttm_bo_pipeline_move Date: Fri, 16 Aug 2019 19:10:19 +0000 Message-ID: <02b4b437-b954-63ef-bc7d-080a0af261bf@amd.com> References: <20190816185916.30184-1-brian.welty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-eopbgr790089.outbound.protection.outlook.com [40.107.79.89]) by gabe.freedesktop.org (Postfix) with ESMTPS id C74C26E98A for ; Fri, 16 Aug 2019 19:10:21 +0000 (UTC) In-Reply-To: <20190816185916.30184-1-brian.welty@intel.com> Content-Language: en-US Content-ID: <59DC1F458465524CBD4ADF56407AEF5B@namprd12.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brian Welty , Daniel Vetter , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org QW0gMTYuMDguMTkgdW0gMjA6NTkgc2NocmllYiBCcmlhbiBXZWx0eToNCj4gdHRtX2JvX3BpcGVs aW5lX21vdmUgbmVlZGxlc3NseSBkdXBsaWNhdGVzIGNvZGUuIFJlZmFjdG9yIHRoaXMgdG8NCj4g aW5zdGVhZCBjYWxsIHR0bV9ib19tb3ZlX2FjY2VsX2NsZWFudXAuDQo+DQo+IFNpZ25lZC1vZmYt Ynk6IEJyaWFuIFdlbHR5IDxicmlhbi53ZWx0eUBpbnRlbC5jb20+DQoNCkF0IGxlYXN0IG9mIGhh bmQgdGhhdCBsb29rcyB2YWxpZCB0byBtZSwgUmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcg DQo8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPiBmb3Igbm93Lg0KDQpSZWdhcmRzLA0KQ2hyaXN0 aWFuLg0KDQo+DQo+IC0tLQ0KPiBCdWlsZHMgYnV0IG90aGVyd2lzZSBjdXJyZW50bHkgdW50ZXN0 ZWQuDQo+IENhbWUgYWNyb3NzIHRoaXMgZHVwbGljYXRpb24gYW5kIHRob3VnaHQgd291bGQgc2Vl IGlmIG90aGVycyBjYXJlZA0KPiB0byBzZWUgaXQgY2xlYW5lZCB1cCB0aGlzIHdheSBvciBub3Qu DQo+DQo+ICAgZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fYm9fdXRpbC5jIHwgNjQgKysrLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMo KyksIDU5IGRlbGV0aW9ucygtKQ0KPg0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3R0 bS90dG1fYm9fdXRpbC5jIGIvZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fYm9fdXRpbC5jDQo+IGlu ZGV4IGZlODFjNTY1ZTdlZi4uMDg2YmEyYzJmNjBiIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vdHRtL3R0bV9ib191dGlsLmMNCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3R0bS90dG1f Ym9fdXRpbC5jDQo+IEBAIC03NDYsNDkgKzc0NiwxMCBAQCBpbnQgdHRtX2JvX3BpcGVsaW5lX21v dmUoc3RydWN0IHR0bV9idWZmZXJfb2JqZWN0ICpibywNCj4gICB7DQo+ICAgCXN0cnVjdCB0dG1f Ym9fZGV2aWNlICpiZGV2ID0gYm8tPmJkZXY7DQo+ICAgCXN0cnVjdCB0dG1fbWVtX3JlZyAqb2xk X21lbSA9ICZiby0+bWVtOw0KPiAtDQo+ICAgCXN0cnVjdCB0dG1fbWVtX3R5cGVfbWFuYWdlciAq ZnJvbSA9ICZiZGV2LT5tYW5bb2xkX21lbS0+bWVtX3R5cGVdOw0KPiAtCXN0cnVjdCB0dG1fbWVt X3R5cGVfbWFuYWdlciAqdG8gPSAmYmRldi0+bWFuW25ld19tZW0tPm1lbV90eXBlXTsNCj4gLQ0K PiAtCWludCByZXQ7DQo+IC0NCj4gLQlkbWFfcmVzdl9hZGRfZXhjbF9mZW5jZShiby0+YmFzZS5y ZXN2LCBmZW5jZSk7DQo+IC0NCj4gLQlpZiAoIWV2aWN0KSB7DQo+IC0JCXN0cnVjdCB0dG1fYnVm ZmVyX29iamVjdCAqZ2hvc3Rfb2JqOw0KPiAtDQo+IC0JCS8qKg0KPiAtCQkgKiBUaGlzIHNob3Vs ZCBoZWxwIHBpcGVsaW5lIG9yZGluYXJ5IGJ1ZmZlciBtb3Zlcy4NCj4gLQkJICoNCj4gLQkJICog SGFuZyBvbGQgYnVmZmVyIG1lbW9yeSBvbiBhIG5ldyBidWZmZXIgb2JqZWN0LA0KPiAtCQkgKiBh bmQgbGVhdmUgaXQgdG8gYmUgcmVsZWFzZWQgd2hlbiB0aGUgR1BVDQo+IC0JCSAqIG9wZXJhdGlv biBoYXMgY29tcGxldGVkLg0KPiAtCQkgKi8NCj4gLQ0KPiAtCQlkbWFfZmVuY2VfcHV0KGJvLT5t b3ZpbmcpOw0KPiAtCQliby0+bW92aW5nID0gZG1hX2ZlbmNlX2dldChmZW5jZSk7DQo+ICAgDQo+ IC0JCXJldCA9IHR0bV9idWZmZXJfb2JqZWN0X3RyYW5zZmVyKGJvLCAmZ2hvc3Rfb2JqKTsNCj4g LQkJaWYgKHJldCkNCj4gLQkJCXJldHVybiByZXQ7DQo+IC0NCj4gLQkJZG1hX3Jlc3ZfYWRkX2V4 Y2xfZmVuY2UoZ2hvc3Rfb2JqLT5iYXNlLnJlc3YsIGZlbmNlKTsNCj4gLQ0KPiAtCQkvKioNCj4g LQkJICogSWYgd2UncmUgbm90IG1vdmluZyB0byBmaXhlZCBtZW1vcnksIHRoZSBUVE0gb2JqZWN0 DQo+IC0JCSAqIG5lZWRzIHRvIHN0YXkgYWxpdmUuIE90aGVyd2hpc2UgaGFuZyBpdCBvbiB0aGUg Z2hvc3QNCj4gLQkJICogYm8gdG8gYmUgdW5ib3VuZCBhbmQgZGVzdHJveWVkLg0KPiAtCQkgKi8N Cj4gLQ0KPiAtCQlpZiAoISh0by0+ZmxhZ3MgJiBUVE1fTUVNVFlQRV9GTEFHX0ZJWEVEKSkNCj4g LQkJCWdob3N0X29iai0+dHRtID0gTlVMTDsNCj4gLQkJZWxzZQ0KPiAtCQkJYm8tPnR0bSA9IE5V TEw7DQo+IC0NCj4gLQkJdHRtX2JvX3VucmVzZXJ2ZShnaG9zdF9vYmopOw0KPiAtCQl0dG1fYm9f cHV0KGdob3N0X29iaik7DQo+IC0NCj4gLQl9IGVsc2UgaWYgKGZyb20tPmZsYWdzICYgVFRNX01F TVRZUEVfRkxBR19GSVhFRCkgew0KPiArCWlmIChldmljdCAmJiBmcm9tLT5mbGFncyAmIFRUTV9N RU1UWVBFX0ZMQUdfRklYRUQpIHsNCj4gKwkJZG1hX3Jlc3ZfYWRkX2V4Y2xfZmVuY2UoYm8tPmJh c2UucmVzdiwgZmVuY2UpOw0KPiAgIA0KPiAgIAkJLyoqDQo+ICAgCQkgKiBCTyBkb2Vzbid0IGhh dmUgYSBUVE0gd2UgbmVlZCB0byBiaW5kL3VuYmluZC4gSnVzdCByZW1lbWJlcg0KPiBAQCAtODA3 LDI3ICs3NjgsMTIgQEAgaW50IHR0bV9ib19waXBlbGluZV9tb3ZlKHN0cnVjdCB0dG1fYnVmZmVy X29iamVjdCAqYm8sDQo+ICAgCQlkbWFfZmVuY2VfcHV0KGJvLT5tb3ZpbmcpOw0KPiAgIAkJYm8t Pm1vdmluZyA9IGRtYV9mZW5jZV9nZXQoZmVuY2UpOw0KPiAgIA0KPiArCQkqb2xkX21lbSA9ICpu ZXdfbWVtOw0KPiArCQluZXdfbWVtLT5tbV9ub2RlID0gTlVMTDsNCj4gICAJfSBlbHNlIHsNCj4g LQkJLyoqDQo+IC0JCSAqIExhc3QgcmVzb3J0LCB3YWl0IGZvciB0aGUgbW92ZSB0byBiZSBjb21w bGV0ZWQuDQo+IC0JCSAqDQo+IC0JCSAqIFNob3VsZCBuZXZlciBoYXBwZW4gaW4gcHJhdGljZS4N Cj4gLQkJICovDQo+IC0NCj4gLQkJcmV0ID0gdHRtX2JvX3dhaXQoYm8sIGZhbHNlLCBmYWxzZSk7 DQo+IC0JCWlmIChyZXQpDQo+IC0JCQlyZXR1cm4gcmV0Ow0KPiAtDQo+IC0JCWlmICh0by0+Zmxh Z3MgJiBUVE1fTUVNVFlQRV9GTEFHX0ZJWEVEKSB7DQo+IC0JCQl0dG1fdHRfZGVzdHJveShiby0+ dHRtKTsNCj4gLQkJCWJvLT50dG0gPSBOVUxMOw0KPiAtCQl9DQo+IC0JCXR0bV9ib19mcmVlX29s ZF9ub2RlKGJvKTsNCj4gKwkJcmV0dXJuIHR0bV9ib19tb3ZlX2FjY2VsX2NsZWFudXAoYm8sIGZl bmNlLCBldmljdCwgbmV3X21lbSk7DQo+ICAgCX0NCj4gICANCj4gLQkqb2xkX21lbSA9ICpuZXdf bWVtOw0KPiAtCW5ld19tZW0tPm1tX25vZGUgPSBOVUxMOw0KPiAtDQo+ICAgCXJldHVybiAwOw0K PiAgIH0NCj4gICBFWFBPUlRfU1lNQk9MKHR0bV9ib19waXBlbGluZV9tb3ZlKTsNCg0KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs