From: Tomi Valkeinen Subject: Re: [PATCH v3 3/3] drm/omap: Make omapdss API more generic Date: Thu, 8 Feb 2018 14:11:21 +0200 Message-ID: <02e1c828-a186-e03e-cbc0-1aae39785cdb@ti.com> References: <1702fb43c5bfdcc8d18cfdc43895a594b9269d0a.1518001667.git.jsarha@ti.com> <282b2cb6-e477-af56-e501-b655761d84cf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38BB06E5E3 for ; Thu, 8 Feb 2018 12:11:28 +0000 (UTC) In-Reply-To: <282b2cb6-e477-af56-e501-b655761d84cf@ti.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org T24gMDgvMDIvMTggMTM6NDMsIEp5cmkgU2FyaGEgd3JvdGU6Cj4gQXJnaCwgc29ycnkgSSBmb3Jn b3QgYWJvdXQgdGhlc2UgaW4gdGhlIHByZXZpb3VzIHBvc3QuIChBbmQgdGhlIGNvbW1lbnQKPiBm b3IgImRybS9vbWFwOiBGYWlsIHByb2JlIGlmIGlycSByZWdpc3RyYXRpb24gZmFpbHMiKS4KPiAK PiBPbiAwMi8wOC8xOCAxMDo1MywgVG9taSBWYWxrZWluZW4gd3JvdGU6Cj4+IE9uIDA3LzAyLzE4 IDE2OjExLCBKeXJpIFNhcmhhIHdyb3RlOgo+Pj4gVGhlIG5ldyBvbWFwZHNzIEFQSSBpcyBIVyBp bmRlcGVuZGVudCBhbmQgY2xlYW5zIHVwIHNvbWUgb2YgdGhlIERTUzUKPj4+IHNwZWNpZmljIGhh Y2tzIGZyb20gdGhlIG9tYXBkcm0gc2lkZSBhbmQgZ2V0cyByaWQgb2ZmIHRoZSBEU1M1IElSUQo+ Pj4gcmVnaXN0ZXIgYml0cyBhbmQgcmVwbGFjZSB0aGVtIHdpdGggSFcgaW5kZXBlbmRlbnQgZ2Vu ZXJpYyB1NjQgYmFzZWQKPj4+IG1hY3Jvcy4gVGhlIG5ldyBtYWNyb3MgbWFrZSBpdCBtb3JlIHN0 cmFpZ2h0IGZvcndhcmQgdG8gaW1wbGVtZW50IHRoZQo+Pj4gSVJRIGNvZGUgZm9yIHRoZSBmdXR1 cmUgRFNTIHZlcnNpb25zIHRoYXQgZG8gbm90IHNoYXJlIHRoZSBzYW1lCj4+PiByZWdpc3RlciBz dHJ1Y3R1cmUgYXMgRFNTMiB0byBEU1M1IGhhcy4KPj4+Cj4+PiBTaWduZWQtb2ZmLWJ5OiBKeXJp IFNhcmhhIDxqc2FyaGFAdGkuY29tPgo+PiA8c25pcD4KPj4KPj4gQ2FuIHlvdSBhZGQgYSBjb21t ZW50IGhlcmUgdGhhdCBkZXNjcmliZXMgdGhlIGxheW91dCBvZiB0aGUgdTY0IGlycSBiaXRzCj4+ IGNvbnRhaW5lci4KPiBXb3VsZCB0aGlzIGRvOgo+IAo+IC8qCj4gwqAqIEJhc2VkIG9uIHRoZSBh Ym92ZSAyIGRlZmluZXMgdGhlIGJlbGxvdyBkZWZpbmVzIGRlc2NyaWJlIGZvbGxvd2luZwo+IMKg KiB1NjQgSVJRIGJpdHM6Cj4gwqAqIGJpdCBncm91cCB8ZGV2IHxtcmcwfG1yZzF8bXJnMnxtcmcz fG1yZzR8bXJnNXxtcmc2fG1yZzd8IG9sdjAtN8KgCj4gfDx1bnVzZWQ+IHwKPiDCoCogYml0IHVz ZcKgwqAgfETCoMKgIHxGRU9MfEZFT0x8RkVPTHxGRU9MfEZFT0x8RkVPTHxGRU9MfEZFT0x8VVVV VXxVVVVVfCB8Cj4gfCB8IHwgfAo+IMKgKiBiaXQgbnVtYmVyfDAtMyB8NC03IHw4LTExfMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgMTItMzXCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHzCoCAzNi00M8Kg IHzCoAo+IDQ0LTYzwqAgfAo+IMKgKgo+IMKgKiBkZXZpY2UgYml0czogRCA9IE9DUCBlcnJvcgo+ IMKgKiBtZ3IgYml0czrCoMKgwqAgRiA9IGZyYW1lIGRvbmUsIEUgPSB2c3luYyBldmVuLCBPID0g dnN5bmMgb2RkLAo+IMKgKiBvdmwgYml0czrCoMKgwqAgVSA9IGZpZm8gdW5kZXJmbG93Cj4gwqAq LwoKSSB0aGluayBpdCB3b3VsZCBiZSBlbm91Z2gganVzdCBzYXlpbmcgdGhhdCBmaXJzdCA0IGJp dHMgYXJlIHJlc2VydmVkCmZvciBnZW5lcmljIGlycXMsIHRoZW4gOCBtYW5hZ2VycyBlYWNoIHdp dGggNCBiaXRzLCBhbmQgdGhlbiA4IG92ZXJsYXlzCndpdGggMSBiaXQuIFRoZSBkZWZpbmVzIGJl bG93IGFyZSByZWFkYWJsZSwgYnV0IGlmIHRoZXJlJ3MgYSBjb21tZW50CndpdGggYSBoaW50IG9u IGhvdyB0byBkZWNpcGhlciB0aGVtLCBldmVyeXRoaW5nIGJlY29tZXMgbXVjaCBjbGVhcmVyLgoK QnV0IG5vdyB0aGF0IHlvdSBhbHJlYWR5IHdyb3RlIGEgZnVsbCBkZXNjcmlwdGlvbiwgaXQncyBm aW5lID0pLgpBbHRob3VnaCBtb3JlIHdvcmsgdG8gY2hhbmdlIGl0IGxhdGVyLgoKPj4+ICsjZGVm aW5lIERTU19JUlFfREVWSUNFX09DUF9FUlIJCUJJVF9VTEwoMCkKPj4+ICsKPj4+ICsjZGVmaW5l IERTU19JUlFfTUdSX0JJVF9OKGNoLCBiaXQpCSg0ICsgNCAqIGNoICsgYml0KQo+Pj4gKyNkZWZp bmUgRFNTX0lSUV9PVkxfQklUX04ob3ZsLCBiaXQpIFwKPj4+ICsJKERTU19JUlFfTUdSX0JJVF9O KERTU19NQVhfQ0hBTk5FTFMsIDApICsgMSAqIG92bCArIGJpdCkKPj4+ICsKPj4+ICsjZGVmaW5l IERTU19JUlFfTUdSX0JJVChjaCwgYml0KQlCSVRfVUxMKERTU19JUlFfTUdSX0JJVF9OKGNoLCBi aXQpKQo+Pj4gKyNkZWZpbmUgRFNTX0lSUV9PVkxfQklUKG92bCwgYml0KQlCSVRfVUxMKERTU19J UlFfT1ZMX0JJVF9OKG92bCwgYml0KSkKPj4+ICsKPj4+ICsjZGVmaW5lIERTU19JUlFfTUdSX01B U0soY2gpIFwKPj4+ICsJR0VOTUFTS19VTEwoRFNTX0lSUV9NR1JfQklUX04oY2gsIDMpLCBEU1Nf SVJRX01HUl9CSVRfTihjaCwgMCkpCj4+PiArI2RlZmluZSBEU1NfSVJRX09WTF9NQVNLKG92bCkg XAo+Pj4gKwlHRU5NQVNLX1VMTChEU1NfSVJRX09WTF9CSVRfTihvdmwsIDApLCBEU1NfSVJRX09W TF9CSVRfTihvdmwsIDApKQo+Pj4gKwo+Pj4gKyNkZWZpbmUgRFNTX0lSUV9NR1JfRlJBTUVfRE9O RShjaCkJRFNTX0lSUV9NR1JfQklUKGNoLCAwKQo+Pj4gKyNkZWZpbmUgRFNTX0lSUV9NR1JfVlNZ TkNfRVZFTihjaCkJRFNTX0lSUV9NR1JfQklUKGNoLCAxKQo+Pj4gKyNkZWZpbmUgRFNTX0lSUV9N R1JfVlNZTkNfT0REKGNoKQlEU1NfSVJRX01HUl9CSVQoY2gsIDIpCj4+PiArI2RlZmluZSBEU1Nf SVJRX01HUl9TWU5DX0xPU1QoY2gpCURTU19JUlFfTUdSX0JJVChjaCwgMykKPj4+ICsKPj4+ICsj ZGVmaW5lIERTU19JUlFfT1ZMX0ZJRk9fVU5ERVJGTE9XKG92bCkJRFNTX0lSUV9PVkxfQklUKG92 bCwgMCkKPj4+ICAKPj4+ICBzdHJ1Y3Qgb21hcF9kc3NfZGV2aWNlOwo+Pj4gIHN0cnVjdCBkc3Nf bGNkX21ncl9jb25maWc7Cj4+PiBAQCAtNjc4LDkgKzY3MCw4IEBAIHZvaWQgZHNzX21ncl91bnJl Z2lzdGVyX2ZyYW1lZG9uZV9oYW5kbGVyKGVudW0gb21hcF9jaGFubmVsIGNoYW5uZWwsCj4+PiAg LyogZGlzcGMgb3BzICovCj4+PiAgCj4+PiAgc3RydWN0IGRpc3BjX29wcyB7Cj4+PiAtCXUzMiAo KnJlYWRfaXJxc3RhdHVzKSh2b2lkKTsKPj4+IC0Jdm9pZCAoKmNsZWFyX2lycXN0YXR1cykodTMy IG1hc2spOwo+Pj4gLQl2b2lkICgqd3JpdGVfaXJxZW5hYmxlKSh1MzIgbWFzayk7Cj4+PiArCXU2 NCAoKnJlYWRfYW5kX2NsZWFyX2lycXN0YXR1cykodm9pZCk7Cj4+PiArCXZvaWQgKCp3cml0ZV9p cnFlbmFibGUpKHU2NCBlbmFibGUpOwo+Pj4gIAo+Pj4gIAlpbnQgKCpyZXF1ZXN0X2lycSkoaXJx X2hhbmRsZXJfdCBoYW5kbGVyLCB2b2lkICpkZXZfaWQpOwo+Pj4gIAl2b2lkICgqZnJlZV9pcnEp KHZvaWQgKmRldl9pZCk7Cj4+PiBAQCAtNjk0LDEzICs2ODUsMTIgQEAgc3RydWN0IGRpc3BjX29w cyB7Cj4+PiAgCWNvbnN0IGNoYXIgKigqZ2V0X292bF9uYW1lKShlbnVtIG9tYXBfcGxhbmVfaWQg cGxhbmUpOwo+Pj4gIAljb25zdCBjaGFyICooKmdldF9tZ3JfbmFtZSkoZW51bSBvbWFwX2NoYW5u ZWwgY2hhbm5lbCk7Cj4+PiAgCj4+PiArCWJvb2wgKCptZ3JfaGFzX2ZyYW1lZG9uZSkoZW51bSBv bWFwX2NoYW5uZWwgY2hhbm5lbCk7Cj4+PiArCj4+PiAgCXUzMiAoKmdldF9tZW1vcnlfYmFuZHdp ZHRoX2xpbWl0KSh2b2lkKTsKPj4+ICAKPj4+ICAJdm9pZCAoKm1ncl9lbmFibGUpKGVudW0gb21h cF9jaGFubmVsIGNoYW5uZWwsIGJvb2wgZW5hYmxlKTsKPj4+ICAJYm9vbCAoKm1ncl9pc19lbmFi bGVkKShlbnVtIG9tYXBfY2hhbm5lbCBjaGFubmVsKTsKPj4+IC0JdTMyICgqbWdyX2dldF92c3lu Y19pcnEpKGVudW0gb21hcF9jaGFubmVsIGNoYW5uZWwpOwo+Pj4gLQl1MzIgKCptZ3JfZ2V0X2Zy YW1lZG9uZV9pcnEpKGVudW0gb21hcF9jaGFubmVsIGNoYW5uZWwpOwo+Pj4gLQl1MzIgKCptZ3Jf Z2V0X3N5bmNfbG9zdF9pcnEpKGVudW0gb21hcF9jaGFubmVsIGNoYW5uZWwpOwo+Pj4gIAlib29s ICgqbWdyX2dvX2J1c3kpKGVudW0gb21hcF9jaGFubmVsIGNoYW5uZWwpOwo+Pj4gIAl2b2lkICgq bWdyX2dvKShlbnVtIG9tYXBfY2hhbm5lbCBjaGFubmVsKTsKPj4+ICAJdm9pZCAoKm1ncl9zZXRf bGNkX2NvbmZpZykoZW51bSBvbWFwX2NoYW5uZWwgY2hhbm5lbCwKPj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9vbWFw ZHJtL29tYXBfY3J0Yy5jCj4+PiBpbmRleCBmZWU4YTYzLi5mN2UxNjY4IDEwMDY0NAo+Pj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9jcnRjLmMKPj4+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9vbWFwZHJtL29tYXBfY3J0Yy5jCj4+PiBAQCAtMTQ5LDcgKzE0OSw3IEBAIHN0YXRp YyB2b2lkIG9tYXBfY3J0Y19zZXRfZW5hYmxlZChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIGJvb2wg ZW5hYmxlKQo+Pj4gIAlzdHJ1Y3Qgb21hcF9jcnRjICpvbWFwX2NydGMgPSB0b19vbWFwX2NydGMo Y3J0Yyk7Cj4+PiAgCWVudW0gb21hcF9jaGFubmVsIGNoYW5uZWwgPSBvbWFwX2NydGMtPmNoYW5u ZWw7Cj4+PiAgCXN0cnVjdCBvbWFwX2lycV93YWl0ICp3YWl0Owo+Pj4gLQl1MzIgZnJhbWVkb25l X2lycSwgdnN5bmNfaXJxOwo+Pj4gKwl1NjQgdnN5bmNfaXJxLCBmcmFtZWRvbmVfaXJxOwo+Pj4g IAlpbnQgcmV0Owo+Pj4gIAo+Pj4gIAlpZiAoV0FSTl9PTihvbWFwX2NydGMtPmVuYWJsZWQgPT0g ZW5hYmxlKSkKPj4+IEBAIC0xNjksOCArMTY5LDEwIEBAIHN0YXRpYyB2b2lkIG9tYXBfY3J0Y19z ZXRfZW5hYmxlZChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIGJvb2wgZW5hYmxlKQo+Pj4gIAkJb21h cF9jcnRjLT5pZ25vcmVfZGlnaXRfc3luY19sb3N0ID0gdHJ1ZTsKPj4+ICAJfQo+Pj4gIAo+Pj4g LQlmcmFtZWRvbmVfaXJxID0gcHJpdi0+ZGlzcGNfb3BzLT5tZ3JfZ2V0X2ZyYW1lZG9uZV9pcnEo Y2hhbm5lbCk7Cj4+PiAtCXZzeW5jX2lycSA9IHByaXYtPmRpc3BjX29wcy0+bWdyX2dldF92c3lu Y19pcnEoY2hhbm5lbCk7Cj4+PiArCj4+PiArCXZzeW5jX2lycSA9IChEU1NfSVJRX01HUl9WU1lO Q19FVkVOKGNoYW5uZWwpIHwKPj4+ICsJCSAgICAgRFNTX0lSUV9NR1JfVlNZTkNfT0REKGNoYW5u ZWwpKTsKPj4+ICsJZnJhbWVkb25lX2lycSA9IERTU19JUlFfTUdSX0ZSQU1FX0RPTkUoY2hhbm5l bCk7Cj4+PiAgCj4+PiAgCWlmIChlbmFibGUpIHsKPj4+ICAJCXdhaXQgPSBvbWFwX2lycV93YWl0 X2luaXQoZGV2LCB2c3luY19pcnEsIDEpOwo+Pj4gQEAgLTE4NCw3ICsxODYsNyBAQCBzdGF0aWMg dm9pZCBvbWFwX2NydGNfc2V0X2VuYWJsZWQoc3RydWN0IGRybV9jcnRjICpjcnRjLCBib29sIGVu YWJsZSkKPj4+ICAJCSAqIGV2ZW4gYW5kIG9kZCBmcmFtZXMuCj4+PiAgCQkgKi8KPj4+ICAKPj4+ IC0JCWlmIChmcmFtZWRvbmVfaXJxKQo+Pj4gKwkJaWYgKHByaXYtPmRpc3BjX29wcy0+bWdyX2hh c19mcmFtZWRvbmUoY2hhbm5lbCkpCj4+IElzIGl0IHZhbGlkIHRvIGRvIERTU19JUlFfTUdSX0ZS QU1FX0RPTkUoY2hhbm5lbCkgYWJvdmUsIGV2ZW4gaWYgdGhlcmUncwo+PiBubyBmcmFtZWRvbmUg aXJxIGZvciB0aGUgY2hhbm5lbD8gV2VsbCwgSSBrbm93IGl0IHdvbid0IGNyYXNoLCBidXQgZnJv bQo+PiBjb2RlLWNsZWFubGluZXNzIHBvaW50IG9mIHZpZXcsIHBlcmhhcHMgaXQncyBiZXR0ZXIg dG8gZmlyc3QgY2hlY2sgaWYgd2UKPj4gaGF2ZSBhIGZyYW1lZG9uZSwgYW5kIG9ubHkgdGhlbiBn ZXQgaXQuCj4gCj4gWWVzIGl0IGlzIHZhbGlkLiBUaG9zZSBhcmUgdGhlIGdlbmVyaWMgSVJRIGJp dHMsIHRoZSBtZ3JfaGFzX2ZyYW1lZG9uZSgpCj4ganVzdCBjaGVja3Mgd2hldGhlciB0aGUgYmFj ayBlbmQgY2FuIHByb2R1Y2Ugc3VjaCBhbmQgSVJRLiBCdXQgY2VydGFpbmx5Cj4gSSBjYW4gcmVt b3ZlIHRoZSBmcmFtZWRvbmVfaXJxIHZhcmlhYmxlIGFuZCB1c2UgbGl0ZXJhbCBpbgo+IG9tYXBf aXJxX3dhaXRfaW5pdCgpLCBpZiB5b3UgbGlrZS4KCk9rLiBZZXMsIEkgdGhpbmsgaXQncyBvayBh cyBpdCBpcy4gT3IsIHdlbGwsIEkgdGhpbmsgZnJhbWVkb25lX2lycQp2YXJpYWJsZSBpcyBvbmx5 IHVzZWQgb25jZSwgc28uLi4gcGVyaGFwcyB0aGUgd2hvbGUgdmFyaWFibGUgY2FuIGJlIGRyb3Bw ZWQuCgogVG9taQoKLS0gClRleGFzIEluc3RydW1lbnRzIEZpbmxhbmQgT3ksIFBvcmtrYWxhbmth dHUgMjIsIDAwMTgwIEhlbHNpbmtpLgpZLXR1bm51cy9CdXNpbmVzcyBJRDogMDYxNTUyMS00LiBL b3RpcGFpa2thL0RvbWljaWxlOiBIZWxzaW5raQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwK