From: "Kasai Takanori" Subject: Re: [PATCH][RESEND] PV drivers for HVM guests Date: Fri, 27 Oct 2006 20:43:59 +0900 Message-ID: <030a01c6f9bd$313fae70$dab2220a@VF03007L> References: <4535F8F5.E57C.0030.0@novell.com> Your message of Wed, 18 Oct 2006 07:51:45 -0600. <4535F8F5.E57C.0030.0@novell.com> <200610182356.k9INuAF03840@photon.sky.yk.fujitsu.co.jp> <45374AE9.E57C.0030.0@novell.com> Your message of Thu, 19 Oct 2006 07:53:42 -0600. <45374AE9.E57C.0030.0@novell.com> <200610201012.k9KACIF29714@photon.sky.yk.fujitsu.co.jp> <45389CA5.E57C.0030.0@novell.com> <200610230145.k9N1jGF01307@photon.sky.yk.fujitsu.co.jp> <453D8055.4030509@jp.fujitsu.com> <1161703595.22514.59.camel@localhost.localdomain> <200610242354.k9ONsIF02543@photon.sky.yk.fujitsu.co.jp> <200610250311.k9P3BwF04686@photon.sky.yk.fujitsu.co.jp> <1161774212.22514.86.camel@localhost.localdomain> <200610260013.k9Q0DuF16474@photon.sky.yk.fujitsu.co.jp> <200610260358.k9Q3w4F20001@photon.sky.yk.fujitsu.co.jp> <1161872106.22514.170.camel@localhost.localdomain> <00a201c6f96a$811feac0$dab2220a@VF03007L> <1161943070.13318.53.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-2022-jp"; reply-type=original Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hi Ian, >> How do you think of this patch? > > In general we want to avoid adding compatibility bits to generic code > and confine it to platform-compat.[ch] wherever possible. You have added > code in xencomm.[ch] and hypercall.h which I think we can avoid. > > I also try to avoid checking version numbers if I can, preferring to > check for the presence of absence of specific definitions instead. This > is useful when dealing with kernels with backported bits. Unfortunately > it doesn't help with the gfp_t typedef :-( but we'll come to that later. > > I've attached my current patch including the ptrace fix from above and > the comments from below. Can you give it a go? I'll try it. Thanks - Takanori Kasai