From: "plaisthos (Code Review)" Date: Sat, 28 Dec 2024 01:21:41 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., max@...2606... Message-ID: <036909c92d96e68a7496cdfc54befa2af03df69f-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="SSxuviZXjbE="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Do not attempt to decrypt packets anymore after 2**36 failed decryptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: MaxF , flichtenheld , openvpn-devel --SSxuviZXjbE= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/843?usp=3Demail ) Change subject: Do not attempt to decrypt packets anymore after 2**36 faile= d decryptions ...................................................................... Patch Set 2: (1 comment) File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/843/comment/8731b0c0_7b4731b8 : PS2, Line 672: 2**36 > I've been looking at the integrity bounds in the AEAD limits RFC again an= d I'm not sure if 2^36 is r [=E2=80=A6] IP and Ethernet packets greater than 2**10 * 16 =3D 16k are pretty rare. Sh= ould we design for 65k packets instead? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/843?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I81440ac28a1ad553652e201234e5ddfe03a8c190 Gerrit-Change-Number: 843 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos Gerrit-Reviewer: MaxF Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Attention: MaxF Gerrit-Comment-Date: Sat, 28 Dec 2024 01:21:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: MaxF Gerrit-MessageType: comment --SSxuviZXjbE= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: MaxF, flichtenheld.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/crypto.h:

    • Patch Set #2, Line 672: = 2**36

      I've been looking at the integrity bounds in the AEAD limits RFC again= and I'm not sure if 2^36 is r [=E2=80=A6]

      IP and Ethernet packets grea= ter than 2**10 * 16 =3D 16k are pretty rare. Should we design for 65k packe= ts instead?

To view, visit change 843. To unsubscribe,= or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I81440ac28a1ad553652e201234e= 5ddfe03a8c190
Gerrit-Change-Number: 843
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: MaxF <max@...2606...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: MaxF <max@...2606...> =
Gerrit-Comment-Date: Sat, 28 Dec 2024 01:21:41= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: MaxF <max@...2606...&g= t;
Gerrit-MessageType: comment
--SSxuviZXjbE=--