From: "flichtenheld (Code Review)" Date: Mon, 26 May 2025 10:40:42 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, antonio@...2726..., gert@...1296... Message-ID: <039123843a4f42e1864f4313b2b64ffb3c27a86a-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="iUHS09Tj6OI="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Reformat the whole project with clang-format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , openvpn-devel --iUHS09Tj6OI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/791?usp=3Demail ) Change subject: Reformat the whole project with clang-format ...................................................................... Patch Set 19: (4 comments) File src/openvpn/buffer.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/5fa573c3_de511cf1 : PS18, Line 850: } while (c); > Why? As discussed on IRC this is actually correct for our current formatting. http://gerrit.openvpn.net/c/openvpn/+/791/comment/5173a895_ec42235c : PS18, Line 915: && c !=3D 127)) /* allow ascii non-control and = UTF-8, consider DEL to be a control */ > Yes. Done in separate commit. File src/openvpn/comp.h: http://gerrit.openvpn.net/c/openvpn/+/791/comment/ca6252bf_a8b50dfe : PS18, Line 93: bool check_compression_settings_valid(struct compress_option= s *info, int msglevel); > this is one of the changes I'm not sure we want - having the return type = on the line before gives us [=E2=80=A6] As discussed in IRC this is consistent with what we have. Switched the .cla= ng-format to use "AllDefinitions" instead which doesn't change anything but= better matches our policy. File src/openvpn/console_builtin.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/9b83c0b1_41c7cd5f : PS18, Line 74: msg(M_WARN | M_ERRNO, "get_console_input_win32(): un= expected error"); > Interestingly one of the things we can't configure in clang-format. [=E2= =80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e Gerrit-Change-Number: 791 Gerrit-PatchSet: 19 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: cron2 Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: ordex Gerrit-Comment-Date: Mon, 26 May 2025 10:40:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --iUHS09Tj6OI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, ordex, plaisthos.

View C= hange

4 comments:

    =
  • File src/openvpn/buffer.c:

  • File src/openvpn/comp.h:

    • Patch Set #18, Line 93: bool check_compression_settings_valid(= struct compress_options *info, int msglevel);

      this is= one of the changes I'm not sure we want - having the return type on th= e line before gives us [=E2=80=A6]

      As discussed in IRC this is consistent w= ith what we have. Switched the .clang-format to use "AllDefinitions&qu= ot; instead which doesn't change anything but better matches our policy= .

  • File src/openvp= n/console_builtin.c:

    • Patch Set #18, Line 74: msg(M_WARN | M_ERRNO, "get_console_input_win32(): unexpecte= d error");

      Interestingly one of the things we ca= n't configure in clang-format. [=E2=80=A6]

      Done

=

To view, visit change 791. To unsubscribe, or for help writing mail filters,= visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b= 8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 19
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: cron2 <gert@...1296...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <antonio@...2726...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: ordex <antonio@...2726...= >
Gerrit-Comment-Date: Mon, 26 May 2025 10:40:42= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--iUHS09Tj6OI=--