From: "flichtenheld (Code Review)" Date: Sat, 4 Apr 2026 16:51:32 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <03a5d55010a8bc6e06ec5423d753ac94fa382738-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Csu8YMntD3g="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: OpenSSL 4.0: Use X509_check_certificate_times instead of X509_cmp_time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --Csu8YMntD3g= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerr= it.openvpn.net/c/openvpn/+/1595?usp=3Demail ) Change subject: OpenSSL 4.0: Use X509_check_certificate_times instead of X5= 09_cmp_time ...................................................................... Patch Set 3: (1 comment) File src/openvpn/ssl_openssl.c: http://gerrit.openvpn.net/c/openvpn/+/1595/comment/7faf7350_74c0cf48?usp=3D= email : PS3, Line 688: if (error =3D=3D X509_V_ERR_ERROR_IN_CERT_NOT_BEFORE_FIE= LD) Not sure whether that is bikeshedding, but should we maybe use a case state= ment here? Looks more appropriate for checking the same variable against 4 = values. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1595?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6c2eda0e5bbb3a70b404f821e25ded81f0f5ddd5 Gerrit-Change-Number: 1595 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Sat, 04 Apr 2026 16:51:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No --Csu8YMntD3g= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

View = Change

1 comment:

    =
  • File src/openvpn/ssl_openssl.c:

    =
    • Patch Set= #3, Line 688: if (= error =3D=3D X509_V_ERR_ERROR_IN_CERT_NOT_BEFORE_FIELD)

      Not sur= e whether that is bikeshedding, but should we maybe use a case statement he= re? Looks more appropriate for checking the same variable against 4 values.=

To view, visit change 1595. To unsubscribe, or for h= elp writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6c2eda0e5bbb3a70b404f821e25= ded81f0f5ddd5
Gerrit-Change-Number: 1595
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Sat, 04 Apr 2026 16:51:32= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
= --Csu8YMntD3g=--