From: Patrick DELAUNAY Date: Wed, 22 Apr 2020 09:06:34 +0000 Subject: [PATCH V2 5/6] ARM: dts: stm32: Rework DDR DT inclusion In-Reply-To: <20200410185550.152712-5-marex@denx.de> References: <20200410185550.152712-1-marex@denx.de> <20200410185550.152712-5-marex@denx.de> Message-ID: <03cc3672967d4054a9bc22ef0f2edb06@SFHDAG6NODE3.st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek, > From: Marek Vasut > Sent: vendredi 10 avril 2020 20:56 > > Adjust the DDR configuration dtsi such that they only generate the DRAM > configuration node, the DDR controller node is moved into the stm32mp157-u- > boot.dtsi itself. This permits including multiple DDR configuration dtsi files in > board DT. > > Signed-off-by: Marek Vasut > Cc: Manivannan Sadhasivam > Cc: Patrick Delaunay > Cc: Patrice Chotard > --- > V2: Add compatible string > --- > arch/arm/dts/stm32mp15-ddr.dtsi | 358 +++++++++++------- > .../dts/stm32mp15-ddr3-1x4Gb-1066-binG.dtsi | 1 + > .../dts/stm32mp15-ddr3-2x4Gb-1066-binG.dtsi | 1 + > arch/arm/dts/stm32mp157-u-boot.dtsi | 25 ++ > 4 files changed, 248 insertions(+), 137 deletions(-) > > diff --git a/arch/arm/dts/stm32mp15-ddr.dtsi b/arch/arm/dts/stm32mp15-ddr.dtsi > index 38f29bb789..026237b088 100644 > --- a/arch/arm/dts/stm32mp15-ddr.dtsi > +++ b/arch/arm/dts/stm32mp15-ddr.dtsi > @@ -2,153 +2,237 @@ > /* > * Copyright : STMicroelectronics 2018 > */ > +#include > > -/ { > - soc { > - ddr: ddr at 5a003000 { > - u-boot,dm-pre-reloc; > +&ddr { > + config-DDR_MEM_COMPATIBLE { > + u-boot,dm-pre-reloc; > - compatible = "st,stm32mp1-ddr"; > + compatible = __stringify(st,DDR_MEM_COMPATIBLE); I have just a concern here, but only for ST ecosystem. As the DDR_MEM_COMPATIBLE is not generated by CubeMX tools. But I will manage it after..... 2 solution; I add a default value. #ifndef DDR_MEM_COMPATIBLE #define DDR_MEM_COMPATIBLE ddr-0 #endif Or don't create sub-node when the COMPATIBLE is absent. So for this patch: Reviewed-by: Patrick Delaunay Thanks Patrick