From: "cron2 (Code Review)" Date: Mon, 28 Jul 2025 10:07:59 +0000 References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <03e1861be3be01fbf35d7513e8226fc8a13b7566-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="BQAR7gIenyc="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: unit_tests/plugins/auth-pam: fix stdint.h related build error on fedo... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --BQAR7gIenyc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1118?usp=3Demail to review the following change. Change subject: unit_tests/plugins/auth-pam: fix stdint.h related build err= or on fedora 42 ...................................................................... unit_tests/plugins/auth-pam: fix stdint.h related build error on fedora 42 add to test_search_and_replace.c to fix build error on fedora 42 / arm64 ("error: uintptr_t undeclared") Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763 Signed-off-by: Gert Doering --- M tests/unit_tests/plugins/auth-pam/test_search_and_replace.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/18/1118/1 diff --git a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c b/= tests/unit_tests/plugins/auth-pam/test_search_and_replace.c index d40467f..50b241d 100644 --- a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c +++ b/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c @@ -2,6 +2,7 @@ #include #include #include +#include #include #include #include -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1118?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763 Gerrit-Change-Number: 1118 Gerrit-PatchSet: 1 Gerrit-Owner: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --BQAR7gIenyc= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

cron2 would like plaisthos and flichtenheld to review t= his change.

V= iew Change

unit_tests/plugins/auth-pam: fix stdint.h related build erro=
r on fedora 42

add <stdint.h> to test_search_and_replace.c to = fix build error on
fedora 42 / arm64 ("error: uintptr_t undeclared&= quot;)

Change-Id: I2ab13767b5aa858e024b45be3d161bf6090de763
Signe= d-off-by: Gert Doering <gert@...1296...>
---
M tests/unit_tests= /plugins/auth-pam/test_search_and_replace.c
1 file changed, 1 insertion(= +), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvp=
n refs/changes/18/1118/1
diff --git a/tests/unit_tests/plugins/auth=
-pam/test_search_and_replace.c b/tests/unit_tests/plugins/auth-pam/test_sea=
rch_and_replace.c
index d40467f..50b241d 100644
<= span>--- a/tests/unit_tests/plugins/auth-pam/test_search_and_replace.c
+++ b/tests/unit_tests/plugins/auth-pam/test_search_and_replace= .c
@@ -2,6 +2,7 @@
#include <unistd.h&g= t;
#include <stdlib.h>
#include <= ;stdarg.h>
+#inclu= de <stdint.h>
#include <string.h>
#include <setjmp.h>
#include <cmocka.h>

To view, visit change 1118. To unsubscribe, = or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2ab13767b5aa858e024b45be3d1= 61bf6090de763
Gerrit-Change-Number: 1118
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--BQAR7gIenyc=--