Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBFCFC433EF for ; Tue, 11 Jan 2022 13:02:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E914283025; Tue, 11 Jan 2022 14:02:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="hiBoqU1B"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 30FC281A03; Tue, 11 Jan 2022 14:02:15 +0100 (CET) Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4EE8A83025 for ; Tue, 11 Jan 2022 14:02:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id B86B722236; Tue, 11 Jan 2022 14:02:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1641906131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jgnhz0hscqn5eQoyNlL7gng7JSN59tQJYOgIaznRFx8=; b=hiBoqU1BS3vCpHiNTuiMNkeoJryQUOgoXqrRdTkRiEBnvJT1PF8sLyVHO0sF58bGmWmJR9 4PaYNu5mYyhRAQxoIwudsmUFwSIyFFqFPVfa/3Z31aM95ur+dnLm31GIXGgSXLObuSqKOA 8Zf3XRja76VybQVv5l+MlTHE0Yp/ENM= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 11 Jan 2022 14:02:11 +0100 From: Michael Walle To: Gaurav Jain Cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Peng Fan , Simon Glass , Priyanka Jain , Ye Li , Horia Geanta , Ji Luo , Franck Lenormand , Silvano Di Ninno , Sahil Malhotra , Pankaj Gupta , Varun Sethi , dl-uboot-imx , Shengzhou Liu , Mingkai Hu , Rajesh Bhagat , Meenakshi Aggarwal , Wasim Khan , Alison Wang , Pramod Kumar , Andy Tang , Adrian Alonso , Vladimir Oltean Subject: Re: [EXT] Re: [PATCH v9 11/14] Layerscape: Enable Job ring driver model. In-Reply-To: References: <20220111112805.3566-1-gaurav.jain@nxp.com> <20220111112805.3566-12-gaurav.jain@nxp.com> <351ca3d1f19b0d3b0e336fe98de9e3fa@walle.cc> User-Agent: Roundcube Webmail/1.4.12 Message-ID: <0453419c4e9c739d78c8d62b06b6c2f9@walle.cc> X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, Am 2022-01-11 13:55, schrieb Gaurav Jain: >> >> > diff --git a/configs/ls2088ardb_tfa_defconfig >> >> > b/configs/ls2088ardb_tfa_defconfig >> >> > index a28b45b129..5230d7ead8 100644 >> >> > --- a/configs/ls2088ardb_tfa_defconfig >> >> > +++ b/configs/ls2088ardb_tfa_defconfig >> >> > @@ -53,7 +53,6 @@ CONFIG_ENV_ADDR=0x580500000 >> >> > CONFIG_NET_RANDOM_ETHADDR=y CONFIG_DM=y >> CONFIG_SATA_CEVA=y >> >> > -CONFIG_FSL_CAAM=y >> >> > CONFIG_DDR_CLK_FREQ=133333333 >> >> > CONFIG_DDR_ECC=y >> >> > CONFIG_ECC_INIT_VIA_DDRCONTROLLER=y >> >> .. >> >> >> >> I still don't understand why you make the FSL_CAAM mandatory and >> >> remove the option here. Same for all other boards. >> > Instead of enabling FSL_CAAM in every defconfig for a particular >> > board, I moved FSL_CAAM to specific TARGET boards. >> > this will enable FSL_CAAM to every defconfig for a target board. >> >> But a user/developer cannot disable that option anymore in this case. > I have enabled FSL_CAAM only for the boards that are enabling CAAM > previously as well. > Current change make it easy, else I have to make change in each > defconfig for all target boards. But a defconfig is, as the name says, just the default config. A user can still disable the CAAM driver. If you instead add it as a "select FSL_CAAM" to the TARGET_ symbol, the user cannot disable it anymore. -michael