From: "cron2 (Code Review)" Date: Mon, 20 Apr 2026 17:31:46 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <04bf960dc2fccdf797588c157be71d5469ae71cb-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="rSInf1T+uDg="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: GHA: Factor out building SSL libs to a reusable workflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --rSInf1T+uDg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#4) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1630?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by uddr Change subject: GHA: Factor out building SSL libs to a reusable workflow ...................................................................... GHA: Factor out building SSL libs to a reusable workflow We amassed a lot of code duplication there. Make it easier to track the differences between the libraries. Change-Id: I3d89016ccae297cfa596897c11a518f1ffbe3dc8 Signed-off-by: Frank Lichtenheld Acked-by: Yuriy Darnobyt Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1630 Message-Id: <20260420160732.9492-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 686.html Signed-off-by: Gert Doering --- M .github/workflows/build.yaml A .github/workflows/test-ssllib.yml M renovate.json 3 files changed, 155 insertions(+), 313 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/1630/4 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 365e72a..e4cb799 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -304,324 +304,49 @@ !${{ github.workspace }}/out/**/vcpkg_installed/** libressl: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [libressl] - build: [ normal, asan ] - configureflags: ["--with-openssl-engine=3Dno"] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}}" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - UBSAN_OPTIONS: print_stacktrace=3D1 + uses: ./.github/workflows/test-ssllib.yml + with: + libname: libressl + ovpnlibdesc: LibreSSL # versioning=3Dsemver-coerced - LIBRESSL_REPO: libressl/portable - LIBRESSL_VERSION: v4.2.1 - LIBRESSL_INSTALL: /opt/libressl + ghrepo: libressl/portable + gitref: v4.2.1 + libconfigure: "LIBRESSL_GIT_OPTIONS=3D--no-single-branch ./autogen.s= h && ./configure --prefix=3D$LIBPREFIX" - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev - - name: Restore libressl from cache - uses: actions/cache@...3010... - id: libressl-cache - with: - path: ${{ env.LIBRESSL_INSTALL }} - key: ${{ matrix.os }}-libressl-${{matrix.build }}-${{ env.LIBRES= SL_VERSION }} - - name: "libressl: checkout" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: libressl - repository: ${{ env.LIBRESSL_REPO }} - ref: ${{ env.LIBRESSL_VERSION }} - - name: "libressl: autogen.sh" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - env: - LIBRESSL_GIT_OPTIONS: "--no-single-branch" - run: ./autogen.sh - working-directory: libressl - - name: "libressl: configure" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - run: ./configure --prefix=3D${{ env.LIBRESSL_INSTALL }} - working-directory: libressl - - name: "libressl: make all" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - run: make -j3 - working-directory: libressl - - name: "libressl: make install" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - run: sudo make install - working-directory: libressl - - name: "ldconfig" - run: sudo ldconfig - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure - run: | - OPENSSL_CFLAGS=3D"-I${{ env.LIBRESSL_INSTALL }}/include" \ - OPENSSL_LIBS=3D"-L${{ env.LIBRESSL_INSTALL }}/lib -lssl -lcrypto= " \ - LDFLAGS=3D"-Wl,-rpath=3D${{ env.LIBRESSL_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl --enable-werror ${{m= atrix.configureflags}} - - name: make all - run: make -j3 - - name: Ensure the build uses LibreSSL - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: Lib= reSSL" - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 - - openssl: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [openssl] - build: [ normal, asan ] - configureflags: ["--with-openssl-engine=3Dno"] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}} - 4.0" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - UBSAN_OPTIONS: print_stacktrace=3D1 + openssl4: + uses: ./.github/workflows/test-ssllib.yml + with: + libname: openssl + ovpnlibdesc: OpenSSL 4. # versioning=3Dsemver-coerced - OPENSSL_REPO: openssl/openssl - OPENSSL_VERSION: openssl-4.0.0-beta1 - OPENSSL_INSTALL: /opt/openssl - - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev - - name: Restore OpenSSL 4.0 from cache - uses: actions/cache@...3010... - id: openssl-cache - with: - path: ${{ env.OPENSSL_INSTALL }} - key: ${{ matrix.os }}-openssl-${{matrix.build }}-${{ env.OPENSSL= _VERSION }} - - name: "openssl: checkout" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: openssl - repository: ${{ env.OPENSSL_REPO }} - ref: ${{ env.OPENSSL_VERSION }} - - name: "openssl: configure" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - run: ./Configure --prefix=3D${{ env.OPENSSL_INSTALL }} --libdir= =3D${{ env.OPENSSL_INSTALL }}/lib --openssldir=3D${{ env.OPENSSL_INSTALL }}= -g - working-directory: openssl - - name: "openssl: make all" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - run: make -j3 - working-directory: openssl - - name: "openssl: make install" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - run: sudo make install - working-directory: openssl - - name: "ldconfig" - run: sudo ldconfig - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure - run: | - OPENSSL_CFLAGS=3D"-I${{ env.OPENSSL_INSTALL }}/include" \ - OPENSSL_LIBS=3D"-L${{ env.OPENSSL_INSTALL }}/lib -lssl -lcrypto"= \ - LDFLAGS=3D"-Wl,-rpath=3D${{ env.OPENSSL_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl --enable-werror ${{m= atrix.configureflags}} - - name: make all - run: make -j3 - - name: Ensure the build uses Openssl - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: Ope= nSSL 4.0" - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 + ghrepo: openssl/openssl + gitref: openssl-4.0.0-beta1 + libconfigure: ./Configure --prefix=3D$LIBPREFIX --libdir=3D$LIBPREFI= X/lib --openssldir=3D$LIBPREFIX -g mbedtls4: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [mbedtls4] - build: [ normal, asan ] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}}" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - UBSAN_OPTIONS: print_stacktrace=3D1 - PKG_CONFIG_PATH: /opt/mbedtls4/lib/pkgconfig + uses: ./.github/workflows/test-ssllib.yml + with: + libname: mbedtls + ovpnlibname: mbedtls + ovpnlibdesc: mbed TLS 4. # versioning=3Dsemver-coerced - MBEDTLS_REPO: Mbed-TLS/mbedtls - MBEDTLS_VERSION: v4.0.0 - MBEDTLS_INSTALL: /opt/mbedtls4 - - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = python3-jinja2 python3-jsonschema libtool automake autoconf pkg-config libc= ap-ng-dev libnl-genl-3-dev - - name: Restore mbed TLS from cache - uses: actions/cache@...3010... - id: mbedtls-cache - with: - path: ${{ env.MBEDTLS_INSTALL }} - key: ${{ matrix.os }}-mbedtls-${{matrix.build }}-${{ env.MBEDTLS= _VERSION }} - - name: "mbedtls: checkout" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: mbedtls - submodules: recursive - repository: ${{ env.MBEDTLS_REPO }} - ref: ${{ env.MBEDTLS_VERSION }} - - uses: lukka/get-cmake@...2999... # v4.2.3 - - name: "mbedtls: cmake" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - run: cmake -B build -DCMAKE_INSTALL_PREFIX=3D${{ env.MBEDTLS_INSTA= L }} - working-directory: mbedtls - - name: "mbedtls: cmake --build" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - run: cmake --build build - working-directory: mbedtls - - name: "mbedtls: cmake --install" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - run: sudo cmake --install build - working-directory: mbedtls - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure - run: ./configure --with-crypto-library=3Dmbedtls --enable-werror - - name: make all - run: make -j3 - - name: Ensure the build uses mbed TLS ${{ env.MBEDTLS_VERSION }} - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: mbe= d TLS 4." - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 + ghrepo: Mbed-TLS/mbedtls + gitref: v4.0.0 + libconfigure: cmake -B build -DCMAKE_INSTALL_PREFIX=3D$LIBPREFIX + libmake: cmake --build build + libinstall: sudo cmake --install build + ovpnconfigureenv: PKG_CONFIG_PATH=3D$LIBPREFIX/lib/pkgconfig aws-lc: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [ awslc ] - build: [ normal, asan ] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - cxx: clang++ - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - cxx: c++ - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}}" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - CXX: ${{matrix.cxx}} - UBSAN_OPTIONS: print_stacktrace=3D1 - AWS_LC_INSTALL: /opt/aws-lc + uses: ./.github/workflows/test-ssllib.yml + with: + libname: aws-lc + ovpnlibdesc: AWS-LC # versioning=3Dsemver-coerced - AWS_LC_REPO: aws/aws-lc - AWS_LC_VERSION: v1.70.0 - - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y gcc golang make liblzo= 2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka-dev p= ython3-docutils python3-jinja2 python3-jsonschema libtool automake autoconf= pkg-config libcap-ng-dev libnl-genl-3-dev - - name: Restore AWS-LC from cache - uses: actions/cache@...3010... - id: aws-lc-cache - with: - path: ${{ env.AWS_LC_INSTALL }} - key: ${{ matrix.os }}-aws-lc-${{matrix.build }}-${{ env.AWS_LC_V= ERSION }} - - name: "AWS-LC: checkout" - if: steps.aws-lc-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: aws-lc - repository: ${{ env.AWS_LC_REPO }} - ref: ${{ env.AWS_LC_VERSION }} - - uses: lukka/get-cmake@...2999... # v4.2.3 - - name: "AWS-LC: build" - if: steps.aws-lc-cache.outputs.cache-hit !=3D 'true' - run: | - mkdir build - cd build - cmake -GNinja -DCMAKE_BUILD_TYPE=3DRelease -DCMAKE_INSTALL_PREFI= X=3D"${{ env.AWS_LC_INSTALL }}" -DBUILD_SHARED_LIBS=3D1 ../ - ninja install - working-directory: aws-lc - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure with AWS-LC - run: | - OPENSSL_CFLAGS=3D"-I${{ env.AWS_LC_INSTALL }}/include" \ - OPENSSL_LIBS=3D"-L${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \ - LDFLAGS=3D"-Wl,-rpath=3D${{ env.AWS_LC_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl - - name: make all - run: make -j3 - - name: Ensure the build uses AWS-LC - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: AWS= -LC" - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 + ghrepo: aws/aws-lc + gitref: v1.70.0 + libconfigure: cmake -B build -GNinja -DCMAKE_BUILD_TYPE=3DRelease -D= CMAKE_INSTALL_PREFIX=3D"$LIBPREFIX" -DBUILD_SHARED_LIBS=3D1 + libmake: cmake --build build + libinstall: sudo cmake --install build + # not ready for --enable-werror + ovpnconfigureflags: diff --git a/.github/workflows/test-ssllib.yml b/.github/workflows/test-ssl= lib.yml new file mode 100644 index 0000000..c6a2e44 --- /dev/null +++ b/.github/workflows/test-ssllib.yml @@ -0,0 +1,117 @@ +name: test_ssllib + +on: + workflow_call: + inputs: + libname: + required: true + type: string + ovpnlibname: + type: string + default: openssl + ovpnlibdesc: + required: true + type: string + ghrepo: + required: true + type: string + gitref: + required: true + type: string + libconfigure: + required: true + type: string + libmake: + type: string + default: "make -j3" + libinstall: + type: string + default: "sudo make install" + ovpnconfigureenv: + type: string + default: >- + OPENSSL_CFLAGS=3D"-I$LIBPREFIX/include" + OPENSSL_LIBS=3D"-L$LIBPREFIX/lib -lssl -lcrypto" + LDFLAGS=3D"-Wl,-rpath=3D$LIBPREFIX/lib" + ovpnconfigureflags: + type: string + default: --enable-werror --with-openssl-engine=3Dno + +jobs: + test_ssllib: + strategy: + fail-fast: false + matrix: + os: [ubuntu-24.04] + build: [normal, asan] + include: + - build: asan + cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" + ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall + cc: clang + cxx: clang++ + - build: normal + cflags: "-O2 -g" + ldflags: "" + cc: gcc + cxx: g++ + + name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{inputs.l= ibname}}" + runs-on: ${{matrix.os}} + env: + CFLAGS: ${{matrix.cflags}} + LDFLAGS: ${{matrix.ldflags}} + CC: ${{matrix.cc}} + CXX: ${{matrix.cxx}} + UBSAN_OPTIONS: print_stacktrace=3D1 + LIBPREFIX: /opt/${{inputs.libname}} + + steps: + - name: Install dependencies + run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev + - name: Restore ${{inputs.libname}} from cache + uses: actions/cache@...3024... # v5.0.5 + id: ssllib-cache + with: + path: ${{env.LIBPREFIX}} + key: ${{matrix.os}}-${{inputs.libname}}-${{matrix.build }}-${{in= puts.gitref}} + - name: "${{inputs.libname}}: checkout" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + uses: actions/checkout@...2998... # v6.0.2 + with: + submodules: recursive + path: ${{inputs.libname}} + repository: ${{inputs.ghrepo}} + ref: ${{inputs.gitref}} + - name: "${{inputs.libname}}: configure" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + run: ${{inputs.libconfigure}} + working-directory: ${{inputs.libname}} + - name: "${{inputs.libname}}: build" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + run: ${{inputs.libmake}} + working-directory: ${{inputs.libname}} + - name: "${{inputs.libname}}: install" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + run: ${{inputs.libinstall}} + working-directory: ${{inputs.libname}} + - name: Run ldconfig + run: sudo ldconfig + - name: "OpenVPN: checkout" + uses: actions/checkout@...2998... # v6.0.2 + - name: "OpenVPN: autoreconf" + run: autoreconf -fvi + - name: "OpenVPN: configure" + run: | + ${{inputs.ovpnconfigureenv}} \ + ./configure --with-crypto-library=3D${{inputs.ovpnlibname}} ${{i= nputs.ovpnconfigureflags}} + - name: "OpenVPN: build" + run: make -j3 + - name: Ensure the build uses ${{inputs.libname}} + run: | + ./src/openvpn/openvpn --version + ./src/openvpn/openvpn --version | grep -q "library versions: ${{= inputs.ovpnlibdesc}}" + - name: "OpenVPN: configure checks" + run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc + - name: "OpenVPN: make check" + run: make -j3 check VERBOSE=3D1 diff --git a/renovate.json b/renovate.json index f9c62c4..809ac3f 100644 --- a/renovate.json +++ b/renovate.json @@ -40,7 +40,7 @@ "/^\\.github/workflows/.+\\.ya?ml$/" ], "matchStrings": [ - "versioning=3D(?.*?)\\n\\s*.*?_REPO:\\s*(?.*?)\\n\\s*.*?_VERSION:\\s*(?.*?)\\n" + "versioning=3D(?.*?)\\n\\s*ghrepo:\\s*(?.*?)\\n\\s*gitrepo:\\s*(?.*?)\\n" ], "datasourceTemplate": "github-tags" } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1630?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3d89016ccae297cfa596897c11a518f1ffbe3dc8 Gerrit-Change-Number: 1630 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: uddr Gerrit-CC: openvpn-devel --rSInf1T+uDg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #4 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by uddr

GHA: Factor out building SSL libs to=
 a reusable workflow

We amassed a lot of code duplication there. Mak= e
it easier to track the differences between the libraries.

Chang= e-Id: I3d89016ccae297cfa596897c11a518f1ffbe3dc8
Signed-off-by: Frank Lic= htenheld <frank@...2641...>
Acked-by: Yuriy Darnobyt <yura.uddr= @...277...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1630Message-Id: <20260420160732.9492-1-gert@...1296...>
URL: https:/= /www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36686.html
= Signed-off-by: Gert Doering <gert@...1296...>
---
M .github/wor= kflows/build.yaml
A .github/workflows/test-ssllib.yml
M renovate.json=
3 files changed, 155 insertions(+), 313 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/16=
30/4
diff --git a/.github/workflows/build.yaml b/.github/workflows/=
build.yaml
index 365e72a..e4cb799 100644
--= - a/.github/workflows/build.yaml
+++ b/.github/workflows/bu= ild.yaml
@@ -304,324 +304,49 @@
= !${{ github.workspace }}/out/**/vcpkg_installed/**

libressl:
- = fail-fast: false
- = matrix:
- os: = [ubuntu-24.04]
- = ssllib: [libressl]
- = build: [ normal, asan ]
- configureflags: ["--with-openssl-engine=3Dno"]
- include:<= br>- - build: asan
- cflags: "-= fsanitize=3Daddress -fno-sanitize-recover=3Dall -fno-optimize-sibling-call= s -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1"
- ldflags: -f= sanitize=3Daddress -fno-sanitize-recover=3Dall
- cc: clang
- - build: normal
- cflags: "-O2 -g"<= br>- ldflags: "&q= uot;
- cc: g= cc
-
- name: "${{matrix.cc}} ${{matrix= .build}} - ${{matrix.os}} - ${{matrix.ssllib}}"
- runs-on: ${{matrix.os}}
- env:

- CFLAGS: ${{ matrix.cflags }}
- LDFLAGS: ${{ matrix.ldflags }}<= /span>
- CC: ${{matrix.cc= }}
- UBSAN_OPTIONS= : print_stacktrace=3D1
+ with:
+ libname: libressl
+ ovpnlibdesc: LibreSSL
#= versioning=3Dsemver-coerced
- LIBRESSL_REPO: libressl/portable
- LIBRESSL_VERSION: v4.2.1
- LIBRESSL_INSTALL: /opt/libressl
+ ghrepo: libressl/p= ortable
+ gitref= : v4.2.1
+ libco= nfigure: "LIBRESSL_GIT_OPTIONS=3D--no-single-branch ./autogen.sh &= & ./configure --prefix=3D$LIBPREFIX"

<= span style=3D"color: hsl(0, 100%, 40%);">- steps:

- - name: Install dependencies- run: sudo apt update &= amp;& sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-lib= c-dev man2html clang libcmocka-dev python3-docutils libtool automake autoco= nf pkg-config libcap-ng-dev libnl-genl-3-dev
- - name: Restore libressl from cache
= - uses: actions/cache@...3017...= 010...
- id: lib= ressl-cache
- wi= th:
- path: ${= { env.LIBRESSL_INSTALL }}
- key: ${{ matrix.os }}-libressl-${{matrix.build }}-${{ env.LIB= RESSL_VERSION }}
- = - name: "libressl: checkout"
- if: steps.libressl-cache.outputs.cache-hit !=3D &= #39;true'
- = uses: actions/checkout@...2998... # v6.0.2
- with:
- path: libressl
- repository: ${{ env.LIBRESSL_REPO }}
- ref: ${{ env.LIBRESSL_VE= RSION }}

- - name:= "libressl: autogen.sh"
- if: steps.libressl-cache.outputs.cache-hit !=3D 'tr= ue'
- env:
- LIBRESSL_GIT_= OPTIONS: "--no-single-branch"
- run: ./autogen.sh
- working-directory: libressl
- - name: "libressl: configure= "
- if: ste= ps.libressl-cache.outputs.cache-hit !=3D 'true'
- run: ./configure --prefix=3D${{ e= nv.LIBRESSL_INSTALL }}
= - working-directory: libressl
- - name: "libressl: make all"
- if: steps.libressl-cache.outp= uts.cache-hit !=3D 'true'

- run: make -j3
- working-directory: libressl
- - name: "libressl: make install"<= /span>
- if: steps.libr= essl-cache.outputs.cache-hit !=3D 'true'
- run: sudo make install
- working-directory: libressl
- - name: "ldcon= fig"
- run:= sudo ldconfig
- -= name: Checkout OpenVPN
- uses: actions/checkout@...2998... # v6.0.2
- - name: autoconf
- run: autoreconf -fvi
- - name: configure

<= span style=3D"color: hsl(0, 100%, 40%);">- run: |

- OPENSSL_CFLAGS=3D"-I${{ e= nv.LIBRESSL_INSTALL }}/include" \
- OPENSSL_LIBS=3D"-L${{ env.LIBRESSL_INSTALL = }}/lib -lssl -lcrypto" \
- LDFLAGS=3D"-Wl,-rpath=3D${{ env.LIBRESSL_INSTALL }}/= lib" \
- = ./configure --with-crypto-library=3Dopenssl --enable-werror ${{matrix.confi= gureflags}}
- - na= me: make all
- r= un: make -j3
- - n= ame: Ensure the build uses LibreSSL
- run: |
- ./src/openvpn/openvpn --version
- ./src/openvpn/openvpn --version | grep= -q "library versions: LibreSSL"
- - name: configure checks
- run: echo 'RUN_SUDO=3D"sud= o -E"' >tests/t_server_null.rc
- - name: make check
- run: make -j3 check VERBOSE=3D1
<= span style=3D"color: hsl(0, 100%, 40%);">-

- openssl:
- strategy:
- fail-fast: false
- = os: [ubuntu-24.04]
-= ssllib: [openssl]
- build: [ normal, asan ]
- configureflags: ["--with-openssl-engine=3Dno&quo= t;]
- include:
- - build: asan=
- cflags: &= quot;-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fno-optimize-siblin= g-calls -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1&q= uot;
- ldfla= gs: -fsanitize=3Daddress -fno-sanitize-recover=3Dall
- cc: clang
- - build: normal
- cflags: "-O2 -g"<= /span>
- ldflags: &= quot;"
- = cc: gcc
-
<= span style=3D"color: hsl(0, 100%, 40%);">- name: "${{matrix.cc}} ${= {matrix.build}} - ${{matrix.os}} - ${{matrix.ssllib}} - 4.0"
- runs-on: ${{matrix.os}}
- env:
- CFLAGS: ${{ matrix.cflags }}
- LDFLAGS: ${{ matrix= .ldflags }}
- CC: = ${{matrix.cc}}
- U= BSAN_OPTIONS: print_stacktrace=3D1
+ openssl4:
+ uses: ./.github/workflows/test-ssllib.yml
+ with:
+ libname: openssl
+ ovpnlibdesc: OpenSSL 4.
= # versioning=3Dsemver-coerced
- OPENSSL_REPO: openssl/openssl
- OPENSSL_VERSION: openssl-4.0.0-beta1
- OPENSSL_INSTALL: /opt= /openssl
-
- steps:

- - name: Install dependencies- run: sudo apt update &= amp;& sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev linux-lib= c-dev man2html clang libcmocka-dev python3-docutils libtool automake autoco= nf pkg-config libcap-ng-dev libnl-genl-3-dev
- - name: Restore OpenSSL 4.0 from cache<= br>- uses: actions/cache@...220...= ..3010...
- id: = openssl-cache
- = with:
- path: = ${{ env.OPENSSL_INSTALL }}
- key: ${{ matrix.os }}-openssl-${{matrix.build }}-${{ env.OPE= NSSL_VERSION }}
- = - name: "openssl: checkout"
- if: steps.openssl-cache.outputs.cache-hit !=3D '= ;true'
- use= s: actions/checkout@...2998... # v6.0.2
- with:
- path: openssl
- repository: ${{ env.OPENSSL_REPO }}
- ref: ${{ env.OPENSSL_VERSION = }}
- - name: "= ;openssl: configure"
- if: steps.openssl-cache.outputs.cache-hit !=3D 'true'
- run: ./Configur= e --prefix=3D${{ env.OPENSSL_INSTALL }} --libdir=3D${{ env.OPENSSL_INSTALL= }}/lib --openssldir=3D${{ env.OPENSSL_INSTALL }} -g
- working-directory: openssl- - name: "openssl: m= ake all"
- = if: steps.openssl-cache.outputs.cache-hit !=3D 'true'
- run: make -j3

- working-directory: openssl<= /span>
- - name: "op= enssl: make install"
- if: steps.openssl-cache.outputs.cache-hit !=3D 'true'
- run: sudo make = install
- workin= g-directory: openssl
- = - name: "ldconfig"
- run: sudo ldconfig
- - name: Checkout OpenVPN
- uses: actions/checkout@...2998... # v6.0.= 2
- - name: autoco= nf
- run: autore= conf -fvi
- - name= : configure
- ru= n: |
- OPENSSL= _CFLAGS=3D"-I${{ env.OPENSSL_INSTALL }}/include" \
- OPENSSL_LIBS=3D"-L${{= env.OPENSSL_INSTALL }}/lib -lssl -lcrypto" \

- LDFLAGS=3D"-Wl,-rpath=3D${{ env= .OPENSSL_INSTALL }}/lib" \
- ./configure --with-crypto-library=3Dopenssl --enable-we= rror ${{matrix.configureflags}}
- - name: make all
- run: make -j3
- - name: Ensure the build uses Openssl
- run: |
- ./src/openvpn/openvpn --version<= br>- ./src/openvpn/openv= pn --version | grep -q "library versions: OpenSSL 4.0"
= - - name: configure checks
- run: echo '= RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc
- - name: make check
- run: make -j3 check VER= BOSE=3D1
+ ghrep= o: openssl/openssl
+ = gitref: openssl-4.0.0-beta1
+ libconfigure: ./Configure --prefix=3D$LIBPREFIX --libdir= =3D$LIBPREFIX/lib --openssldir=3D$LIBPREFIX -g

= mbedtls4:
- = strategy:
- fail-= fast: false
- matr= ix:
- os: [ubunt= u-24.04]
- sslli= b: [mbedtls4]
- = build: [ normal, asan ]
- include:
- = - build: asan
- = cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall = -fno-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-fr= ame-pointer -g -O1"
- cc: clang
- - build: norma= l
- cflags: = "-O2 -g"
- = ldflags: ""
- cc: gcc
-
- name: &quo= t;${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.ssllib}}&qu= ot;
- runs-on: ${{ma= trix.os}}
- env:

- CFLAGS: ${{ matrix.= cflags }}
- LDFLAG= S: ${{ matrix.ldflags }}
- UBSAN_OPTIONS: print_stacktrace=3D1
- PKG_CONFIG_PATH: /opt/mbedtls4/lib/pkgconfi= g
+ uses: ./.githu= b/workflows/test-ssllib.yml
+ with:
+ = libname: mbedtls
= + ovpnlibname: mbedtls
+ ovpnlibdesc: mbed TLS 4.
# versioning= =3Dsemver-coerced
- = MBEDTLS_REPO: Mbed-TLS/mbedtls
- MBEDTLS_VERSION: v4.0.0
- MBEDTLS_INSTALL: /opt/mbedtls4
-
- steps:
- - name: Install dependencies
- run: sudo apt update && sudo apt install -y = liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka= -dev python3-docutils python3-jinja2 python3-jsonschema libtool automake au= toconf pkg-config libcap-ng-dev libnl-genl-3-dev
- - name: Restore mbed TLS from cache=
- uses: actions/cache@= ...3010...
- id:= mbedtls-cache
- = with:
- path:= ${{ env.MBEDTLS_INSTALL }}
- key: ${{ matrix.os }}-mbedtls-${{matrix.build }}-${{ env.MB= EDTLS_VERSION }}
- = - name: "mbedtls: checkout"
- if: steps.mbedtls-cache.outputs.cache-hit !=3D = 9;true'
- us= es: actions/checkout@...2998... # v6.0.2
- with:
- path: mbedtls
- submodules: recursive
- repository: ${{ env.MBEDTLS_REPO }}=
- ref: ${{ env.MBEDT= LS_VERSION }}
- - = uses: lukka/get-cmake@...2999... # v4.2.3
- - name: "mbedtls: cmake"
- if: steps.mbedtls-cache.outp= uts.cache-hit !=3D 'true'

- run: cmake -B build -DCMAKE_INSTALL_PREFIX=3D${{ env.MB= EDTLS_INSTAL }}
- = working-directory: mbedtls
- - name: "mbedtls: cmake --build"
- if: steps.mbedtls-cache.outputs.c= ache-hit !=3D 'true'
- run: cmake --build build
- working-directory: mbedtls
- - name: "mbedtls: cmake --instal= l"
- if: st= eps.mbedtls-cache.outputs.cache-hit !=3D 'true'
- run: sudo cmake --install build
- working-directo= ry: mbedtls
- - na= me: Checkout OpenVPN
- = uses: actions/checkout@...2998... # v6.0.2
- - name: autoconf
- run: autoreconf -fvi
- - name: configure
- run: ./configure --with-crypt= o-library=3Dmbedtls --enable-werror

- - name: make all
- run: make -j3
- - name: Ensure the build uses mbed TLS ${{ env.MBEDTLS= _VERSION }}
- ru= n: |
- ./src/o= penvpn/openvpn --version
-= - name: configure checks
- run: echo 'RUN_SUDO=3D"sudo -E"' >tes= ts/t_server_null.rc
- = - name: make check
= - run: make -j3 check VERBOSE=3D1
+ ghrepo: Mbed-TLS/mbedtls
+ gitref: v4.0.0
+ libconfigure: cmake -B build -DCMA= KE_INSTALL_PREFIX=3D$LIBPREFIX
+ libmake: cmake --build build
+ libinstall: sudo cmake --install build
+ ovpnconfigureenv: = PKG_CONFIG_PATH=3D$LIBPREFIX/lib/pkgconfig

aws-lc:

- strat= egy:
- fail-fast: = false
- matrix:
- os: [ubuntu-24.0= 4]
- ssllib: [ a= wslc ]
- build: = [ normal, asan ]
- = include:
- = - build: asan
- = cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fno-op= timize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame-poi= nter -g -O1"
- = ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall- cc: clang- cxx: clang++=
- - build: normal
- cflags: &quo= t;-O2 -g"
- = ldflags: ""
- cc: gcc
-
- name: "${{= matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.ssllib}}"
- runs-on: ${{matrix.= os}}
- env:- CFLAGS: ${{ matrix.cflag= s }}
- LDFLAGS: ${= { matrix.ldflags }}
- = CC: ${{matrix.cc}}
= - CXX: ${{matrix.cxx}}
- UBSAN_OPTIONS: print_stacktrace=3D1
- AWS_LC_INSTALL: /opt/aws-lc
+ uses: ./.github/workflows/test-= ssllib.yml

+ with:=
+ libname: aws-= lc
+ ovpnlibdesc= : AWS-LC
# versioning=3Dsemver-coerced
- AWS_LC_REPO: aws/aws-lc
- AWS_LC_VERSION: v1.70= .0
-
- steps:
- - name: Install dependencies
- run: sudo apt update &&= ; sudo apt install -y gcc golang make liblzo2-dev libpam0g-dev liblz4-dev l= inux-libc-dev man2html clang libcmocka-dev python3-docutils python3-jinja2 = python3-jsonschema libtool automake autoconf pkg-config libcap-ng-dev libnl= -genl-3-dev
- - na= me: Restore AWS-LC from cache
- uses: actions/cache@...3010...
- id: aws-lc-cache
- with:
- path: ${{ env.AWS_LC_INSTALL }}
- key: ${{ matrix.os }}-aws= -lc-${{matrix.build }}-${{ env.AWS_LC_VERSION }}

- - name: "AWS-LC: checkout"
- if: steps.aws-lc-ca= che.outputs.cache-hit !=3D 'true'
- uses: actions/checkout@...2998... # v6.0.2
- with:
- path: aws-lc

<= span style=3D"color: hsl(0, 100%, 40%);">- repository: ${{ env.AWS= _LC_REPO }}

- = ref: ${{ env.AWS_LC_VERSION }}
- - uses: lukka/get-cmake@...2999... # v4.2.3
- - name: "AWS-LC: build"= ;
- if: steps.aw= s-lc-cache.outputs.cache-hit !=3D 'true'
- run: |
- mkdir build
- cd build
- cmake -GNinja -DCMAKE_BUILD_TYPE=3DRelease -DCMA= KE_INSTALL_PREFIX=3D"${{ env.AWS_LC_INSTALL }}" -DBUILD_SHARED_LI= BS=3D1 ../
- n= inja install
- w= orking-directory: aws-lc
- uses: actions/checkout@...2998... # v6.0.2
- - name: autoconf

<= span style=3D"color: hsl(0, 100%, 40%);">- run: autoreconf -fvi
- - name: configure wi= th AWS-LC
- run:= |
- OPENSSL_C= FLAGS=3D"-I${{ env.AWS_LC_INSTALL }}/include" \
- OPENSSL_LIBS=3D"-L${{ en= v.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \
- LDFLAGS=3D"-Wl,-rpath=3D${{ env.AWS= _LC_INSTALL }}/lib" \
- ./configure --with-crypto-library=3Dopenssl
- - name: make all
- run: make -j3

- - name: Ensure the build uses A= WS-LC

- run: |
- ./src/openvpn= /openvpn --version
- = ./src/openvpn/openvpn --version | grep -q "library versions: AW= S-LC"
- - nam= e: configure checks
- = run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server= _null.rc
- - name:= make check
- ru= n: make -j3 check VERBOSE=3D1
+ ghrepo: aws/aws-lc
+ gitref: v1.70.0
+ libconfigure: cmake -B build -GNinja -DCMAKE_BUILD_T= YPE=3DRelease -DCMAKE_INSTALL_PREFIX=3D"$LIBPREFIX" -DBUILD_SHARE= D_LIBS=3D1
+ lib= make: cmake --build build
+ libinstall: sudo cmake --install build
+ # not ready for --enable-werror=
+ ovpnconfigureflags:<= /span>
diff --git a/.github/workflows/test-ssllib.yml b/.github/wo= rkflows/test-ssllib.yml
new file mode 100644
index 0000000..c6a2e44

--- /dev/null
+++ = b/.github/workflows/test-ssllib.yml
@@ -0,0 +1,117 @@
+name: test_ssllib<= br>+
+on:
+ workflow_call:
+ inputs:
+ libname:
+ = required: true
+= type: string
= + ovpnlibname:
+= type: string
= + default: openssl
+ ovpnlibdesc:
+ required: true
+ type: string
+ ghrepo:
+ type: string
+ gitref:
= + required: true
+ type: string
+ libconfigure:
+ required: true
+ type: string
+ libmake:
+ type: string
+ default: "make -j3"
+ libinstall:
+ type: string
+ default: "sudo make install"=
+ ovpnconfigureenv:
+ type: string
+ default: >= -
+ OPENSSL_= CFLAGS=3D"-I$LIBPREFIX/include"
+ OPENSSL_LIBS=3D"-L$LIBPREFIX/lib -lssl= -lcrypto"
+ = LDFLAGS=3D"-Wl,-rpath=3D$LIBPREFIX/lib"
+ ovpnconfigureflags:
+ type: string

+ default: --enable-werror= --with-openssl-engine=3Dno

+
+jobs:
+ test_ssllib:
= + strategy:
+ fail-fast: false
+ matrix:

+ os: [ubuntu-24.04]
+ build: [normal, asan]
+ include:
+ - build: asan
+ cflags: &= quot;-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fno-optimize-siblin= g-calls -fsanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1&q= uot;
+ ldf= lags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall
+ cc: clang
+ cxx: clang++
+ - build: normal
<= br>+ cflags: "-= O2 -g"
+ = ldflags: ""
+ cc: gcc
+ cxx: g++
+
+ name: &q= uot;${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{inputs.libname}}= "
+ runs-on: = ${{matrix.os}}
+ e= nv:
+ CFLAGS: ${= {matrix.cflags}}
+ = LDFLAGS: ${{matrix.ldflags}}
+ CC: ${{matrix.cc}}
+ CXX: ${{matrix.cxx}}
+ UBSAN_OPTIONS: print_stacktrace=3D1+ LIBPREFIX: /opt/${{inpu= ts.libname}}
+=
+ steps:
+ - name: Install dependencies<= /span>
+ run: sudo ap= t update && sudo apt install -y liblzo2-dev libpam0g-dev liblz4-dev= linux-libc-dev man2html clang libcmocka-dev python3-docutils libtool autom= ake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev
+ - name: Restore ${{inputs.libname}= } from cache
+ = uses: actions/cache@...3024... # v5.0.5
+ id: ssllib-cache
+ with:
+ path: ${{env.LIBPREFIX}}
+ key: ${{matrix.os}}-${{inputs.= libname}}-${{matrix.build }}-${{inputs.gitref}}
+ - name: "${{inputs.libname}}: checko= ut"
+ if:= steps.ssllib-cache.outputs.cache-hit !=3D 'true'
+ uses: actions/checkout@...3007...= 8... # v6.0.2
+ = with:
+ su= bmodules: recursive
+= path: ${{inputs.libname}}
+ repository: ${{inputs.ghrepo}}
+ ref: ${{inputs.gitref}}
+ - name: "${{i= nputs.libname}}: configure"
+ if: steps.ssllib-cache.outputs.cache-hit !=3D 'tru= e'
+ run: = ${{inputs.libconfigure}}
+ working-directory: ${{inputs.libname}}
+ - name: "${{inputs.libname}}: = build"
+ = if: steps.ssllib-cache.outputs.cache-hit !=3D 'true'
+ run: ${{inputs.libmake}}
+ working-direc= tory: ${{inputs.libname}}
+ - name: "${{inputs.libname}}: install"
+ if: steps.ssllib-cache.out= puts.cache-hit !=3D 'true'

+ run: ${{inputs.libinstall}}
+ working-directory: ${{inputs.libname= }}
+ - name: Run= ldconfig
+ ru= n: sudo ldconfig
+ = - name: "OpenVPN: checkout"
+ uses: actions/checkout@...2998... # v6.0.2
+ - name: "Ope= nVPN: autoreconf"
+ - name: "OpenVPN: configure"
+ run: |
+ ${{inputs.ovpnconfigureenv}} \<= /span>
+ ./configur= e --with-crypto-library=3D${{inputs.ovpnlibname}} ${{inputs.ovpnconfigurefl= ags}}
+ - name: = "OpenVPN: build"
+ run: make -j3
+ - name: Ensure the build uses ${{inputs.libname}}
= + run: |
+ ./src/openvpn/openvpn --v= ersion

+ ./s= rc/openvpn/openvpn --version | grep -q "library versions: ${{inputs.ov= pnlibdesc}}"
+ = - name: "OpenVPN: configure checks"
+ run: echo 'RUN_SUDO=3D"sudo = -E"' >tests/t_server_null.rc
+ - name: "OpenVPN: make check"+ run: make -j3 check = VERBOSE=3D1
diff --git a/renovate.json b/renovate.json
index f9c62c4..809ac3f 100644
--- a/renovate.js= on
+++ b/renovate.json
@@ -40,7 +40,7 @@
"/^\\.github/workflows/.+\\.ya?ml$/&quo= t;
],
"match= Strings": [
- = "versioning=3D(?<versioning>.*?)\\n\\s*.*?_REPO:\\s*(= ?<depName>.*?)\\n\\s*.*?_VERSION:\\s*(?<currentValue>.*?)\\n&qu= ot;
+ = "versioning=3D(?<versioning>.*?)\\n\\s*ghrepo:\\s*(?<depName&= gt;.*?)\\n\\s*gitrepo:\\s*(?<currentValue>.*?)\\n"
],

"datasourceTemplate&qu= ot;: "github-tags"
}

To view, visit change 1630. To unsubscribe, or for help writin= g mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3d89016ccae297cfa596897c11a= 518f1ffbe3dc8
Gerrit-Change-Number: 1630
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: uddr <yura.uddr@...277...&= gt;
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --rSInf1T+uDg=--