Message-ID: <04dc1744-eace-8ee8-a888-b20d459fe60b@...2080...> Date: Mon, 27 Jun 2022 22:19:29 +0200 MIME-Version: 1.0 Content-Language: en-US References: <20220217182234.33850-1-arne@...1227...> From: David Sommerseth In-Reply-To: <20220217182234.33850-1-arne@...1227...> Subject: Re: [Openvpn-devel] [PATCH v3] Fix OpenVPN querying user/password if auth-token with user expires List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: openvpn-devel On 17/02/2022 19:22, Arne Schwabe wrote: > The problematic behaviour happens when start a profile without That sentence can be improved slightly; can be done commit time. I propose: The problematic behaviour happens when a profile is started without > auth-user-pass and connect to a server that pushes auth-token > When the auth token expires OpenVPN asks for auth User and password > again. > > The problem is that the auth_user_pass_setup sets > auth_user_pass_enabled = true; This function is called from two places. > In ssl.c it is only called with an auth-token present or that > variable already set. The other one is init_query_passwords. > > Move setting auth_user_pass_enabled to the second place to ensure it is > only set if we really want passwords. > > Patch v2: Remove unrelated code change > Patch v3: Rebase to master > > Signed-off-by: Arne Schwabe -- kind regards, David Sommerseth OpenVPN Inc