From: Oscar Mateo Subject: Re: [PATCH] drm/i915/cnl: Avoid WA_SET_BIT_MASK on write-only CNL_HDC_CHICKEN0. Date: Wed, 27 Sep 2017 15:12:43 -0700 Message-ID: <04ed4b96-b3b2-3153-bd5f-3064f670ff9c@intel.com> References: <20170927210134.20164-1-rodrigo.vivi@intel.com> <2c368097-6adc-03e8-747f-4f96cdb7f3b7@intel.com> <20170927211701.646jnxswhojl2rxx@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BCA989C2A for ; Wed, 27 Sep 2017 22:12:36 +0000 (UTC) In-Reply-To: <20170927211701.646jnxswhojl2rxx@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAwOS8yNy8yMDE3IDAyOjE3IFBNLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4gT24gV2VkLCBT ZXAgMjcsIDIwMTcgYXQgMDk6MDg6MTBQTSArMDAwMCwgT3NjYXIgTWF0ZW8gd3JvdGU6Cj4+Cj4+ IE9uIDA5LzI3LzIwMTcgMDI6MDEgUE0sIFJvZHJpZ28gVml2aSB3cm90ZToKPj4+IE9uIENOTCwg SERDX0NISUNLRU4wICJpcyB3cml0ZS1vbmx5IGZyb20gTFJJIGNvbW1hbmQuCj4+PiBIb3dldmVy LCBpdCBpcyByZWFkYWJsZSBmb3IgY29udGV4dCBzYXZlLiIKPj4+Cj4+PiBTbyB3ZSBoYXZlIG5v IHdheXMgdG8gY2hlY2sgdGhlIGNvaGVyZW5jeSBieSByZWFkaW5nIGl0IGJhY2sgb24KPj4+IG91 ciB0ZXN0cy4KPj4+Cj4+PiBTbyBsZXQncyBqdXN0IHdyaXRlIHRoYXQgYml0IGRpcmVjdGx5IHdp dGhvdXQgc2F2aW5nIGl0IHRvCj4+PiBkZXZfcHJpdi0+d29ya2Fyb3VuZHMuCj4+IFdhaXQsIGl0 J3Mgbm90IHRoYXQgc2ltcGxlOiBDTkxfSERDX0NISUNLRU4wIGxpdmVzIGluIHRoZSBjb250ZXh0 IGltYWdlLCBzbwo+PiB5b3UgYXJlIGdvaW5nIHRvIHJldmVydCB0aGUgdmFsdWUgYXMgc29vbiBh cyB5b3UgcmVzdG9yZSB0aGUgbmV4dCBjb250ZXh0Cj4+ICh5b3Ugd2FudCB0byBzYXZlIGl0IGlu IGRldl9wcml2LT53b3JrYXJvdW5kcyBzbyB0aGF0Cj4+IGludGVsX3Jpbmdfd29ya2Fyb3VuZHNf ZW1pdCBhcHBsaWVzIGl0IHRvIGV2ZXJ5IG5ld2x5IGNyZWF0ZWQgY29udGV4dCkuCj4gaG0uLi4g dGhhdCBtYWtlcyBzZW5zZS4uLgo+Cj4gSSB3YXMgb25seSB3aXRoIHRoZSBXQSBkZXNjcmlwdGlv biBpbiBteSBoZWFkIHRoYXQgc3RhdGVzIHRvIHNldCBvbmx5IG9uY2UgYXQgYm9vdDoKPgo+ICIg VG8gYXZvaWQgYSBwb3RlbnRpYWwgaGFuZyBjb25kaXRpb24gd2l0aCBUTEIgaW52YWxpZGF0aW9u Cj4gZHJpdmVyIHNob3VsZCBlbmFibGUgbWFza2VkIGJpdCA1IG9mIE1NSU8gMHhFNUYwIGF0IGJv b3QuIgo+Cj4gQnV0IGFwcGFyZW50bHkganVzdCBhIGJhZCBkZXNjcmlwdGlvbiBpbiBzcGVjLCBy aWdodD8hCj4KPiBJZiB0aGlzIGlzIHRoZSBjYXNlIHByb2JhYmx5IGRldl9wcml2LT53b3JrYXJv dWRzIHdpbGwgbmVlZCBhbm90aGVyIGNvbXBvbmVudAo+ICJwZXJtaXNzaW9uIiB0byBoYW5kbGUg d3JpdGUtb25seSByZWdpc3RlcnMgYW5kIGF2b2lkIHJlYWRpbmcgdGhhdCBvbiBkZWJ1Z2ZzPwo+ IE9yIGFueSB0aGluZyBzbWFydGVyPwo+CgpXZWxsLCB0byBiZWdpbiB3aXRoLCB0aGUgY3VycmVu dCBkZWJ1Z2ZzIGludGVyZmFjZSBkb2VzIG5vdCBtYWtlIGEgbG90IApvZiBzZW5zZSBmb3IgdGhp bmdzIHRoYXQgbGl2ZSBpbnNpZGUgdGhlIGNvbnRleHQgaW1hZ2UuIFRoYXQncyB3aHkgQ2hyaXMg CnNlbnQgdGhpcyBwYXRjaCBlYXJsaWVyOgoKImlndC9nZW1fd29ya2Fyb3VuZHM6IFJlYWQgdGhl IHdvcmthcm91bmQgcmVnaXN0ZXJzIGZyb20gdGhlIGFjdGl2ZSBjb250ZXh0IgoKQnV0IHRoaXMg ZGVwZW5kcyBvbiBMUkkgY29tbWFuZHMgYW5kIHRodXMgbWFrZXMgaXQgaW1wb3NzaWJsZSB0byB3 b3JrIAp3aXRoIHRoaXMgcGFydGljdWxhciByZWdpc3RlciA6LwoKTWF5YmUgY3JlYXRlIGEgY29u dGV4dCwgZm9yY2UgdGhlIEhXIHRvIHN3aXRjaCBpbiAmIG91dCBvZiBpdCBhbmQgdGhlbiBhIApk ZWJ1Z2ZzIGludGVyZmFjZSB0byByZWFkIHRoZSBXQXMgZnJvbSBpbnNpZGUgdGhlIGNvbnRleHQg aW1hZ2U/IEFub3RoZXIgCnBvc3NpYmlsaXR5OiBpbiBDTkwrLCB0aGUgZ29vZCBvbGQgTUlfU0VU X0NPTlRFWFQgY29tbWFuZCBpcyBiYWNrLCBzbyAKbWF5YmUgaXQgY2FuIGJlIHVzZWQgaW1hZ2lu YXRpdmVseSB0byByZXRyaWV2ZSB0aGUgY29udGV4dCBpbWFnZSA6KQoKSW4gYW55IGNhc2UsIHRo aXMgbG9va3MgbGlrZSBhIGxvdCBvZiB3b3JrIG9ubHkgdG8gZGVidWcgdGhhdCBvbmUgV0EgaXMg CmFwcGxpZWQgY29ycmVjdGx5Li4uCgo+Pj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVz a3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMjk0Mwo+Pj4gRml4ZXM6IGFjZmI1NTU0Yzc2OSAo ImRybS9pOTE1L2NubDogV2FGb3JjZUNvbnRleHRTYXZlUmVzdG9yZU5vbkNvaGVyZW50IikKPj4+ IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPj4+IENj OiBPc2NhciBNYXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29tPgo+Pj4gQ2M6IENocmlzIFdpbHNv biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+Pj4gU2lnbmVkLW9mZi1ieTogUm9kcmlnbyBW aXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+Pj4gLS0tCj4+PiAgICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyB8IDQgKystLQo+Pj4gICAgMSBmaWxlIGNoYW5nZWQs IDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9lbmdpbmVfY3MuYwo+Pj4gaW5kZXggYTI4ZTJhODY0Y2YxLi4wNDdiYTBhMDMwOGQg MTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYwo+ Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPj4+IEBAIC0x MjUxLDggKzEyNTEsOCBAQCBzdGF0aWMgaW50IGNubF9pbml0X3dvcmthcm91bmRzKHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4+ICAgIAkJCSAgICBHQU1UX0NIS05fRElTQUJMRV9J Mk1fQ1lDTEVfT05fV1JfUE9SVCkpOwo+Pj4gICAgCS8qIFdhRm9yY2VDb250ZXh0U2F2ZVJlc3Rv cmVOb25Db2hlcmVudDpjbmwgKi8KPj4+IC0JV0FfU0VUX0JJVF9NQVNLRUQoQ05MX0hEQ19DSElD S0VOMCwKPj4+IC0JCQkgIEhEQ19GT1JDRV9DT05URVhUX1NBVkVfUkVTVE9SRV9OT05fQ09IRVJF TlQpOwo+Pj4gKwlJOTE1X1dSSVRFKENOTF9IRENfQ0hJQ0tFTjAsCj4+PiArCQkgICBfTUFTS0VE X0JJVF9FTkFCTEUoSERDX0ZPUkNFX0NPTlRFWFRfU0FWRV9SRVNUT1JFX05PTl9DT0hFUkVOVCkp Owo+Pj4gICAgCS8qIFdhVGhyb3R0bGVFVVBlcmZUb0F2b2lkVERCYWNrUHJlc3N1cmU6Y25sKHBy ZS1wcm9kKSAqLwo+Pj4gICAgCWlmIChJU19DTkxfUkVWSUQoZGV2X3ByaXYsIENOTF9SRVZJRF9C MCwgQ05MX1JFVklEX0IwKSkKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lu dGVsLWdmeAo=