From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915: s/cacheing/caching/ Date: Tue, 25 Sep 2012 10:43:55 +0100 Message-ID: <051c15$4ds0tq@AZSMGA002.ch.intel.com> References: <1348272081-5357-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 39397A09CF for ; Tue, 25 Sep 2012 02:44:03 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Ben Widawsky Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, 25 Sep 2012 10:32:17 +0200, Daniel Vetter wrote: > On Sat, Sep 22, 2012 at 2:01 AM, Ben Widawsky wrote: > > From: Ben Widawsky > > > > Signed-off-by: Ben Widawsky > > IIrc we're already including this header in shipping libdrm, and we > have already users for it ... Have you checked whether this doesn't > break anything once copied over to libdrm? Maybe we just need a few > #defines for the old names ... It doesn't affect the ddx since it is still using its own prototype, and there has yet to be a patch for Mesa to use this knowledge. -Chris -- Chris Wilson, Intel Open Source Technology Centre