Return-path: Received: from mga02.intel.com ([134.134.136.20]:63848 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754326AbcI1Vuz (ORCPT ); Wed, 28 Sep 2016 17:50:55 -0400 Subject: Re: [PATCH -next] watchdog: wdat_wdt: fix return value check in wdat_wdt_probe() To: Mika Westerberg , Wei Yongjun References: <1475074286-13834-1-git-send-email-weiyj.lk@gmail.com> <20160928145906.GD1218@lahna.fi.intel.com> Cc: Wim Van Sebroeck , Guenter Roeck , Wei Yongjun , linux-watchdog@vger.kernel.org From: "Rafael J. Wysocki" Message-ID: <05841e35-ac1d-eaba-12cf-c813dac1f9e7@intel.com> Date: Wed, 28 Sep 2016 23:50:49 +0200 MIME-Version: 1.0 In-Reply-To: <20160928145906.GD1218@lahna.fi.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org On 9/28/2016 4:59 PM, Mika Westerberg wrote: > On Wed, Sep 28, 2016 at 02:51:26PM +0000, Wei Yongjun wrote: >> From: Wei Yongjun >> >> In case of error, the function devm_ioremap_resource() returns ERR_PTR() >> and never returns NULL. The NULL test in the return value check should >> be replaced with IS_ERR(). >> >> Signed-off-by: Wei Yongjun > Acked-by: Mika Westerberg Applied (with tags). Thanks, Rafael