From: "cron2 (Code Review)" Date: Fri, 31 Jan 2025 09:40:58 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., a@...2181... Message-ID: <058ce77a2dbc01253013b526275d0273bc7c43d3-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Si66C6uHu4Y="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: get_default_gateway(): implement platform support for Linux/SITNL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --Si66C6uHu4Y= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello flichtenheld, ordex, plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=3Demail to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by ordex Change subject: get_default_gateway(): implement platform support for Linux= /SITNL ...................................................................... get_default_gateway(): implement platform support for Linux/SITNL This adds Linux/SITNL platform functionality to the framework started by commit 9df51cf56 and commit 0fcfc8381f. v2: make comment reflect reality Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c Signed-off-by: Gert Doering Acked-by: Antonio Quartulli Message-Id: <20250131084651.24765-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30= 749.html Signed-off-by: Gert Doering --- M src/openvpn/route.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/83/883/3 diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 3501e35..dd37fb9 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -3332,8 +3332,8 @@ CLEAR(*rgi); CLEAR(best_name); - /* get default gateway IP addr */ - if (net_route_v4_best_gw(ctx, NULL, &rgi->gateway.addr, best_name) =3D= =3D 0) + /* find best route to 'dest', get gateway IP addr + interface */ + if (net_route_v4_best_gw(ctx, &dest, &rgi->gateway.addr, best_name) = =3D=3D 0) { rgi->flags |=3D RGI_ADDR_DEFINED; if (!rgi->gateway.addr && best_name[0]) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c Gerrit-Change-Number: 883 Gerrit-PatchSet: 3 Gerrit-Owner: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: newpatchset --Si66C6uHu4Y= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 uploaded patch set #3 to this change.

View Change

The following approvals got outdated and were removed: Code-Review+2 by ordex

get_default_gateway(): implement platform support fo=
r Linux/SITNL

This adds Linux/SITNL platform functionality to the fr= amework started by
commit 9df51cf56 and commit 0fcfc8381f.

v2: ma= ke comment reflect reality

Change-Id: I1db72d7dca648a8ea4ec65d173290= a819971305c
Signed-off-by: Gert Doering <gert@...1296...>
Acked= -by: Antonio Quartulli <a@...2181...>
Message-Id: <202501310846= 51.24765-1-gert@...1296...>
URL: https://www.mail-archive.com/openvpn= -devel@lists.sourceforge.net/msg30749.html
Signed-off-by: Gert Doering &= lt;gert@...1296...>
---
M src/openvpn/route.c
1 file changed, 2= insertions(+), 2 deletions(-)

git pull ssh://gerrit.openvpn.net:=
29418/openvpn refs/changes/83/883/3
diff --git a/src/openvpn/route.=
c b/src/openvpn/route.c
index 3501e35..dd37fb9 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/rout= e.c
@@ -3332,8 +3332,8 @@
CLEAR(*rgi);=
CLEAR(best_name);

- /* get default gateway IP addr */
- if (net_route_v4_be= st_gw(ctx, NULL, &rgi->gateway.addr, best_name) =3D=3D 0)
= + /* find best route to '= ;dest', get gateway IP addr + interface */
+ if (net_route_v4_best_gw(ctx, &dest, &am= p;rgi->gateway.addr, best_name) =3D=3D 0)
{<= br> rgi->flags |=3D RGI_ADDR_DEFINED;
= if (!rgi->gateway.addr && best_name[0])

To view, visit change 883. To unsubscribe, or for help writing = mail filters, visit settings= .

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d1732= 90a819971305c
Gerrit-Change-Number: 883
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: ordex <a@...2181...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: newpatchset
--Si66C6uHu4Y=--