From: "cron2 (Code Review)" Date: Fri, 31 Jan 2025 09:41:02 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., a@...2181... Message-ID: <058ce77a2dbc01253013b526275d0273bc7c43d3-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="PCmekiQ2rE4="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: get_default_gateway(): implement platform support for Linux/SITNL List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: plaisthos , flichtenheld , openvpn-devel --PCmekiQ2rE4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/88= 3?usp=3Demail ) Change subject: get_default_gateway(): implement platform support for Linux= /SITNL ...................................................................... get_default_gateway(): implement platform support for Linux/SITNL This adds Linux/SITNL platform functionality to the framework started by commit 9df51cf56 and commit 0fcfc8381f. v2: make comment reflect reality Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c Signed-off-by: Gert Doering Acked-by: Antonio Quartulli Message-Id: <20250131084651.24765-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg30= 749.html Signed-off-by: Gert Doering --- M src/openvpn/route.c 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/openvpn/route.c b/src/openvpn/route.c index 3501e35..dd37fb9 100644 --- a/src/openvpn/route.c +++ b/src/openvpn/route.c @@ -3332,8 +3332,8 @@ CLEAR(*rgi); CLEAR(best_name); - /* get default gateway IP addr */ - if (net_route_v4_best_gw(ctx, NULL, &rgi->gateway.addr, best_name) =3D= =3D 0) + /* find best route to 'dest', get gateway IP addr + interface */ + if (net_route_v4_best_gw(ctx, &dest, &rgi->gateway.addr, best_name) = =3D=3D 0) { rgi->flags |=3D RGI_ADDR_DEFINED; if (!rgi->gateway.addr && best_name[0]) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c Gerrit-Change-Number: 883 Gerrit-PatchSet: 3 Gerrit-Owner: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --PCmekiQ2rE4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

get_default_gateway(): implement platform supp=
ort for Linux/SITNL

This adds Linux/SITNL platform functionality to = the framework started by
commit 9df51cf56 and commit 0fcfc8381f.

= v2: make comment reflect reality

Change-Id: I1db72d7dca648a8ea4ec65d= 173290a819971305c
Signed-off-by: Gert Doering <gert@...1296...>Acked-by: Antonio Quartulli <a@...2181...>
Message-Id: <202501= 31084651.24765-1-gert@...1296...>
URL: https://www.mail-archive.com/o= penvpn-devel@lists.sourceforge.net/msg30749.html
Signed-off-by: Gert Doe= ring <gert@...1296...>
---
M src/openvpn/route.c
1 file chan= ged, 2 insertions(+), 2 deletions(-)

diff --git a/src/openvpn/route.c b/src/openvpn/route.c
i= ndex 3501e35..dd37fb9 100644
--- a/src/openvpn/route.c
+++ b/src/openvpn/route.c
@@ -3332,8 +3332,8 @@=
CLEAR(*rgi);
CLEAR(best_name);

- /= * get default gateway IP addr */
- if (net_route_v4_best_gw(ctx, NULL, &rgi->gateway.add= r, best_name) =3D=3D 0)
+ /* find best route to 'dest', get gateway IP addr + interfa= ce */
+ if (net_ro= ute_v4_best_gw(ctx, &dest, &rgi->gateway.addr, best_name) =3D=3D= 0)
{
rgi->flags |=3D RGI_= ADDR_DEFINED;
if (!rgi->gateway.addr &&= best_name[0])

To view, visit change 883. = To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d1732= 90a819971305c
Gerrit-Change-Number: 883
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <gert@...1296...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: ordex <a@...2181...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--PCmekiQ2rE4=--