Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1jPPRv-0006SX-3d for mharc-grub-devel@gnu.org; Fri, 17 Apr 2020 07:46:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49420) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jPPRs-0006Q4-Nq for grub-devel@gnu.org; Fri, 17 Apr 2020 07:46:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jPPRr-0001Rz-J4 for grub-devel@gnu.org; Fri, 17 Apr 2020 07:46:20 -0400 Received: from mga09.intel.com ([134.134.136.24]:15348) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jPPRr-0001Lc-AA for grub-devel@gnu.org; Fri, 17 Apr 2020 07:46:19 -0400 IronPort-SDR: rtiEfTAL6kriywh9wk/ZYMz4RaXNA90OpxNU1dtNm+jMr3rBxtkHUh9Bqdlq07pcAHZcw0u98b pvK9NbVwDujQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 04:46:11 -0700 IronPort-SDR: fBXUwe1HihczXfxZTj47JuBqaofJrVI2sM5VyCpsPtkKKSxRHsa1lfSUwdGAL9ti28WwFwZcqQ olEcSUotTvuw== X-IronPort-AV: E=Sophos;i="5.72,394,1580803200"; d="scan'208";a="401006764" Received: from lhawrylk-desk.ger.corp.intel.com ([10.213.1.9]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 04:46:10 -0700 Message-ID: <05b52d8990d4f78a8e3886eff5389ebbed2f6aa7.camel@linux.intel.com> Subject: Re: [PATCH V3] multiboot2: Implement quirk-modules-after-kernel From: Lukasz Hawrylko To: "Chen, Zide" , The development of GNU GRUB Date: Fri, 17 Apr 2020 13:46:05 +0200 In-Reply-To: <636297D5EBADD745BF4BDD83AA58243931FE1FE6@ORSMSX102.amr.corp.intel.com> References: <20200407063051.149-1-zide.chen@intel.com> <439f213dde627977b351422c5afd4a4f4fd0f8a4.camel@linux.intel.com> <636297D5EBADD745BF4BDD83AA58243931FE1FE6@ORSMSX102.amr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 134.134.136.24 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2020 11:46:21 -0000 On Thu, 2020-04-16 at 21:18 +0000, Chen, Zide wrote: > > > > Hi Zide > > > > Above modification changes another behavior. Before your patch, lowest > > address for multiboot2 modules allocation was 0x0, now, when you removed > > #ifndef, it is set to 1MB even if quirk is not enabled. I think that it > > is worth to mention than in commit message. > > > > To be honest, I was going to submit patch that sets lowest_addr to > > 0x1000 by default, so from my perspective your 'undocumented' change is > > good, 1MB works for my project too. > > > > Thanks, > > Lukasz > > Hi Lukasz, > > I will abandon this patch for now and go to the path to add a new module relocatable tag. > If you want you can go ahead to submit your patch to set lowest_addr, which is > independent to my new approach. > > -Zide > Hi Zide Your new tag will work for me too, because I can set min address there. Thanks, Lukasz