From: "mrbff (Code Review)" Date: Wed, 23 Jul 2025 17:11:43 +0000 In-Reply-To: References: Reply-To: marco@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., lstipakov@...277..., gert@...1296... Message-ID: <05d0396b684c4c7f3ae6832e8adc4b668b76989c-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="TC+K/5reP9Y="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: PUSH_UPDATE: Added remove_option() and do_update(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stipa , plaisthos , flichtenheld , openvpn-devel --TC+K/5reP9Y= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld, plaisthos, stipa. mrbff has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/809?usp=3Demail ) Change subject: PUSH_UPDATE: Added remove_option() and do_update(). ...................................................................... Patch Set 22: (3 comments) File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/809/comment/1bf8ad22_b4ec599b : PS21, Line 2833: if (!is_update && !check_pull_client_ncp(c, found)) > does it make sense to suppress this check? It should never fail, and nev= er modify anything (as we p [=E2=80=A6] Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/809/comment/0b58e5d7_f3dccb6a : PS21, Line 5502: options_server_import(struct options *o, > please do not move them (as for 808). [=E2=80=A6] Done http://gerrit.openvpn.net/c/openvpn/+/809/comment/99a69d66_161a9554 : PS21, Line 3134: } > with the extra code, the comment before the function is no longer appropr= iate. [=E2=80=A6] actually i should remove it, in case of an update of the option `routes->fl= ags =3D 0`, so there is no need for this code. I think i forgot there from = the previous development where i updated the flags individually. Tnx for th= e catch. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/809?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I507180d7397b6959844a30908010132bc3411067 Gerrit-Change-Number: 809 Gerrit-PatchSet: 22 Gerrit-Owner: mrbff Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-Reviewer: stipa Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Attention: stipa Gerrit-Comment-Date: Wed, 23 Jul 2025 17:11:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --TC+K/5reP9Y= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld, plaisthos, s= tipa.

View C= hange

3 comments:

    =
  • File src/openvpn/init.c:

    • Patch Set #21, Line 2833:= if (!is_update &am= p;& !check_pull_client_ncp(c, found))

      does it mak= e sense to suppress this check? It should never fail, and never modify any= thing (as we p [=E2=80=A6]

      Done

  • File src/openvpn/options.c:

    • Patch Set #21, Line 5502: options_server_import(struct options *o,<= /p>

      please do not move them (as for 808). [=E2=80=A6]

      Done

    • Patch Set #21, Line 3134: }

      with the extra code, the comment= before the function is no longer appropriate. [=E2=80=A6]

      =

      actually i shoul= d remove it, in case of an update of the option `routes->flags =3D 0`, s= o there is no need for this code. I think i forgot there from the previous = development where i updated the flags individually. Tnx for the catch.

      <= /li>

To view, visit change 809. To unsubscribe, or for help wri= ting mail filters, visit set= tings.

=
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I507180d7397b6959844a3090801= 0132bc3411067
Gerrit-Change-Number: 809
Gerrit-PatchSet: 22
Gerrit-Owner: mrbff <marco@...2726...> <= /div>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-Reviewer: stipa <lstipakov@...277...= >
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: stipa <lstipakov@...1663...= .>
Gerrit-Comment-Date: Wed, 23 Jul 2025 17:11:43= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Gerrit-MessageType: comment
--TC+K/5reP9Y=--