From: Thor Thayer Subject: Re: [PATCH v2 3/3] i2c: drivers: Use generic definitions for bus frequencies Date: Thu, 5 Mar 2020 17:37:27 -0600 Message-ID: <05d2d6a3-8a78-314c-9bed-a9313761695c@linux.intel.com> References: <20200227122129.65516-1-andriy.shevchenko@linux.intel.com> <20200227122129.65516-3-andriy.shevchenko@linux.intel.com> Reply-To: thor.thayer@linux.intel.com Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: Received: from mga06.intel.com ([134.134.136.31]:11064 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbgCEXhX (ORCPT ); Thu, 5 Mar 2020 18:37:23 -0500 In-Reply-To: <20200227122129.65516-3-andriy.shevchenko@linux.intel.com> Content-Language: en-US Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Andy Shevchenko , Wolfram Sang , linux-i2c@vger.kernel.org Cc: Elie Morisse , Nehal Shah , Shyam Sundar S K , Brendan Higgins , Krzysztof Adamski , Florian Fainelli , Ray Jui , Scott Branden , Michal Simek , Mika Westerberg , Jarkko Nikula , Baruch Siach , Guenter Roeck , Kukjin Kim , Krzysztof Kozlowski , Dong Aisheng , Shawn Guo , Sascha Hauer , Oleksij Rempel Hi Andy, On 2/27/20 6:21 AM, Andy Shevchenko wrote: > Since we have generic definitions for bus frequencies, let's use them. > > Cc: Thor Thayer > Acked-by: Elie Morisse > Acked-by: Nehal Shah > Cc: Shyam Sundar S K > Reviewed-by: Brendan Higgins > Cc: Krzysztof Adamski > Cc: Florian Fainelli > Cc: Ray Jui > Acked-by: Scott Branden > Cc: Michal Simek > Reviewed-by: Mika Westerberg > Acked-by: Jarkko Nikula > Acked-by: Baruch Siach > Reviewed-by: Guenter Roeck > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Dong Aisheng > Cc: Shawn Guo > Cc: Sascha Hauer > Acked-by: Oleksij Rempel > Acked-by: Vladimir Zapolskiy > Cc: Matthias Brugger > Cc: Gregory CLEMENT > Reviewed-by: Linus Walleij > Cc: "Andreas Färber" > Reviewed-by: Manivannan Sadhasivam > Cc: Andy Gross > Cc: Bjorn Andersson > Reviewed-by: Chris Brandt > Cc: Heiko Stuebner > Cc: Barry Song > Cc: Orson Zhai > Reviewed-by: Baolin Wang > Cc: Chunyan Zhang > Cc: Pierre-Yves MORDRET > Cc: Maxime Coquelin > Cc: Alexandre Torgue > Cc: Patrice Chotard > Acked-by: Ard Biesheuvel > Cc: Laxman Dewangan > Cc: Dmitry Osipenko > Cc: Masahiro Yamada > --- > v2: > squash to one patch (Wolfram) > used MAX in the definition names (Wolfram) > dropped HZ_PER_* > added collected tags > > drivers/i2c/busses/i2c-altera.c | 6 ++-- > drivers/i2c/busses/i2c-amd-mp2-plat.c | 27 +++++++++------ > drivers/i2c/busses/i2c-aspeed.c | 2 +- > drivers/i2c/busses/i2c-axxia.c | 4 +-- > drivers/i2c/busses/i2c-bcm-iproc.c | 14 ++++---- > drivers/i2c/busses/i2c-bcm-kona.c | 8 ++--- > drivers/i2c/busses/i2c-cadence.c | 7 ++-- > drivers/i2c/busses/i2c-designware-platdrv.c | 37 ++++++++++++--------- > drivers/i2c/busses/i2c-digicolor.c | 3 +- > drivers/i2c/busses/i2c-diolan-u2c.c | 12 +++---- > drivers/i2c/busses/i2c-exynos5.c | 18 ++++------ > drivers/i2c/busses/i2c-hix5hd2.c | 10 +++--- > drivers/i2c/busses/i2c-img-scb.c | 4 +-- > drivers/i2c/busses/i2c-imx-lpi2c.c | 16 +++------ > drivers/i2c/busses/i2c-imx.c | 5 +-- > drivers/i2c/busses/i2c-lpc2k.c | 6 ++-- > drivers/i2c/busses/i2c-mt65xx.c | 21 +++++------- > drivers/i2c/busses/i2c-mv64xxx.c | 6 ++-- > drivers/i2c/busses/i2c-mxs.c | 4 +-- > drivers/i2c/busses/i2c-nomadik.c | 8 ++--- > drivers/i2c/busses/i2c-owl.c | 9 ++--- > drivers/i2c/busses/i2c-qup.c | 11 ++---- > drivers/i2c/busses/i2c-rcar.c | 2 +- > drivers/i2c/busses/i2c-riic.c | 6 ++-- > drivers/i2c/busses/i2c-rk3x.c | 12 +++---- > drivers/i2c/busses/i2c-s3c2410.c | 4 +-- > drivers/i2c/busses/i2c-sh_mobile.c | 9 ++--- > drivers/i2c/busses/i2c-sirf.c | 3 +- > drivers/i2c/busses/i2c-sprd.c | 9 ++--- > drivers/i2c/busses/i2c-st.c | 6 ++-- > drivers/i2c/busses/i2c-stm32f4.c | 6 ++-- > drivers/i2c/busses/i2c-stm32f7.c | 24 ++++++------- > drivers/i2c/busses/i2c-stu300.c | 6 ++-- > drivers/i2c/busses/i2c-synquacer.c | 6 ++-- > drivers/i2c/busses/i2c-tegra.c | 18 ++++------ > drivers/i2c/busses/i2c-uniphier-f.c | 6 ++-- > drivers/i2c/busses/i2c-uniphier.c | 7 ++-- > drivers/i2c/busses/i2c-xlp9xx.c | 8 ++--- > 38 files changed, 168 insertions(+), 202 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-altera.c b/drivers/i2c/busses/i2c-altera.c > index 1de23b4f3809..20ef63820c77 100644 > --- a/drivers/i2c/busses/i2c-altera.c > +++ b/drivers/i2c/busses/i2c-altera.c > @@ -147,7 +147,7 @@ static void altr_i2c_init(struct altr_i2c_dev *idev) > (ALTR_I2C_THRESHOLD << ALTR_I2C_CTRL_TCT_SHFT); > u32 t_high, t_low; > > - if (idev->bus_clk_rate <= 100000) { > + if (idev->bus_clk_rate <= I2C_MAX_STANDARD_MODE_FREQ) { > tmp &= ~ALTR_I2C_CTRL_BSPEED; > /* Standard mode SCL 50/50 */ > t_high = divisor * 1 / 2; > @@ -423,10 +423,10 @@ static int altr_i2c_probe(struct platform_device *pdev) > &idev->bus_clk_rate); > if (val) { > dev_err(&pdev->dev, "Default to 100kHz\n"); > - idev->bus_clk_rate = 100000; /* default clock rate */ > + idev->bus_clk_rate = I2C_MAX_STANDARD_MODE_FREQ; /* default clock rate */ > } > > - if (idev->bus_clk_rate > 400000) { > + if (idev->bus_clk_rate > I2C_MAX_FAST_MODE_FREQ) { > dev_err(&pdev->dev, "invalid clock-frequency %d\n", > idev->bus_clk_rate); > return -EINVAL; Reviewed-by: Thor Thayer Thanks