From: Clemens Ladisch Subject: Re: [PATCH] ALSA: usb-audio: Add quirk for Focusrite Scarlett 18i6 Date: Sat, 29 Dec 2012 13:38:39 +0100 Message-ID: <0618809b-1133-400a-bf57-430574b4c87e@email.android.com> References: <20121109202023.60f6dcdc@martins.ozlabs.org> <20121113193803.2e0d7c4a@martins.ozlabs.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by alsa0.perex.cz (Postfix) with ESMTP id 327FC261615 for ; Sat, 29 Dec 2012 13:38:53 +0100 (CET) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Grant Diffey , Takashi Iwai Cc: ALSA development , Martin Schwenke , Daniel Mack List-Id: alsa-devel@alsa-project.org Grant Diffey wrote: >Last week on #alsa I found yet another person who's having >problems with snd-usb-audio not supporting UAC2 Feature units. This is an extension unit. The driver not handling it is yet another bug. >Worse still the relevant part of the descriptor is incomplete according to >lsusb lsusb might be as error-free as snd-usb-audio, and in any case an incomplete descriptor for some random mixer control should be no reason to refuse working with the device altogether. >So while we could submit another quirk for this to ignore the mixer for >now. and this would probably make the device "work" without access to >the feature unit is it sensible? The sensible thing to do is to review the entire new descriptor parsing code to remove all invalid and overzealous error cases. Regards, Clemens