From: "flichtenheld (Code Review)"
Date: Tue, 12 Dec 2023 13:55:55 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net
Message-ID: <06213d8f9496219c16ae2b5f4d2e5c28c64f7fe8-EmailReplacePatchSet-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="V+k2DCHZN7k="; charset=UTF-8
Subject: [Openvpn-devel] [S] Change in openvpn[master]: test_user_pass: Add
UTs for character filtering
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--V+k2DCHZN7k=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
Hello plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/473?usp=3Demail
to look at the new patch set (#2).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied=
now.
Change subject: test_user_pass: Add UTs for character filtering
......................................................................
test_user_pass: Add UTs for character filtering
For simplicity I implemented them only with the
inline method, but they actually apply to all methods.
Change-Id: Ie8d2d5f6f58679baaf5eb817a7e2ca1afcb8c4db
Signed-off-by: Frank Lichtenheld
---
M tests/unit_tests/openvpn/test_user_pass.c
1 file changed, 23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/73/473/2
diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o=
penvpn/test_user_pass.c
index ab4dfe4..277cb1d 100644
--- a/tests/unit_tests/openvpn/test_user_pass.c
+++ b/tests/unit_tests/openvpn/test_user_pass.c
@@ -141,6 +141,29 @@
reset_user_pass(&up);
+ /* Test various valid characters */
+ /*FIXME: query_user_exec() called even though nothing queued */
+ will_return(query_user_exec_builtin, true);
+ /* FIXME? content after first two lines just ignored */
+ assert_true(get_user_pass_cr(&up, "#iuser and =EC=BB=A4=EB=AE=A4=EB=8B=
=88=ED=8B=B0\n//ipassw=C3=B6rd!\nsome other content\nnot relevant", "UT", f=
lags, NULL));
+ assert_true(up.defined);
+ assert_string_equal(up.username, "#iuser and =EC=BB=A4=EB=AE=A4=EB=8B=
=88=ED=8B=B0");
+ assert_string_equal(up.password, "//ipassw=C3=B6rd!");
+
+ reset_user_pass(&up);
+
+ /* Test various invalid characters */
+ /*FIXME: query_user_exec() called even though nothing queued */
+ will_return(query_user_exec_builtin, true);
+ /*FIXME? allows arbitrary crap if c > 127 */
+ /*FIXME? silently removes control characters */
+ assert_true(get_user_pass_cr(&up, "\tiuser\r\nipass\xffwo\x1erd", "UT"=
, flags, NULL));
+ assert_true(up.defined);
+ assert_string_equal(up.username, "iuser");
+ assert_string_equal(up.password, "ipass\xffword");
+
+ reset_user_pass(&up);
+
expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT=
Password:");
will_return(query_user_exec_builtin, "cpassword");
will_return(query_user_exec_builtin, true);
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/473?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie8d2d5f6f58679baaf5eb817a7e2ca1afcb8c4db
Gerrit-Change-Number: 473
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: flichtenheld
Gerrit-MessageType: newpatchset
--V+k2DCHZN7k=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld.
flichtenheld uploaded patch set #2 to this change.
<=
p>View Ch=
ange
The change is no longer submittable: checks~ChecksSubmitRule=
is unsatisfied now.
test_user_pass: Add UTs for character filtering
For simplicity I implemented them only with the
inline method, but they=
actually apply to all methods.
Change-Id: Ie8d2d5f6f58679baaf5eb817=
a7e2ca1afcb8c4db
Signed-off-by: Frank Lichtenheld <frank@...2641...&g=
t;
---
M tests/unit_tests/openvpn/test_user_pass.c
1 file changed,=
23 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.n=
et:29418/openvpn refs/changes/73/473/2
diff --git a/tests/unit_test=
s/openvpn/test_user_pass.c b/tests/unit_tests/openvpn/test_user_pass.c
index ab4dfe4..277cb1d 100644
--- a/tests/unit_=
tests/openvpn/test_user_pass.c
+++ b/tests/unit_tests/openv=
pn/test_user_pass.c
@@ -141,6 +141,29 @@
<=
/span>
reset_user_pass(&up);
=
+ /* Test various valid char=
acters */
+ /*FIXM=
E: query_user_exec() called even though nothing queued */
+ will_return(query_user_exec_built=
in, true);
+ /* FI=
XME? content after first two lines just ignored */
+ assert_true(get_user_pass_cr(&up, &q=
uot;#iuser and =EC=BB=A4=EB=AE=A4=EB=8B=88=ED=8B=B0\n//ipassw=C3=B6rd!\nsom=
e other content\nnot relevant", "UT", flags, NULL));<=
br>+ assert_true(up.defined)=
;
+ assert_string_=
equal(up.username, "#iuser and =EC=BB=A4=EB=AE=A4=EB=8B=88=ED=8B=B0&qu=
ot;);
+ assert_str=
ing_equal(up.password, "//ipassw=C3=B6rd!");
+
+ reset_user_pass(&up);
+
+ /* Test various invalid characters */
+ /*FIXME: query_user_exec() called even tho=
ugh nothing queued */
+ will_return(query_user_exec_builtin, true);
+ /*FIXME? allows arbitrary crap if c > =
127 */
+ /*FIXME? =
silently removes control characters */
+ assert_true(get_user_pass_cr(&up, "\tiuser\=
r\nipass\xffwo\x1erd", "UT", flags, NULL));
+ assert_true(up.defined);<=
br>+ assert_string_equal(up.=
username, "iuser");
+ assert_string_equal(up.password, "ipass\xffword");<=
/span>
+
+ reset_user_pass(&up);
+
expect_=
string(query_user_exec_builtin, query_user[i].prompt, "Enter UT Passwo=
rd:");
will_return(query_user_exec_builtin, "=
;cpassword");
will_return(query_user_exec_builtin=
, true);
To view, visit change 473. To unsub=
scribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie8d2d5f6f58679baaf5eb817a7e=
2ca1afcb8c4db
Gerrit-Change-Number: 473
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...=
.>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-MessageType: newpatchset
--V+k2DCHZN7k=--