Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76970C433F5 for ; Thu, 19 May 2022 12:48:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 51C7583C01; Thu, 19 May 2022 14:48:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1652964494; bh=gH3RTIj83xw1MgnzesO/G1yXATcQJhBAnwgREgGVfR4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=O1vrUeP6R3gthQBvo0WgNVkCiw+lgkFjTGkVeXer/vb6VVd2KZAHO7WCbq4Ew5/Im WMWClmjryM/A8W2+TF1RHbv0A0Ih4+OSRUcKCGnS+8x7CBvZDAHvKuaxTA3x4SPdaX sJV9rS15GQc9GkkitjM/x2HRIwWWc+B/Q8HHgCpym0ujq5P37qngbNdQcZX12hVH6B YmC/v21YuQytJNmXosXHaCElghUIB8eF1gBuB5O9NrE7IokjawkPVOVEvzd/tXWvgF maKFNdOpYaEE7KpsCCoBxrdJ0jJSfOOs1kdtP/zoAfO0FYXN15+ZSDfHaLVWNIASxV J22VNOxamswhw== Received: from mail.denx.de (unknown [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: festevam@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 900B2811A6; Thu, 19 May 2022 14:48:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1652964491; bh=gH3RTIj83xw1MgnzesO/G1yXATcQJhBAnwgREgGVfR4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iDxNf6WiE3+sWZxtSDC7Y3DiaUhpxdX8/H50xbCzxJYBKuMZFfM10wTNmmOvSrov3 Db2HuPXaNyG8Eviz5cl+/kCaMlashLAQu8d7yFMnLacBM/IMe3hObrmQNd6v/RYwBp jb/t8vuJj8JJzpjAn52XmPP3GGE54+Lacu9+dYh5XZJ2q/mUSXmP3c/g8Pygv7hAlZ +gJDrBrRLZo3xdREQrPh1zTUqDaRmTaosumuOkSvXWpN0wKs684aCj9iHYTps1LtxZ /OWwuCzAsVd285olp/tFTT9b+7aEDZaRoPUy00ayk1iKJpCILzx1e4zq4ZO35Yk/qQ O0BQemCsQKLNQ== MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 19 May 2022 09:48:11 -0300 From: Fabio Estevam To: Philip Oberfichtner Cc: u-boot@lists.denx.de, Christoph Niedermaier , Stefano Babic , Peng Fan , Andreas Geisreiter , Tom Rini , u-boot@dh-electronics.com Subject: Re: [PATCH 8/8] ARM: imx6: Adapt device tree selection in DH board file In-Reply-To: <20220519110837.245488-9-pro@denx.de> References: <20220519110837.245488-1-pro@denx.de> <20220519110837.245488-9-pro@denx.de> Message-ID: <064f55c763ae1056c70d6c6f044d730e@denx.de> X-Sender: festevam@denx.de User-Agent: Roundcube Webmail/1.3.6 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 19/05/2022 08:08, Philip Oberfichtner wrote: return 0; > - } > + /* Determine carrier board at compile time and SoM at runtime */ > + const size_t size = 32; > + char *car, *som, dt[size]; > + > + car = strchr(CONFIG_DEFAULT_DEVICE_TREE, '-'); /* i.e. -dhcom-drc02 > */ > + > + som = is_mx6dq() ? "imx6q" : > + is_mx6dl() ? "imx6dl" : > + is_mx6solo() ? "imx6s" : NULL; > + > + if (!(car && som)) > + return -1; Nit: can you return -EINVAL instead of -1?