From: "flichtenheld (Code Review)" Date: Thu, 13 Jun 2024 07:57:26 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., samuli@...515..., openvpn-devel@lists.sourceforge.net Message-ID: <06709e04c368447009a6def4ad04b93f8c8fd504-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="sancmBqNptI="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: Add t_server_null test suite List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mattock Cc: plaisthos , openvpn-devel --sancmBqNptI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/663?usp=3Demail ) Change subject: Add t_server_null test suite ...................................................................... Patch Set 2: Code-Review+2 (2 comments) File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/663/comment/995176b3_cae59746 : PS1, Line 1: #!/usr/bin/env bash > bash is not necessarily available on BSD. Done http://gerrit.openvpn.net/c/openvpn/+/663/comment/0e0d21a2_a852e248 : PS1, Line 74: # Wait until servers are up. This check is based on the prese= nce of processes > This check does not work correctly. You often see something like this in = the output of the test: [=E2=80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/663?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1b54da258c7d15551b6c3de7522a0d19afdb66de Gerrit-Change-Number: 663 Gerrit-PatchSet: 2 Gerrit-Owner: mattock Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: mattock Gerrit-Comment-Date: Thu, 13 Jun 2024 07:57:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --sancmBqNptI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: mattock, plaisthos.

Patch set 2:Code-Review +2=

Vi= ew Change

2 comments:

  • File tests/t_server_null_client= .sh:

    • Patch Set #1, = Line 1: #!/usr/bin/env = bash

      bash is not necessarily available on BSD.

      Done

    • Patch Set #1, Line 74: # Wait until servers are up. This check is based on the pre= sence of processes

      This check does not work correctly= . You often see something like this in the output of the test: [=E2=80=A6]<= /blockquote>

      = Done

To view, visit change 663. To unsubscribe, or for= help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1b54da258c7d15551b6c3de7522= a0d19afdb66de
Gerrit-Change-Number: 663
Gerrit-PatchSet: 2
Gerrit-Owner: mattock <samuli@...515...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: mattock <samuli@...515...= >
Gerrit-Comment-Date: Thu, 13 Jun 2024 07:57:26= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--sancmBqNptI=--