From: "flichtenheld (Code Review)" Date: Tue, 12 Mar 2024 12:38:35 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net Message-ID: <0740e67a021632e9fcfb0c27f9119629b31a8034-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="8wmSQM1dzYQ="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , openvpn-devel --8wmSQM1dzYQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/523?usp=3Demail ) Change subject: Http-proxy: fix bug preventing proxy credentials caching ...................................................................... Patch Set 6: (1 comment) File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/a8be4b5f_3cc2fa9a : PS6, Line 304: else if (static_proxy_user_pass.nocache && !force) > I think we need it otherwise in case of nocache true creds would be wiped= at the first call of the g [=E2=80=A6] You're right about the force. I didn't really think about the fact that whe= n you don't use "auto" get_user_pass_http is going to be always called twic= e. But that also invalidates my other suggestion about the "else". The test= for force is not enough since on restart force will be false for the first= call. And it that case we should not clear it. I think we should go back t= o the previous iteration in this case. Move it out of the function again af= ter the second get_user_pass_http. We really only want to delete it there a= fter all. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 6 Gerrit-Owner: its_Giaan Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Comment-Date: Tue, 12 Mar 2024 12:38:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: its_Giaan Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --8wmSQM1dzYQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: its_Giaan, plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/proxy.c:

    • Patch Set #6, Line 304: <= code style=3D"font-family:monospace,monospace"> else if (static_proxy_us= er_pass.nocache && !force)

      I think we need it= otherwise in case of nocache true creds would be wiped at the first call o= f the g [=E2=80=A6]

      You're right about the force. I didn't really t= hink about the fact that when you don't use "auto" get_user_p= ass_http is going to be always called twice. But that also invalidates my o= ther suggestion about the "else". The test for force is not enoug= h since on restart force will be false for the first call. And it that case= we should not clear it. I think we should go back to the previous iteratio= n in this case. Move it out of the function again after the second get_user= _pass_http. We really only want to delete it there after all.

    =

To view, visit change 523. To unsubscribe, or for help writing mail= filters, visit settings= .

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279= fb71c01a1a78a
Gerrit-Change-Number: 523
Gerrit-PatchSet: 6
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Comment-Date: Tue, 12 Mar 2024 12:38:35= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: its_Giaan <gianmarco@...220...= ..2726...>
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--8wmSQM1dzYQ=--