Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009D8C2D0DB for ; Tue, 28 Jan 2020 16:27:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE88020CC7 for ; Tue, 28 Jan 2020 16:27:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AggQ8HA8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE88020CC7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwTi5-0005yN-Tm for qemu-devel@archiver.kernel.org; Tue, 28 Jan 2020 11:27:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53454) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwTh9-00053k-6S for qemu-devel@nongnu.org; Tue, 28 Jan 2020 11:26:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwTh7-0000TW-Ha for qemu-devel@nongnu.org; Tue, 28 Jan 2020 11:26:30 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:55213 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iwTh7-0000SE-Bl for qemu-devel@nongnu.org; Tue, 28 Jan 2020 11:26:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580228788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EadSVipwQyUKzAO8SdueQSxClet7y11i6mVil73ghvA=; b=AggQ8HA8VnFwiaBshHciCp85fwzF31tRxwlXbREREImCIfmC/EYwlMFYhWLJh/XQFaHoHZ kGNTX7omSf0OM48dwHBxC4nolpk5uCvLvgrRAc1eJAi2H8JyL6ngLVkXBVf6DhlezjrT7B 5dyVF0GEFFz2uFMfW3Ku0qnu5GLCQUk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-72XIH4ucM5eBew787V-rMg-1; Tue, 28 Jan 2020 11:26:10 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 487718C05D3; Tue, 28 Jan 2020 16:26:09 +0000 (UTC) Received: from [10.3.117.16] (ovpn-117-16.phx2.redhat.com [10.3.117.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B1A2984BC4; Tue, 28 Jan 2020 16:26:05 +0000 (UTC) Subject: Re: [PATCH 1/2] mirror: Store MirrorOp.co for debuggability To: Kevin Wolf , qemu-block@nongnu.org References: <20200128151755.25162-1-kwolf@redhat.com> <20200128151755.25162-2-kwolf@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <075e467e-33cf-1065-5d7e-e22047c7d102@redhat.com> Date: Tue, 28 Jan 2020 10:26:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200128151755.25162-2-kwolf@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 72XIH4ucM5eBew787V-rMg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jsnow@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/28/20 9:17 AM, Kevin Wolf wrote: > If a coroutine is launched, but the coroutine pointer isn't stored > anywhere, debugging any problems inside the coroutine is quite hard. > Let's store the coroutine pointer of a mirror operation in MirrorOp to > have it available in the debugger. > > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 2 ++ > 1 file changed, 2 insertions(+) Doesn't change semantics other than an unobservable performance delay; but the rewards in improved debugability warrant it. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org