From: axie Subject: Re: [PATCH 2/2] drm/amdgpu: Optimize mutex usage (v2) Date: Fri, 16 Jun 2017 18:00:21 -0400 Message-ID: <07c69549-9ec8-572a-797d-b8fc477f4aa8@amd.com> References: <1497589410-17779-1-git-send-email-AlexBin.Xie@amd.com> <1497589410-17779-2-git-send-email-AlexBin.Xie@amd.com> <86ceaa66-955d-ada4-358b-24334193a169@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <86ceaa66-955d-ada4-358b-24334193a169-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Alex Xie , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org CgpPbiAyMDE3LTA2LTE2IDAxOjQ4IFBNLCBDaHJpc3RpYW4gS8O2bmlnIHdyb3RlOgo+IEFtIDE2 LjA2LjIwMTcgdW0gMDc6MDMgc2NocmllYiBBbGV4IFhpZToKPj4gVXNlIHJ3X3NlbWFwaG9yZSBp bnN0ZWFkIG9mIG11dGV4IGZvciBib19saXN0cy4KPj4KPj4gSW4gb3JpZ2luYWwgZnVuY3Rpb24g YW1kZ3B1X2JvX2xpc3RfZ2V0LCB0aGUgd2FpdGluZwo+PiBmb3IgcmVzdWx0LT5sb2NrIGNhbiBi ZSBxdWl0ZSBsb25nIHdoaWxlIG11dGV4Cj4+IGJvX2xpc3RfbG9jayB3YXMgaG9sZGluZy4gSXQg Y2FuIG1ha2Ugb3RoZXIgdGFza3MKPj4gd2FpdGluZyBmb3IgYm9fbGlzdF9sb2NrIGZvciBsb25n IHBlcmlvZCB0b28uCj4+IENoYW5nZSBib19saXN0X2xvY2sgdG8gcndfc2VtYXBob3JlIGNhbiBh dm9pZCBtb3N0IG9mCj4+IHN1Y2ggbG9uZyB3YWl0aW5nLgo+Pgo+PiBTZWNvbmRseSwgdGhpcyBw YXRjaCBhbGxvd3Mgc2V2ZXJhbCB0YXNrcyhyZWFkZXJzIG9mIGlkcikKPj4gdG8gcHJvY2VlZCBh dCB0aGUgc2FtZSB0aW1lLgo+Pgo+PiB2MjogdXNlIHJjdSBhbmQga3JlZiAoRGF2ZSBBaXJsaWUg YW5kIENocmlzdGlhbiBLw7ZuaWcpCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEFsZXggWGllIDxBbGV4 QmluLlhpZUBhbWQuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHUuaCAgICAgICAgIHwgIDIgKysKPj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfYm9fbGlzdC5jIHwgNDAgCj4+ICsrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCj4+ ICAgMiBmaWxlcyBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCAxMiBkZWxldGlvbnMoLSkKPj4K Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oIAo+PiBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4+IGluZGV4IDA2M2ZjNzMuLmU5 YjM5ODEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5o Cj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4+IEBAIC04NzEs NiArODcxLDggQEAgc3RydWN0IGFtZGdwdV9mcHJpdiB7Cj4+ICAgICBzdHJ1Y3QgYW1kZ3B1X2Jv X2xpc3Qgewo+PiAgICAgICBzdHJ1Y3QgbXV0ZXggbG9jazsKPj4gKyAgICBzdHJ1Y3QgcmN1X2hl YWQgcmhlYWQ7Cj4+ICsgICAgc3RydWN0IGtyZWYgcmVmY291bnQ7Cj4+ICAgICAgIHN0cnVjdCBh bWRncHVfYm8gKmdkc19vYmo7Cj4+ICAgICAgIHN0cnVjdCBhbWRncHVfYm8gKmd3c19vYmo7Cj4+ ICAgICAgIHN0cnVjdCBhbWRncHVfYm8gKm9hX29iajsKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9ib19saXN0LmMgCj4+IGIvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2JvX2xpc3QuYwo+PiBpbmRleCA1YWY5NTZmLi5lZmE2OTAzIDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfYm9fbGlzdC5j Cj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9ib19saXN0LmMKPj4g QEAgLTQxLDYgKzQxLDIwIEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2JvX2xpc3Rfc2V0KHN0cnVjdCBh bWRncHVfZGV2aWNlIAo+PiAqYWRldiwKPj4gICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3Qg ZHJtX2FtZGdwdV9ib19saXN0X2VudHJ5ICppbmZvLAo+PiAgICAgICAgICAgICAgICAgICAgICAg IHVuc2lnbmVkIG51bV9lbnRyaWVzKTsKPj4gICArc3RhdGljIHZvaWQgYW1kZ3B1X2JvX2xpc3Rf cmVsZWFzZV9yY3Uoc3RydWN0IGtyZWYgKnJlZikKPj4gK3sKPj4gKyAgICB1bnNpZ25lZCBpOwo+ PiArICAgIHN0cnVjdCBhbWRncHVfYm9fbGlzdCAqbGlzdCA9IGNvbnRhaW5lcl9vZihyZWYsIHN0 cnVjdCAKPj4gYW1kZ3B1X2JvX2xpc3QsCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICBy ZWZjb3VudCk7Cj4+ICsKPj4gKyAgICBmb3IgKGkgPSAwOyBpIDwgbGlzdC0+bnVtX2VudHJpZXM7 ICsraSkKPj4gKyAgICAgICAgYW1kZ3B1X2JvX3VucmVmKCZsaXN0LT5hcnJheVtpXS5yb2JqKTsK Pj4gKwo+PiArICAgIG11dGV4X2Rlc3Ryb3koJmxpc3QtPmxvY2spOwo+PiArICAgIGRybV9mcmVl X2xhcmdlKGxpc3QtPmFycmF5KTsKPj4gKyAgICBrZnJlZV9yY3UobGlzdCwgcmhlYWQpOwo+PiAr fQo+PiArCj4KPiBJJ20gcHJvYmFibHkgbWlzc2luZyBzb21ldGhpbmcgaGVyZTogV2h5IGEgbmV3 IGZ1bmN0aW9uIGFuZCBub3QgY2hhbmdlIAo+IHRoZSBleGlzdGluZyBhbWRncHVfYm9fbGlzdF9m cmVlKCkgdG8gdXNlIGtmcmVlX3JjdSBpbnN0ZWFkPwo+Cj4gQXBhcnQgZnJvbSB0aGF0IHRoZSBw YXRjaCBsb29rcyBnb29kIHRvIG1lLAo+IENocmlzdGlhbi4KCmFtZGdwdV9ib19saXN0X2ZyZWUo KSBpcyBjYWxsZWQgYnkgYW1kZ3B1X2RyaXZlcl9wb3N0Y2xvc2Vfa21zIGluIGZpbGUgCmFtZGdw dV9rbXMuYyB0b28uCkZvciBhbWRncHVfZHJpdmVyX3Bvc3RjbG9zZV9rbXMsIHRoZXJlIGlzIG5v IG5lZWQgdG8gY2FsbCBrZnJlZV9yY3UuIEl0IAppcyBtb3JlIHN1aXRhYmxlIHRvIGNhbGwga2Zy ZWUuCgpTbyB3ZSBuZWVkIHR3byBkaWZmZXJlbnQgcmVsZWFzZS9mcmVlIGZ1bmN0aW9ucy4gVGhl biBJIGNyZWF0ZWQgYSBuZXcgCmZ1bmN0aW9uIGZvciBrcmVmX3B1dC4KCj4KPj4gICBzdGF0aWMg aW50IGFtZGdwdV9ib19saXN0X2NyZWF0ZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPj4g ICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkcm1fZmlsZSAqZmlscCwKPj4gICAgICAgICAgICAg ICAgICAgIHN0cnVjdCBkcm1fYW1kZ3B1X2JvX2xpc3RfZW50cnkgKmluZm8sCj4+IEBAIC01Nyw3 ICs3MSw3IEBAIHN0YXRpYyBpbnQgYW1kZ3B1X2JvX2xpc3RfY3JlYXRlKHN0cnVjdCAKPj4gYW1k Z3B1X2RldmljZSAqYWRldiwKPj4gICAgICAgICAvKiBpbml0aWFsaXplIGJvIGxpc3QqLwo+PiAg ICAgICBtdXRleF9pbml0KCZsaXN0LT5sb2NrKTsKPj4gLQo+PiArICAgIGtyZWZfaW5pdCgmbGlz dC0+cmVmY291bnQpOwo+PiAgICAgICByID0gYW1kZ3B1X2JvX2xpc3Rfc2V0KGFkZXYsIGZpbHAs IGxpc3QsIGluZm8sIG51bV9lbnRyaWVzKTsKPj4gICAgICAgaWYgKHIpIHsKPj4gICAgICAgICAg IGtmcmVlKGxpc3QpOwo+PiBAQCAtODMsMTQgKzk3LDkgQEAgc3RhdGljIHZvaWQgYW1kZ3B1X2Jv X2xpc3RfZGVzdHJveShzdHJ1Y3QgCj4+IGFtZGdwdV9mcHJpdiAqZnByaXYsIGludCBpZCkKPj4g ICAgICAgICBtdXRleF9sb2NrKCZmcHJpdi0+Ym9fbGlzdF9sb2NrKTsKPj4gICAgICAgbGlzdCA9 IGlkcl9yZW1vdmUoJmZwcml2LT5ib19saXN0X2hhbmRsZXMsIGlkKTsKPj4gLSAgICBpZiAobGlz dCkgewo+PiAtICAgICAgICAvKiBBbm90aGVyIHVzZXIgbWF5IGhhdmUgYSByZWZlcmVuY2UgdG8g dGhpcyBsaXN0IHN0aWxsICovCj4+IC0gICAgICAgIG11dGV4X2xvY2soJmxpc3QtPmxvY2spOwo+ PiAtICAgICAgICBtdXRleF91bmxvY2soJmxpc3QtPmxvY2spOwo+PiAtICAgICAgICBhbWRncHVf Ym9fbGlzdF9mcmVlKGxpc3QpOwo+PiAtICAgIH0KPj4gLQo+PiAgICAgICBtdXRleF91bmxvY2so JmZwcml2LT5ib19saXN0X2xvY2spOwo+PiArICAgIGlmIChsaXN0KQo+PiArICAgICAgICBrcmVm X3B1dCgmbGlzdC0+cmVmY291bnQsIGFtZGdwdV9ib19saXN0X3JlbGVhc2VfcmN1KTsKPj4gICB9 Cj4+ICAgICBzdGF0aWMgaW50IGFtZGdwdV9ib19saXN0X3NldChzdHJ1Y3QgYW1kZ3B1X2Rldmlj ZSAqYWRldiwKPj4gQEAgLTE4NSwxMSArMTk0LDE3IEBAIGFtZGdwdV9ib19saXN0X2dldChzdHJ1 Y3QgYW1kZ3B1X2Zwcml2ICpmcHJpdiwgCj4+IGludCBpZCkKPj4gICB7Cj4+ICAgICAgIHN0cnVj dCBhbWRncHVfYm9fbGlzdCAqcmVzdWx0Owo+PiAgIC0gICAgbXV0ZXhfbG9jaygmZnByaXYtPmJv X2xpc3RfbG9jayk7Cj4+ICsgICAgcmN1X3JlYWRfbG9jaygpOwo+PiAgICAgICByZXN1bHQgPSBp ZHJfZmluZCgmZnByaXYtPmJvX2xpc3RfaGFuZGxlcywgaWQpOwo+PiAtICAgIGlmIChyZXN1bHQp Cj4+IC0gICAgICAgIG11dGV4X2xvY2soJnJlc3VsdC0+bG9jayk7Cj4+IC0gICAgbXV0ZXhfdW5s b2NrKCZmcHJpdi0+Ym9fbGlzdF9sb2NrKTsKPj4gKwo+PiArICAgIGlmIChyZXN1bHQpIHsKPj4g KyAgICAgICAgaWYgKGtyZWZfZ2V0X3VubGVzc196ZXJvKCZyZXN1bHQtPnJlZmNvdW50KSkKPj4g KyAgICAgICAgICAgIG11dGV4X2xvY2soJnJlc3VsdC0+bG9jayk7Cj4+ICsgICAgICAgIGVsc2UK Pj4gKyAgICAgICAgICAgIHJlc3VsdCA9IE5VTEw7Cj4+ICsgICAgfQo+PiArICAgIHJjdV9yZWFk X3VubG9jaygpOwo+PiArCj4+ICAgICAgIHJldHVybiByZXN1bHQ7Cj4+ICAgfQo+PiAgIEBAIC0y MjcsNiArMjQyLDcgQEAgdm9pZCBhbWRncHVfYm9fbGlzdF9nZXRfbGlzdChzdHJ1Y3QgCj4+IGFt ZGdwdV9ib19saXN0ICpsaXN0LAo+PiAgIHZvaWQgYW1kZ3B1X2JvX2xpc3RfcHV0KHN0cnVjdCBh bWRncHVfYm9fbGlzdCAqbGlzdCkKPj4gICB7Cj4+ICAgICAgIG11dGV4X3VubG9jaygmbGlzdC0+ bG9jayk7Cj4+ICsgICAga3JlZl9wdXQoJmxpc3QtPnJlZmNvdW50LCBhbWRncHVfYm9fbGlzdF9y ZWxlYXNlX3JjdSk7Cj4+ICAgfQo+PiAgICAgdm9pZCBhbWRncHVfYm9fbGlzdF9mcmVlKHN0cnVj dCBhbWRncHVfYm9fbGlzdCAqbGlzdCkKPgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2FtZC1nZngK