From: "cron2 (Code Review)" Date: Mon, 30 Dec 2024 17:42:11 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641..., a@...2181... Message-ID: <07d58f6ef6fb90fa301386498953f57f58bf2e01-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="DmYJ5VP38l0="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: allow user to specify 'local' multiple times in config files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: flichtenheld , plaisthos , openvpn-devel --DmYJ5VP38l0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, ordex, plais= thos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/436?usp=3Demail ) Change subject: allow user to specify 'local' multiple times in config files ...................................................................... Patch Set 10: (3 comments) File doc/man-sections/link-options.rst: http://gerrit.openvpn.net/c/openvpn/+/436/comment/2e09fad4_f8cd789d : PS7, Line 114: open a socket. > Done, for the text. [=E2=80=A6] Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/436/comment/0fb1fac6_8c60bfdc : PS7, Line 3827: /* use the same listen list for every outgoing connecti= on */ > We handle everything as a list, but later on there's a specific sanity ch= eck that in the case of cli [=E2=80=A6] Done http://gerrit.openvpn.net/c/openvpn/+/436/comment/843e9fd5_709eae74 : PS7, Line 6250: e->bind_local =3D true; > I removed the bind_local variable on the local_entry and rely on the o->c= e. [=E2=80=A6] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/436?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20adde09529e2764 Gerrit-Change-Number: 436 Gerrit-PatchSet: 10 Gerrit-Owner: ordex Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: its_Giaan Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Attention: ordex Gerrit-Comment-Date: Mon, 30 Dec 2024 17:42:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: its_Giaan Comment-In-Reply-To: cron2 Gerrit-MessageType: comment --DmYJ5VP38l0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, ordex, p= laisthos.

View C= hange

3 comments:

    =
  • File doc/man-sections/link-options.= rst:

    • Patch Set #7, = Line 114: open a sock= et.

      Done, for the text. [=E2=80=A6]

      <= p style=3D"white-space: pre-wrap; word-wrap: break-word;">Done

    • File src/openvpn/options.c:

      • Patch Set #7, Line 3= 827: /* use the sam= e listen list for every outgoing connection */

        We han= dle everything as a list, but later on there's a specific sanity check = that in the case of cli [=E2=80=A6]

        Done

      • Patch Set #7, Lin= e 6250: e-&= gt;bind_local =3D true;

        I removed the bind_local vari= able on the local_entry and rely on the o->ce. [=E2=80=A6]
        <= /p>

        Done

      • =

    To view, visit change 436. To unsubscribe, or for help writing= mail filters, visit setting= s.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I4d1c96662c5a8c750d883e3b20a= dde09529e2764
    Gerrit-Change-Number: 436
    Gerrit-PatchSet: 10
    Gerrit-Owner: ordex <a@...2181...>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: its_Giaan <gianmarco@...1664...= 26...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Attention: ordex <a@...2181...> <= /div>
    Gerrit-Comment-Date: Mon, 30 Dec 2024 17:42:11= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: its_Giaan <gianmarco@...220...= ..2726...>
    Comment-In-Reply-To: cron2 <gert@...1296...= >
    Gerrit-MessageType: comment
    --DmYJ5VP38l0=--