Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18E56C001DE for ; Wed, 26 Jul 2023 07:08:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DF3D786784; Wed, 26 Jul 2023 09:08:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id BA2008677C; Wed, 26 Jul 2023 09:08:40 +0200 (CEST) Received: from mail-m11886.qiye.163.com (mail-m11886.qiye.163.com [115.236.118.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 16E1D80422 for ; Wed, 26 Jul 2023 09:08:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11886.qiye.163.com (Hmail) with ESMTPA id 6242E801C7; Wed, 26 Jul 2023 15:08:32 +0800 (CST) Message-ID: <0820aca6-3656-eec1-66a3-dcb39cc99733@rock-chips.com> Date: Wed, 26 Jul 2023 15:08:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 1/2] ARM: dts: rockchip: rk3588: Move bootph-all props to common file Content-Language: en-US To: Eugen Hristev , u-boot@lists.denx.de Cc: jonas@kwiboo.se, kernel@collabora.com References: <20230704190512.50127-1-eugen.hristev@collabora.com> From: Kever Yang In-Reply-To: <20230704190512.50127-1-eugen.hristev@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZGUJPGFZOSBpCGE1OQh1PSUpVEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk5MSUpJVUpLS1VKQl kG X-HM-Tid: 0a899107277b2ebakusn6242e801c7 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6ODI6Tzo*PT1KIUwIF08QSQIJ EEkKFChVSlVKTUJLSE5OSEpIS0pMVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFPTU1DNwY+ X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/7/5 03:05, Eugen Hristev wrote: > Move bootph-all prop to common SoC dt file, because they are typically used > by multiple boards. > Unreferenced nodes are removed from the SPL device tree during a > normal build. > > Suggested-by: Jonas Karlman > Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever > --- > > Resent with correct mail addresses > > Changes in v4: > - new patch > > arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 54 ------------------------ > arch/arm/dts/rk3588s-u-boot.dtsi | 56 +++++++++++++++++++++++++ > 2 files changed, 56 insertions(+), 54 deletions(-) > > diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > index f453aeeaf526..2a80422390e7 100644 > --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi > @@ -77,26 +77,6 @@ > status = "okay"; > }; > > -&emmc_bus8 { > - bootph-all; > -}; > - > -&emmc_clk { > - bootph-all; > -}; > - > -&emmc_cmd { > - bootph-all; > -}; > - > -&emmc_data_strobe { > - bootph-all; > -}; > - > -&emmc_rstnout { > - bootph-all; > -}; > - > &fspim2_pins { > bootph-all; > }; > @@ -109,8 +89,6 @@ > }; > > &pinctrl { > - bootph-all; > - > pcie { > pcie_reset_h: pcie-reset-h { > rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>; > @@ -139,39 +117,11 @@ > }; > }; > > -&pcfg_pull_none { > - bootph-all; > -}; > - > -&pcfg_pull_up_drv_level_2 { > - bootph-all; > -}; > - > -&pcfg_pull_up { > - bootph-all; > -}; > - > &sdmmc { > bus-width = <4>; > status = "okay"; > }; > > -&sdmmc_bus4 { > - bootph-all; > -}; > - > -&sdmmc_clk { > - bootph-all; > -}; > - > -&sdmmc_cmd { > - bootph-all; > -}; > - > -&sdmmc_det { > - bootph-all; > -}; > - > &sdhci { > cap-mmc-highspeed; > mmc-ddr-1_8v; > @@ -199,10 +149,6 @@ > }; > }; > > -&uart2m0_xfer { > - bootph-all; > -}; > - > &usb_host0_ehci { > companion = <&usb_host0_ohci>; > phys = <&u2phy2_host>; > diff --git a/arch/arm/dts/rk3588s-u-boot.dtsi b/arch/arm/dts/rk3588s-u-boot.dtsi > index acb1cfe20063..2d0b0d8ce2fc 100644 > --- a/arch/arm/dts/rk3588s-u-boot.dtsi > +++ b/arch/arm/dts/rk3588s-u-boot.dtsi > @@ -302,6 +302,42 @@ > }; > }; > > +&emmc_bus8 { > + bootph-all; > +}; > + > +&emmc_clk { > + bootph-all; > +}; > + > +&emmc_cmd { > + bootph-all; > +}; > + > +&emmc_data_strobe { > + bootph-all; > +}; > + > +&emmc_rstnout { > + bootph-all; > +}; > + > +&pinctrl { > + bootph-all; > +}; > + > +&pcfg_pull_none { > + bootph-all; > +}; > + > +&pcfg_pull_up_drv_level_2 { > + bootph-all; > +}; > + > +&pcfg_pull_up { > + bootph-all; > +}; > + > &xin24m { > bootph-all; > status = "okay"; > @@ -335,12 +371,32 @@ > u-boot,spl-fifo-mode; > }; > > +&sdmmc_bus4 { > + bootph-all; > +}; > + > +&sdmmc_clk { > + bootph-all; > +}; > + > +&sdmmc_cmd { > + bootph-all; > +}; > + > +&sdmmc_det { > + bootph-all; > +}; > + > &uart2 { > clock-frequency = <24000000>; > bootph-pre-ram; > status = "okay"; > }; > > +&uart2m0_xfer { > + bootph-all; > +}; > + > &ioc { > bootph-pre-ram; > };