From: "cron2 (Code Review)" Date: Mon, 27 Apr 2026 14:48:49 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, max@...2606... Message-ID: <086997eb29e077673bb0761bb22fbda36a351f11-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="jqLUiRQ8YQg="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Mbed TLS: Error out if we have no valid tls-groups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MaxF , plaisthos Cc: openvpn-devel --jqLUiRQ8YQg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1633?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: Mbed TLS: Error out if we have no valid tls-groups ...................................................................... Mbed TLS: Error out if we have no valid tls-groups Previously, when no valid groups were specified with the tls-groups option, the Mbed TLS build of OpenVPN would start up and run, but fail to complete a handshake, while the OpenSSL build would exit with an error. This commit changes the behavior of the Mbed TLS build to match the OpenSSL version. Change-Id: Ica5f37e525c3812609021750ecd3986c1420e2a4 Signed-off-by: Max Fillinger Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1633 Message-Id: <20260421055357.21708-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 699.html Signed-off-by: Gert Doering --- M src/openvpn/ssl_mbedtls.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/33/1633/2 diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls.c index 85c771a..8a0f7d2 100644 --- a/src/openvpn/ssl_mbedtls.c +++ b/src/openvpn/ssl_mbedtls.c @@ -450,6 +450,12 @@ } } + /* Check if any groups were valid. */ + if (i =3D=3D 0) + { + msg(M_FATAL, "Error: All groups in \"%s\" are invalid or unsupport= ed.", groups); + } + /* Recent mbedtls versions state that the list of groups must be termi= nated * with 0. Older versions state that it must be terminated with MBEDTL= S_ECP_DP_NONE * which is also 0, so this works either way. */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1633?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ica5f37e525c3812609021750ecd3986c1420e2a4 Gerrit-Change-Number: 1633 Gerrit-PatchSet: 2 Gerrit-Owner: MaxF Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --jqLUiRQ8YQg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by MaxF.

View Ch= ange

The following approvals got outdated and were removed: Code-Review+2 by plaisthos

Mbed TLS: Error out if we have =
no valid tls-groups

Previously, when no valid groups were specified = with the tls-groups
option, the Mbed TLS build of OpenVPN would start up= and run, but fail
to complete a handshake, while the OpenSSL build woul= d exit with an
error. This commit changes the behavior of the Mbed TLS b= uild to match
the OpenSSL version.

Change-Id: Ica5f37e525c3812609= 021750ecd3986c1420e2a4
Signed-off-by: Max Fillinger <maximilian.filli= nger@...2918...>
Acked-by: Arne Schwabe <arne-openvpn@...1227...&g= t;
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1633
Message-Id= : <20260421055357.21708-1-gert@...1296...>
URL: https://www.mail-a= rchive.com/openvpn-devel@lists.sourceforge.net/msg36699.html
Signed-off-= by: Gert Doering <gert@...1296...>
---
M src/openvpn/ssl_mbedtl= s.c
1 file changed, 6 insertions(+), 0 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/33/1633=
/2
diff --git a/src/openvpn/ssl_mbedtls.c b/src/openvpn/ssl_mbedtls=
.c
index 85c771a..8a0f7d2 100644
--- a/src/= openvpn/ssl_mbedtls.c
+++ b/src/openvpn/ssl_mbedtls.c
@@ -450,6 +450,12 @@
}
= }

+ /* Check if any groups were valid. */
+ if (i =3D=3D 0)
+ {
+ msg(M_FATAL, "Error: All groups in \"%s\&quo= t; are invalid or unsupported.", groups);
+ }
+
/* Recent mbedtls versions state that th= e list of groups must be terminated
* with 0. Older v= ersions state that it must be terminated with MBEDTLS_ECP_DP_NONE * which is also 0, so this works either way. */

To view, visit change 1633. To unsubscribe, or for help w= riting mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ica5f37e525c3812609021750ecd= 3986c1420e2a4
Gerrit-Change-Number: 1633
Gerrit-PatchSet: 2
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --jqLUiRQ8YQg=--