Return-Path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:37477 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730382AbeLPQpd (ORCPT ); Sun, 16 Dec 2018 11:45:33 -0500 Received: by mail-pg1-f196.google.com with SMTP id c25so3438460pgb.4 for ; Sun, 16 Dec 2018 08:45:32 -0800 (PST) Subject: Re: [PATCH 24/26] fs: add support for mapping an ITER_BVEC for O_DIRECT To: Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-aio@kvack.org, jmoyer@redhat.com, clm@fb.com References: <20181213175645.22181-1-axboe@kernel.dk> <20181213175645.22181-25-axboe@kernel.dk> <20181216164130.GD13234@lst.de> From: Jens Axboe Message-ID: <08794cd6-c009-9804-804b-0d83ee07c480@kernel.dk> Date: Sun, 16 Dec 2018 09:45:30 -0700 MIME-Version: 1.0 In-Reply-To: <20181216164130.GD13234@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 12/16/18 9:41 AM, Christoph Hellwig wrote: >> + if (iov_iter_is_bvec(iter)) >> + ret = bio_iov_bvec_add_pages(&bio, iter); >> + else >> + ret = bio_iov_iter_get_pages(&bio, iter); > > Shouldn't this actually be done inside bio_iov_iter_get_pages? It probably should... Should be trivial, I'll move it there instead. -- Jens Axboe