From: "cron2 (Code Review)" Date: Thu, 23 Jan 2025 17:50:33 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <08a01ee976a4d8f375e2f60b6b6c43458979390b-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="miY1kiFwxm8="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: multiproto: move generic event handling code in dedicated files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: flichtenheld , plaisthos , openvpn-devel --miY1kiFwxm8= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/763?usp=3Demail ) Change subject: multiproto: move generic event handling code in dedicated f= iles ...................................................................... Patch Set 13: (2 comments) Patchset: PS13: close :-) (the code compiles and passes light tests, but there is a comment= that is more confusing than helpful) File src/openvpn/multi.h: http://gerrit.openvpn.net/c/openvpn/+/763/comment/d62d69ef_43444458 : PS13, Line 180: * transport. */ getting close... but this comment does not make sense. What is it that is = stored here? Are there other protocols but UDP and TCP? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/763?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1e5a84969988e4f027a18658d4ab268c13fbf929 Gerrit-Change-Number: 763 Gerrit-PatchSet: 13 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Thu, 23 Jan 2025 17:50:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --miY1kiFwxm8= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, plaistho= s.

View C= hange

2 comments:

    =
  • Patchset:

    • Patch Set #13:

      close :-) (the code compiles and passes light te= sts, but there is a comment that is more confusing than helpful)

    • File src/openvpn/multi.h:

      • Patch Set #13, Line = 180: = * transport. */

        getting close... but this comment does not ma= ke sense. What is it that is stored here? Are there other protocols but U= DP and TCP?

    To view, visit change 763. To unsubscribe,= or for help writing mail filters, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I1e5a84969988e4f027a18658d4a= b268c13fbf929
    Gerrit-Change-Number: 763
    Gerrit-PatchSet: 13
    Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
    Gerrit-Reviewer: cron2 <gert@...1296...>=
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
    Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
    Gerrit-Comment-Date: Thu, 23 Jan 2025 17:50:33= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment
    --miY1kiFwxm8=--