From: "cron2 (Code Review)" Date: Wed, 19 Jun 2024 10:17:14 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <08bb0b66d2adaa484806f3ea00bb45a936fcb6a2-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="0oz6EPCt7uk="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Http-proxy: fix bug preventing proxy credentials caching List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: flichtenheld , plaisthos , openvpn-devel --0oz6EPCt7uk= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/523?usp=3Demail ) Change subject: Http-proxy: fix bug preventing proxy credentials caching ...................................................................... Patch Set 8: Code-Review-1 (3 comments) Patchset: PS8: Minor nitpick: function call and prototype having empty brackets `()` inste= ad of proper `(void)`. This needs to be fixed, and I can't do code changes= on merge. File src/openvpn/ssl.h: http://gerrit.openvpn.net/c/openvpn/+/523/comment/5680c4c5_ce81e31d : PS8, Line 402: bool ssl_get_auth_nocache(); this needs to have a `(void)` there. File src/openvpn/ssl.c: http://gerrit.openvpn.net/c/openvpn/+/523/comment/7c301b9f_a12ccb3f : PS8, Line 341: ssl_get_auth_nocache() this needs to have a `(void)` there. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/523?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279fb71c01a1a78a Gerrit-Change-Number: 523 Gerrit-PatchSet: 8 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Comment-Date: Wed, 19 Jun 2024 10:17:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --0oz6EPCt7uk= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: its_Giaan, plaisthos.

Patch set 8:Code-Review -1=

Vi= ew Change

3 comments:

  • Patchset:

    • Patch Set #8:

      Minor nitpick: function call and prototype ha= ving empty brackets `()` instead of proper `(void)`. This needs to be fixe= d, and I can't do code changes on merge.

  • File src/openvpn/ssl.h:

  • <= p>File src/openvpn/ssl.c:

      Patch Set #8, Line 341: ssl_get_auth_nocache()

      this needs to have a `(void)` there.

    =

To view, visit change 523. To unsubscribe, or for help writing mail= filters, visit settings= .

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ia3e06c0832c4ca0ab868c845279= fb71c01a1a78a
Gerrit-Change-Number: 523
Gerrit-PatchSet: 8
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Comment-Date: Wed, 19 Jun 2024 10:17:14= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--0oz6EPCt7uk=--