From: "cron2 (Code Review)" Date: Fri, 19 Jan 2024 13:12:31 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <08cafca8213c5be6c2b9f87e08d21f0610173179-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="KYsXuwyq9tM="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: buf_string_match_head_str: Fix Coverity issue 'Unsigned compared agai... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --KYsXuwyq9tM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/49= 1?usp=3Demail ) Change subject: buf_string_match_head_str: Fix Coverity issue 'Unsigned com= pared against 0' ...................................................................... buf_string_match_head_str: Fix Coverity issue 'Unsigned compared against 0' As Coverity says: An unsigned value can never be negative, so this test will always evaluate the same way. Was changed from int to size_t in commit 7fc608da4ec388c9209bd009cd5053ac0ff7df38 which triggered warning, but the check did not make sense before, either. Change-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3 Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Message-Id: <20240119120341.22933-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28= 093.html Signed-off-by: Gert Doering --- M src/openvpn/buffer.c 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/buffer.c b/src/openvpn/buffer.c index 0b94a52..2ad3461 100644 --- a/src/openvpn/buffer.c +++ b/src/openvpn/buffer.c @@ -822,7 +822,7 @@ buf_string_match_head_str(const struct buffer *src, const char *match) { const size_t size =3D strlen(match); - if (size < 0 || size > src->len) + if (size > src->len) { return false; } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/491?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3 Gerrit-Change-Number: 491 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-MessageType: merged --KYsXuwyq9tM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 submitted this change.

View Change

buf_string_match_head_str: Fix Coverity issue =
'Unsigned compared against 0'

As Coverity says:
An unsign= ed value can never be negative, so this test will always
evaluate the sa= me way.

Was changed from int to size_t in commit
7fc608da4ec388c9= 209bd009cd5053ac0ff7df38 which triggered warning,
but the check did not = make sense before, either.

Change-Id: I64f094eeb0ca8c3953a94d742adf4= 68faf27dab3
Signed-off-by: Frank Lichtenheld <frank@...2641...>Acked-by: Arne Schwabe <arne-openvpn@...1227...>
Message-Id: <= 20240119120341.22933-1-gert@...1296...>
URL: https://www.mail-archive= .com/openvpn-devel@lists.sourceforge.net/msg28093.html
Signed-off-by: Ge= rt Doering <gert@...1296...>
---
M src/openvpn/buffer.c
1 fi= le changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/openvpn/buffer.c b/src/openvpn/buffer.c
index 0b94a52..2ad3461 100644
--- a/src/openvpn/buffer.c
+++ b/src/openvpn/buffer.c
@@ -822,7 +822,7 = @@
buf_string_match_head_str(const struct buffer *src, con= st char *match)
{
const size_t size = =3D strlen(match);
- = if (size < 0 || size > src->len)
+ if (size > src->len)
= {
return false;
}
<= span>

To view, visit change 491. To unsubscribe, or for help = writing mail filters, visit = settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I64f094eeb0ca8c3953a94d742ad= f468faf27dab3
Gerrit-Change-Number: 491
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-MessageType: merged
--KYsXuwyq9tM=--