From: "MaxF (Code Review)"
Date: Thu, 9 Jan 2025 16:33:05 +0000
In-Reply-To:
References:
Reply-To: max@...2606..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...
Message-ID: <08cd8ccaa218f78bddaadccf7929eea5f035f6c6-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="dB8hU4SL1BE="; charset=UTF-8
Subject: [Openvpn-devel] [L] Change in openvpn[master]: Implement methods to
generate and manage OpenVPN Epoch keys
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: flichtenheld , openvpn-devel
--dB8hU4SL1BE=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/open=
vpn/+/804?usp=3Demail )
Change subject: Implement methods to generate and manage OpenVPN Epoch keys
......................................................................
Patch Set 12: Code-Review+2
(3 comments)
Patchset:
PS12:
Looks good!
Some typos, but those can be resolved during check-in I think.
File src/openvpn/crypto_epoch.c:
http://gerrit.openvpn.net/c/openvpn/+/804/comment/b2171fc7_9bf1eb9e :
PS12, Line 215: /* We want the future receive keys to start just after =
the epoch of the
: * the currently used decryption key. */
"the the"
(can be fixed during commit I think)
File src/openvpn/packet_id.h:
http://gerrit.openvpn.net/c/openvpn/+/804/comment/0548db58_7fc4e970 :
PS12, Line 210: * Move the packet id recv structure from \c src to \c dest=
. \c src will will
: * be reinitialised. \c dest will be freed before the move.
"will will"
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/804?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id7d6a576ca8c9560cb2dfae82fc62175820e9b80
Gerrit-Change-Number: 804
Gerrit-PatchSet: 12
Gerrit-Owner: plaisthos
Gerrit-Reviewer: MaxF
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Comment-Date: Thu, 09 Jan 2025 16:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--dB8hU4SL1BE=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, plaisthos.
Patch set 12:Code-Review +2
V=
iew Change
3 comments:
Patchset:
- <=
p>File src/openvpn/crypto_epoch.c:
File=
src/openvpn/packet_id.h:
Patch Set #12, Line 210:
* Move the packet id recv=
structure from \c src to \c dest. \c src will will
* be reinitialised.=
\c dest will be freed before the move.
"will will"
To view, visit change 804. To unsubscribe, or for help w=
riting mail filters, visit s=
ettings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Id7d6a576ca8c9560cb2dfae82fc=
62175820e9b80
Gerrit-Change-Number: 804
Gerrit-PatchSet: 12
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: MaxF <max@...2606...> <=
/div>
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Comment-Date: Thu, 09 Jan 2025 16:33:05=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--dB8hU4SL1BE=--