From: "ordex (Code Review)" Date: Mon, 23 Jun 2025 13:47:12 +0000 In-Reply-To: References: Reply-To: antonio@...2726..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, ralf@...2726..., frank@...2641... Message-ID: <091c1ab599a9af2383afb507930022334511db9e-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Ge9Ye5ize+g="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: dco linux: avoid redefining ovpn enums List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ralf_lici Cc: plaisthos , flichtenheld , openvpn-devel --Ge9Ye5ize+g= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, ralf_lici. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1064?usp=3Demail ) Change subject: dco linux: avoid redefining ovpn enums ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: patch looks good to me, however the commit message says nothing about conve= rting MAX from enum to define. I'd just add on line saying something like "= While at it, convert ..._MAX to define, to reflect the way it is defined in= kernel 6.16" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1064?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4fa2d578f9c0a5a8aa24ca1d396102ef2ed9a425 Gerrit-Change-Number: 1064 Gerrit-PatchSet: 2 Gerrit-Owner: ralf_lici Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: ordex Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: ralf_lici Gerrit-Comment-Date: Mon, 23 Jun 2025 13:47:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --Ge9Ye5ize+g= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, ralf_lic= i.

Patch set 2:Code-Review +1=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #2:

      patch looks good to me, however the commit m= essage says nothing about converting MAX from enum to define. I'd just = add on line saying something like "While at it, convert ..._MAX to def= ine, to reflect the way it is defined in kernel 6.16"

To view, visit change 1064. To unsubscribe, or for help writing mail = filters, visit settings.=

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4fa2d578f9c0a5a8aa24ca1d396= 102ef2ed9a425
Gerrit-Change-Number: 1064
Gerrit-PatchSet: 2
Gerrit-Owner: ralf_lici <ralf@...2726...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: ordex <antonio@...2726...&= gt;
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ralf_lici <ralf@...2804...= .>
Gerrit-Comment-Date: Mon, 23 Jun 2025 13:47:12= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--Ge9Ye5ize+g=--