From: Dhinakaran Pandiyan Subject: Re: [PATCH v2 2/6] drm/i915/psr: Always wait for idle state when disabling PSR Date: Tue, 23 Oct 2018 18:33:19 -0700 Message-ID: <094157043fd34e8bfe72baea998c8d023a234734.camel@intel.com> References: <20181011004124.4110-1-jose.souza@intel.com> <20181011004124.4110-2-jose.souza@intel.com> <25246891.FZNb5hYFUk@dk-thinkpad-x260> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F6F36E11D for ; Wed, 24 Oct 2018 01:33:23 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Souza, Jose" , "intel-gfx@lists.freedesktop.org" Cc: "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE4LTEwLTE5IGF0IDIzOjQ2ICswMDAwLCBTb3V6YSwgSm9zZSB3cm90ZToKPiBP biBGcmksIDIwMTgtMTAtMTkgYXQgMTM6NDIgLTA3MDAsIERoaW5ha2FyYW4gUGFuZGl5YW4gd3Jv dGU6Cj4gPiBPbiBXZWRuZXNkYXksIE9jdG9iZXIgMTAsIDIwMTggNTo0MToyMCBQTSBQRFQgSm9z w6kgUm9iZXJ0byBkZSBTb3V6YQo+ID4gd3JvdGU6Cj4gPiA+IEl0IHNob3VsZCBhbHdheXMgd2Fp dCBmb3IgaWRsZSBzdGF0ZSB3aGVuIGRpc2FibGluZyBQU1IgYmVjYXVzZSAKIkl0IiBpcyBhbWJp Z3VvdXMgaGVyZS4gCgpIb3cgYWJvdXQgc29tZXRoaW5nIGFsb25nIHRoZSBsaW5lcyBvZiAtCiJV bmNvbmRpdGlvbmFsbHkgd2FpdCBmb3IgUFNSIGhhcmR3YXJlIHRvIGlkbGUgd2hlbiBkaXNhYmxp bmcgUFNSLiBFdmVuCmlmIGEgcHJlY2VkaW5nIGZyb250IGJ1ZmZlciBpbnZhbGlkYXRlIGFscmVh ZHkgZGlzYWJsZWQgdGhlIGZlYXR1cmUsIGEKd2FpdCBmb3IgaWRsZSBpcyByZXF1aXJlZCBiZWZv cmUgZm9yIHJlLWVuYWJsaW5nIi4gRmVlbCBmcmVlIHRvIGlnbm9yZS4KCgo+ID4gPiBQU1IKPiA+ ID4gY291bGQgYmUgaW5hY3RpdmUgZHVlIGEgY2FsbCB0byBpbnRlbF9wc3JfZXhpdCgpIGFuZCB3 aGlsZSBQU1IgaXMKPiA+ID4gc3RpbGwgYmVpbmcgZGlzYWJsZWQgYXN5bmNocm9ub3VzbHkgdXNl cnNwYWNlIGNvdWxkIGNoYW5nZSB0aGUKPiA+ID4gbW9kZXNldCBjYXVzaW5nIGEgY2FsbCB0byBw c3JfZGlzYWJsZSgpIHRoYXQgd2lsbCBub3Qgd2FpdCBmb3IKPiA+ID4gUFNSCj4gPiA+IGlkbGUg YW5kIHRoZW4gUFNSIHdpbGwgYmUgZW5hYmxlZCBhZ2FpbiB3aGlsZSBQU1IgaXMgc3RpbGwgbm90 Cj4gPiA+IGlkbGUuCj4gPiA+IAo+ID4gPiB2MjogcmViYXNlZCBvbiB0b3Agb2YgdGhlIHBhdGNo IHJldXNpbmcgcHNyX2V4aXQoKQo+ID4gPiAKPiA+ID4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmln by52aXZpQGludGVsLmNvbT4KPiA+ID4gQ2M6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2Fy YW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBKb3PDqSBSb2JlcnRv IGRlIFNvdXphIDxqb3NlLnNvdXphQGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8IDQxICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0t Cj4gPiA+IC0tLS0tLQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDIz IGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3Bzci5jCj4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMg aW5kZXgKPiA+ID4gZjY5OGIzZjQ1YzZkLi4xNmQwZTNkZjdkZTAKPiA+ID4gMTAwNjQ0Cj4gPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiA+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gPiA+IEBAIC02NjEsOCArNjYxLDEyIEBAIHN0 YXRpYyB2b2lkIGludGVsX3Bzcl9leGl0KHN0cnVjdAo+ID4gPiBkcm1faTkxNV9wcml2YXRlCj4g PiA+ICpkZXZfcHJpdikgewo+ID4gPiAgCXUzMiB2YWw7Cj4gPiA+IAo+ID4gPiAtCWlmICghZGV2 X3ByaXYtPnBzci5hY3RpdmUpCj4gPiA+ICsJaWYgKCFkZXZfcHJpdi0+cHNyLmFjdGl2ZSkgewo+ ID4gPiArCQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5KQo+ID4gPiArCQkJV0FSTl9PTihJ OTE1X1JFQUQoRURQX1BTUjJfQ1RMKSAmCj4gPiA+IEVEUF9QU1IyX0VOQUJMRSk7Cj4gPiA+ICsJ CVdBUk5fT04oSTkxNV9SRUFEKEVEUF9QU1JfQ1RMKSAmIEVEUF9QU1JfRU5BQkxFKTsKPiA+IAo+ ID4gRG8gd2UgcmVhbGx5IG5lZWQgc28gbWFueSBXQVJOX09OcyBuZWVkaW5nIE1NSU8gcmVhZHM/ IFRoZXJlIGFyZQo+ID4gYWxtb3N0IGFzIAo+ID4gbWFueSBsaW5lcyBvZiB3YXJuaW5ncyBhcyBj b2RlIGluIHRoaXMgZnVuY3Rpb24uIEkgdGhpbmsgYXQgdGhpcwo+ID4gcG9pbnQsIHdlIAo+ID4g a25vdyB0aGlzIGNvZGUgd29ya3MgYW5kIHRoZSB3YXJuaW5ncyBpbiBwc3JfZXhpdCgpIHNob3Vs ZCBiZQo+ID4gcmVtb3ZlZC4KPiAKPiBJJ20ganVzdCBtb3Zpbmcgd2hhdCBpbnRlbF9wc3JfZGlz YWJsZV9zb3VyY2UoKSBoYWQgYnV0IHllcyBJIHRoaW5rCj4gd2UKPiBjYW4gcmVtb3ZlIHNvbWUg V0FSTl9PTigpIGluIGludGVsX3BzciBidXQgSSBndWVzcyBpcyBiZXR0ZXIgZG8gaW4KPiBhbm90 aGVyIHBhdGNoLgo+IApQbGVhc2UgZG8gc28gOikKClJldmlld2VkLWJ5OiBEaGluYWthcmFuIFBh bmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiA+IAo+ID4gPiAgCQlyZXR1 cm47Cj4gPiA+ICsJfQo+ID4gPiAKPiA+ID4gIAlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJs ZWQpIHsKPiA+ID4gIAkJdmFsID0gSTkxNV9SRUFEKEVEUF9QU1IyX0NUTCk7Cj4gPiA+IEBAIC02 ODAsMzIgKzY4NCwyMyBAQCBzdGF0aWMgdm9pZAo+ID4gPiAgaW50ZWxfcHNyX2Rpc2FibGVfc291 cmNlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gPiA+ICB7Cj4gPiA+ICAJc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZHBfdG9faTkxNShpbnRlbF9kcCk7Cj4gPiA+ICsJ aTkxNV9yZWdfdCBwc3Jfc3RhdHVzOwo+ID4gPiArCXUzMiBwc3Jfc3RhdHVzX21hc2s7Cj4gPiA+ IAo+ID4gPiAtCWlmIChkZXZfcHJpdi0+cHNyLmFjdGl2ZSkgewo+ID4gPiAtCQlpOTE1X3JlZ190 IHBzcl9zdGF0dXM7Cj4gPiA+IC0JCXUzMiBwc3Jfc3RhdHVzX21hc2s7Cj4gPiA+IC0KPiA+ID4g LQkJaW50ZWxfcHNyX2V4aXQoZGV2X3ByaXYpOwo+ID4gPiArCWludGVsX3Bzcl9leGl0KGRldl9w cml2KTsKPiA+ID4gCj4gPiA+IC0JCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfZW5hYmxlZCkgewo+ ID4gPiAtCQkJcHNyX3N0YXR1cyA9IEVEUF9QU1IyX1NUQVRVUzsKPiA+ID4gLQkJCXBzcl9zdGF0 dXNfbWFzayA9IEVEUF9QU1IyX1NUQVRVU19TVEFURV9NQVNLOwo+ID4gPiAtCQl9IGVsc2Ugewo+ ID4gPiAtCQkJcHNyX3N0YXR1cyA9IEVEUF9QU1JfU1RBVFVTOwo+ID4gPiAtCQkJcHNyX3N0YXR1 c19tYXNrID0gRURQX1BTUl9TVEFUVVNfU1RBVEVfTUFTSzsKPiA+ID4gLQkJfQo+ID4gPiAtCj4g PiA+IC0JCS8qIFdhaXQgdGlsbCBQU1IgaXMgaWRsZSAqLwo+ID4gPiAtCQlpZiAoaW50ZWxfd2Fp dF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4gPiA+IC0JCQkJCSAgICBwc3Jfc3RhdHVzLAo+ID4g PiBwc3Jfc3RhdHVzX21hc2ssIDAsCj4gPiA+IC0JCQkJCSAgICAyMDAwKSkKPiA+ID4gLQkJCURS TV9FUlJPUigiVGltZWQgb3V0IHdhaXRpbmcgZm9yIFBTUiBJZGxlCj4gPiA+IFN0YXRlXG4iKTsK PiA+ID4gKwlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX2VuYWJsZWQpIHsKPiA+ID4gKwkJcHNyX3N0 YXR1cyA9IEVEUF9QU1IyX1NUQVRVUzsKPiA+ID4gKwkJcHNyX3N0YXR1c19tYXNrID0gRURQX1BT UjJfU1RBVFVTX1NUQVRFX01BU0s7Cj4gPiA+ICAJfSBlbHNlIHsKPiA+ID4gLQkJaWYgKGRldl9w cml2LT5wc3IucHNyMl9lbmFibGVkKQo+ID4gPiAtCQkJV0FSTl9PTihJOTE1X1JFQUQoRURQX1BT UjJfQ1RMKSAmCj4gPiA+IEVEUF9QU1IyX0VOQUJMRSk7Cj4gPiA+IC0JCWVsc2UKPiA+ID4gLQkJ CVdBUk5fT04oSTkxNV9SRUFEKEVEUF9QU1JfQ1RMKSAmCj4gPiA+IEVEUF9QU1JfRU5BQkxFKTsK PiA+ID4gKwkJcHNyX3N0YXR1cyA9IEVEUF9QU1JfU1RBVFVTOwo+ID4gPiArCQlwc3Jfc3RhdHVz X21hc2sgPSBFRFBfUFNSX1NUQVRVU19TVEFURV9NQVNLOwo+ID4gPiAgCX0KPiA+ID4gKwo+ID4g PiArCS8qIFdhaXQgdGlsbCBQU1IgaXMgaWRsZSAqLwo+ID4gPiArCWlmIChpbnRlbF93YWl0X2Zv cl9yZWdpc3RlcihkZXZfcHJpdiwgcHNyX3N0YXR1cywKPiA+ID4gcHNyX3N0YXR1c19tYXNrLCAw LAo+ID4gPiArCQkJCSAgICAyMDAwKSkKPiA+ID4gKwkJRFJNX0VSUk9SKCJUaW1lZCBvdXQgd2Fp dGluZyBmb3IgUFNSIElkbGUgU3RhdGVcbiIpOwo+ID4gPiAgfQo+ID4gPiAKPiA+ID4gIHN0YXRp YyB2b2lkIGludGVsX3Bzcl9kaXNhYmxlX2xvY2tlZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw KQo+ID4gCj4gPiAKPiA+IAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4Cg==