From: "flichtenheld (Code Review)" Date: Mon, 20 Apr 2026 12:00:05 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <095eec13a0b9150911dfe86ec57ee81fa0d55ff7-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="4Br628x+Wdw="; charset=UTF-8 Subject: [Openvpn-devel] [L] Change in openvpn[master]: GHA: Factor out building SSL libs to a reusable workflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --4Br628x+Wdw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to reexamine a change. Please visit http://gerrit.openvpn.net/c/openvpn/+/1630?usp=3Demail to look at the new patch set (#2). Change subject: GHA: Factor out building SSL libs to a reusable workflow ...................................................................... GHA: Factor out building SSL libs to a reusable workflow We amassed a lot of code duplication there. Make it easier to track the differences between the libraries. Change-Id: I3d89016ccae297cfa596897c11a518f1ffbe3dc8 Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml A .github/workflows/test-ssllib.yml M renovate.json 3 files changed, 155 insertions(+), 313 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/30/1630/2 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 365e72a..e4cb799 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -304,324 +304,49 @@ !${{ github.workspace }}/out/**/vcpkg_installed/** libressl: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [libressl] - build: [ normal, asan ] - configureflags: ["--with-openssl-engine=3Dno"] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}}" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - UBSAN_OPTIONS: print_stacktrace=3D1 + uses: ./.github/workflows/test-ssllib.yml + with: + libname: libressl + ovpnlibdesc: LibreSSL # versioning=3Dsemver-coerced - LIBRESSL_REPO: libressl/portable - LIBRESSL_VERSION: v4.2.1 - LIBRESSL_INSTALL: /opt/libressl + ghrepo: libressl/portable + gitref: v4.2.1 + libconfigure: "LIBRESSL_GIT_OPTIONS=3D--no-single-branch ./autogen.s= h && ./configure --prefix=3D$LIBPREFIX" - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev - - name: Restore libressl from cache - uses: actions/cache@...3010... - id: libressl-cache - with: - path: ${{ env.LIBRESSL_INSTALL }} - key: ${{ matrix.os }}-libressl-${{matrix.build }}-${{ env.LIBRES= SL_VERSION }} - - name: "libressl: checkout" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: libressl - repository: ${{ env.LIBRESSL_REPO }} - ref: ${{ env.LIBRESSL_VERSION }} - - name: "libressl: autogen.sh" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - env: - LIBRESSL_GIT_OPTIONS: "--no-single-branch" - run: ./autogen.sh - working-directory: libressl - - name: "libressl: configure" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - run: ./configure --prefix=3D${{ env.LIBRESSL_INSTALL }} - working-directory: libressl - - name: "libressl: make all" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - run: make -j3 - working-directory: libressl - - name: "libressl: make install" - if: steps.libressl-cache.outputs.cache-hit !=3D 'true' - run: sudo make install - working-directory: libressl - - name: "ldconfig" - run: sudo ldconfig - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure - run: | - OPENSSL_CFLAGS=3D"-I${{ env.LIBRESSL_INSTALL }}/include" \ - OPENSSL_LIBS=3D"-L${{ env.LIBRESSL_INSTALL }}/lib -lssl -lcrypto= " \ - LDFLAGS=3D"-Wl,-rpath=3D${{ env.LIBRESSL_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl --enable-werror ${{m= atrix.configureflags}} - - name: make all - run: make -j3 - - name: Ensure the build uses LibreSSL - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: Lib= reSSL" - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 - - openssl: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [openssl] - build: [ normal, asan ] - configureflags: ["--with-openssl-engine=3Dno"] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}} - 4.0" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - UBSAN_OPTIONS: print_stacktrace=3D1 + openssl4: + uses: ./.github/workflows/test-ssllib.yml + with: + libname: openssl + ovpnlibdesc: OpenSSL 4. # versioning=3Dsemver-coerced - OPENSSL_REPO: openssl/openssl - OPENSSL_VERSION: openssl-4.0.0-beta1 - OPENSSL_INSTALL: /opt/openssl - - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev - - name: Restore OpenSSL 4.0 from cache - uses: actions/cache@...3010... - id: openssl-cache - with: - path: ${{ env.OPENSSL_INSTALL }} - key: ${{ matrix.os }}-openssl-${{matrix.build }}-${{ env.OPENSSL= _VERSION }} - - name: "openssl: checkout" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: openssl - repository: ${{ env.OPENSSL_REPO }} - ref: ${{ env.OPENSSL_VERSION }} - - name: "openssl: configure" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - run: ./Configure --prefix=3D${{ env.OPENSSL_INSTALL }} --libdir= =3D${{ env.OPENSSL_INSTALL }}/lib --openssldir=3D${{ env.OPENSSL_INSTALL }}= -g - working-directory: openssl - - name: "openssl: make all" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - run: make -j3 - working-directory: openssl - - name: "openssl: make install" - if: steps.openssl-cache.outputs.cache-hit !=3D 'true' - run: sudo make install - working-directory: openssl - - name: "ldconfig" - run: sudo ldconfig - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure - run: | - OPENSSL_CFLAGS=3D"-I${{ env.OPENSSL_INSTALL }}/include" \ - OPENSSL_LIBS=3D"-L${{ env.OPENSSL_INSTALL }}/lib -lssl -lcrypto"= \ - LDFLAGS=3D"-Wl,-rpath=3D${{ env.OPENSSL_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl --enable-werror ${{m= atrix.configureflags}} - - name: make all - run: make -j3 - - name: Ensure the build uses Openssl - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: Ope= nSSL 4.0" - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 + ghrepo: openssl/openssl + gitref: openssl-4.0.0-beta1 + libconfigure: ./Configure --prefix=3D$LIBPREFIX --libdir=3D$LIBPREFI= X/lib --openssldir=3D$LIBPREFIX -g mbedtls4: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [mbedtls4] - build: [ normal, asan ] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}}" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - UBSAN_OPTIONS: print_stacktrace=3D1 - PKG_CONFIG_PATH: /opt/mbedtls4/lib/pkgconfig + uses: ./.github/workflows/test-ssllib.yml + with: + libname: mbedtls + ovpnlibname: mbedtls + ovpnlibdesc: mbed TLS 4. # versioning=3Dsemver-coerced - MBEDTLS_REPO: Mbed-TLS/mbedtls - MBEDTLS_VERSION: v4.0.0 - MBEDTLS_INSTALL: /opt/mbedtls4 - - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = python3-jinja2 python3-jsonschema libtool automake autoconf pkg-config libc= ap-ng-dev libnl-genl-3-dev - - name: Restore mbed TLS from cache - uses: actions/cache@...3010... - id: mbedtls-cache - with: - path: ${{ env.MBEDTLS_INSTALL }} - key: ${{ matrix.os }}-mbedtls-${{matrix.build }}-${{ env.MBEDTLS= _VERSION }} - - name: "mbedtls: checkout" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: mbedtls - submodules: recursive - repository: ${{ env.MBEDTLS_REPO }} - ref: ${{ env.MBEDTLS_VERSION }} - - uses: lukka/get-cmake@...2999... # v4.2.3 - - name: "mbedtls: cmake" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - run: cmake -B build -DCMAKE_INSTALL_PREFIX=3D${{ env.MBEDTLS_INSTA= L }} - working-directory: mbedtls - - name: "mbedtls: cmake --build" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - run: cmake --build build - working-directory: mbedtls - - name: "mbedtls: cmake --install" - if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true' - run: sudo cmake --install build - working-directory: mbedtls - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure - run: ./configure --with-crypto-library=3Dmbedtls --enable-werror - - name: make all - run: make -j3 - - name: Ensure the build uses mbed TLS ${{ env.MBEDTLS_VERSION }} - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: mbe= d TLS 4." - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 + ghrepo: Mbed-TLS/mbedtls + gitref: v4.0.0 + libconfigure: cmake -B build -DCMAKE_INSTALL_PREFIX=3D$LIBPREFIX + libmake: cmake --build build + libinstall: sudo cmake --install build + ovpnconfigureenv: PKG_CONFIG_PATH=3D$LIBPREFIX/lib/pkgconfig aws-lc: - strategy: - fail-fast: false - matrix: - os: [ubuntu-24.04] - ssllib: [ awslc ] - build: [ normal, asan ] - include: - - build: asan - cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" - ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall - cc: clang - cxx: clang++ - - build: normal - cflags: "-O2 -g" - ldflags: "" - cc: gcc - cxx: c++ - - name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{matrix.s= sllib}}" - runs-on: ${{matrix.os}} - env: - CFLAGS: ${{ matrix.cflags }} - LDFLAGS: ${{ matrix.ldflags }} - CC: ${{matrix.cc}} - CXX: ${{matrix.cxx}} - UBSAN_OPTIONS: print_stacktrace=3D1 - AWS_LC_INSTALL: /opt/aws-lc + uses: ./.github/workflows/test-ssllib.yml + with: + libname: aws-lc + ovpnlibdesc: AWS-LC # versioning=3Dsemver-coerced - AWS_LC_REPO: aws/aws-lc - AWS_LC_VERSION: v1.70.0 - - steps: - - name: Install dependencies - run: sudo apt update && sudo apt install -y gcc golang make liblzo= 2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka-dev p= ython3-docutils python3-jinja2 python3-jsonschema libtool automake autoconf= pkg-config libcap-ng-dev libnl-genl-3-dev - - name: Restore AWS-LC from cache - uses: actions/cache@...3010... - id: aws-lc-cache - with: - path: ${{ env.AWS_LC_INSTALL }} - key: ${{ matrix.os }}-aws-lc-${{matrix.build }}-${{ env.AWS_LC_V= ERSION }} - - name: "AWS-LC: checkout" - if: steps.aws-lc-cache.outputs.cache-hit !=3D 'true' - uses: actions/checkout@...2998... # v6.0.2 - with: - path: aws-lc - repository: ${{ env.AWS_LC_REPO }} - ref: ${{ env.AWS_LC_VERSION }} - - uses: lukka/get-cmake@...2999... # v4.2.3 - - name: "AWS-LC: build" - if: steps.aws-lc-cache.outputs.cache-hit !=3D 'true' - run: | - mkdir build - cd build - cmake -GNinja -DCMAKE_BUILD_TYPE=3DRelease -DCMAKE_INSTALL_PREFI= X=3D"${{ env.AWS_LC_INSTALL }}" -DBUILD_SHARED_LIBS=3D1 ../ - ninja install - working-directory: aws-lc - - name: Checkout OpenVPN - uses: actions/checkout@...2998... # v6.0.2 - - name: autoconf - run: autoreconf -fvi - - name: configure with AWS-LC - run: | - OPENSSL_CFLAGS=3D"-I${{ env.AWS_LC_INSTALL }}/include" \ - OPENSSL_LIBS=3D"-L${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto" \ - LDFLAGS=3D"-Wl,-rpath=3D${{ env.AWS_LC_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl - - name: make all - run: make -j3 - - name: Ensure the build uses AWS-LC - run: | - ./src/openvpn/openvpn --version - ./src/openvpn/openvpn --version | grep -q "library versions: AWS= -LC" - - name: configure checks - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc - - name: make check - run: make -j3 check VERBOSE=3D1 + ghrepo: aws/aws-lc + gitref: v1.70.0 + libconfigure: cmake -B build -GNinja -DCMAKE_BUILD_TYPE=3DRelease -D= CMAKE_INSTALL_PREFIX=3D"$LIBPREFIX" -DBUILD_SHARED_LIBS=3D1 + libmake: cmake --build build + libinstall: sudo cmake --install build + # not ready for --enable-werror + ovpnconfigureflags: diff --git a/.github/workflows/test-ssllib.yml b/.github/workflows/test-ssl= lib.yml new file mode 100644 index 0000000..4e37fef --- /dev/null +++ b/.github/workflows/test-ssllib.yml @@ -0,0 +1,117 @@ +name: test_ssllib + +on: + workflow_call: + inputs: + libname: + required: true + type: string + ovpnlibname: + type: string + default: openssl + ovpnlibdesc: + required: true + type: string + ghrepo: + required: true + type: string + gitref: + required: true + type: string + libconfigure: + required: true + type: string + libmake: + type: string + default: "make -j3" + libinstall: + type: string + default: "sudo make install" + ovpnconfigureenv: + type: string + default: >- + OPENSSL_CFLAGS=3D"-I$LIBPREFIX/include" + OPENSSL_LIBS=3D"-L$LIBPREFIX/lib -lssl -lcrypto" + LDFLAGS=3D"-Wl,-rpath=3D$LIBPREFIX/lib" + ovpnconfigureflags: + type: string + default: --enable-werror --with-openssl-engine=3Dno + +jobs: + test_ssllib: + strategy: + fail-fast: false + matrix: + os: [ubuntu-24.04] + build: [normal, asan] + include: + - build: asan + cflags: "-fsanitize=3Daddress -fno-sanitize-recover=3Dall -fn= o-optimize-sibling-calls -fsanitize-address-use-after-scope -fno-omit-frame= -pointer -g -O1" + ldflags: -fsanitize=3Daddress -fno-sanitize-recover=3Dall + cc: clang + cxx: clang++ + - build: normal + cflags: "-O2 -g" + ldflags: "" + cc: gcc + cxx: g++ + + name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${{inputs.l= ibname}}" + runs-on: ${{matrix.os}} + env: + CFLAGS: ${{matrix.cflags}} + LDFLAGS: ${{matrix.ldflags}} + CC: ${{matrix.cc}} + CXX: ${{matrix.cxx}} + UBSAN_OPTIONS: print_stacktrace=3D1 + LIBPREFIX: /opt/${{inputs.libname}} + + steps: + - name: Install dependencies + run: sudo apt update && sudo apt install -y liblzo2-dev libpam0g-d= ev liblz4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils = libtool automake autoconf pkg-config libcap-ng-dev libnl-genl-3-dev + - name: Restore ${{inputs.libname}} from cache + uses: actions/cache@...3010... + id: ssllib-cache + with: + path: ${{env.LIBPREFIX}} + key: ${{matrix.os}}-${{inputs.libname}}-${{matrix.build }}-${{in= puts.gitref}} + - name: "${{inputs.libname}}: checkout" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + uses: actions/checkout@...2998... # v6.0.2 + with: + submodules: recursive + path: ${{inputs.libname}} + repository: ${{inputs.ghrepo}} + ref: ${{inputs.gitref}} + - name: "${{inputs.libname}}: configure" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + run: ${{inputs.libconfigure}} + working-directory: ${{inputs.libname}} + - name: "${{inputs.libname}}: build" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + run: ${{inputs.libmake}} + working-directory: ${{inputs.libname}} + - name: "${{inputs.libname}}: install" + if: steps.ssllib-cache.outputs.cache-hit !=3D 'true' + run: ${{inputs.libinstall}} + working-directory: ${{inputs.libname}} + - name: Run ldconfig + run: sudo ldconfig + - name: "OpenVPN: checkout" + uses: actions/checkout@...2998... # v6.0.2 + - name: "OpenVPN: autoreconf" + run: autoreconf -fvi + - name: "OpenVPN: configure" + run: | + ${{inputs.ovpnconfigureenv}} \ + ./configure --with-crypto-library=3D${{inputs.ovpnlibname}} ${{i= nputs.ovpnconfigureflags}} + - name: "OpenVPN: build" + run: make -j3 + - name: Ensure the build uses ${{inputs.libname}} + run: | + ./src/openvpn/openvpn --version + ./src/openvpn/openvpn --version | grep -q "library versions: ${{= inputs.ovpnlibdesc}}" + - name: "OpenVPN: configure checks" + run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc + - name: "OpenVPN: make check" + run: make -j3 check VERBOSE=3D1 diff --git a/renovate.json b/renovate.json index f9c62c4..809ac3f 100644 --- a/renovate.json +++ b/renovate.json @@ -40,7 +40,7 @@ "/^\\.github/workflows/.+\\.ya?ml$/" ], "matchStrings": [ - "versioning=3D(?.*?)\\n\\s*.*?_REPO:\\s*(?.*?)\\n\\s*.*?_VERSION:\\s*(?.*?)\\n" + "versioning=3D(?.*?)\\n\\s*ghrepo:\\s*(?.*?)\\n\\s*gitrepo:\\s*(?.*?)\\n" ], "datasourceTemplate": "github-tags" } -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1630?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3d89016ccae297cfa596897c11a518f1ffbe3dc8 Gerrit-Change-Number: 1630 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos --4Br628x+Wdw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos.

flichtenheld uploaded patch set #2 to this change.

<= p>View C= hange

GHA: Factor out building SSL libs to a reusable =
workflow

We amassed a lot of code duplication there. Make
it easi= er to track the differences between the libraries.

Change-Id: I3d890= 16ccae297cfa596897c11a518f1ffbe3dc8
Signed-off-by: Frank Lichtenheld <= ;frank@...2641...>
---
M .github/workflows/build.yaml
A .github= /workflows/test-ssllib.yml
M renovate.json
3 files changed, 155 inser= tions(+), 313 deletions(-)

git pull ssh://gerrit=
.openvpn.net:29418/openvpn refs/changes/30/1630/2
diff --git a/.git=
hub/workflows/build.yaml b/.github/workflows/build.yaml
ind= ex 365e72a..e4cb799 100644
--- a/.github/workflows/build.ya= ml
+++ b/.github/workflows/build.yaml
@@ -3= 04,324 +304,49 @@
!${{ github.workspace }}/out= /**/vcpkg_installed/**

libressl:
- strategy:
- fail-fast: false

- matrix:
- os: [ubuntu-24.04]
- ssllib: [libressl]
= - build: [ normal, asan ]<= /span>
- configureflags= : ["--with-openssl-engine=3Dno"]
- include:
- - build: asan
- cflags: "-fsanitize=3Daddress -fno-sanit= ize-recover=3Dall -fno-optimize-sibling-calls -fsanitize-address-use-after= -scope -fno-omit-frame-pointer -g -O1"
- ldflags: -fsanitize=3Daddress -fno-saniti= ze-recover=3Dall
- = cc: clang
- = - build: normal
- = cflags: "-O2 -g"
- ldflags: ""
- cc: gcc
-
- name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}} - ${= {matrix.ssllib}}"
= - runs-on: ${{matrix.os}}
- env:
- = CFLAGS: ${{ matrix.cflags }}
- LDFLAGS: ${{ matrix.ldflags }}
- CC: ${{matrix.cc}}
- UBSAN_OPTIONS: print_stacktrace=3D1+ uses: ./.github/workflow= s/test-ssllib.yml
+ = with:
+ libnam= e: libressl
+ ov= pnlibdesc: LibreSSL
# versioning=3Dsemver-coerced

- LIBRESSL_REPO: lib= ressl/portable
- L= IBRESSL_VERSION: v4.2.1
- LIBRESSL_INSTALL: /opt/libressl
+ ghrepo: libressl/portable
+ gitref: v4.2.1
+ libconfigure: "LIBRESSL_GIT_O= PTIONS=3D--no-single-branch ./autogen.sh && ./configure --prefix=3D= $LIBPREFIX"

- steps:
- - name: Install dependencies
- run: sudo apt update && sudo apt install -y = liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka= -dev python3-docutils libtool automake autoconf pkg-config libcap-ng-dev li= bnl-genl-3-dev
- -= name: Restore libressl from cache
- uses: actions/cache@...3010...
- id: libressl-cache
- with:
- path: ${{ env.LIBRESSL_INSTALL }}
- key: ${{ matri= x.os }}-libressl-${{matrix.build }}-${{ env.LIBRESSL_VERSION }}
<= span style=3D"color: hsl(0, 100%, 40%);">- - name: "libressl: che= ckout"

- if= : steps.libressl-cache.outputs.cache-hit !=3D 'true'
- uses: actions/checkout@...2924...= 98... # v6.0.2
- = with:
- path:= libressl
- re= pository: ${{ env.LIBRESSL_REPO }}
- ref: ${{ env.LIBRESSL_VERSION }}
- - name: "libressl: autogen.sh&= quot;
- if: step= s.libressl-cache.outputs.cache-hit !=3D 'true'
- env:
- LIBRESSL_GIT_OPTIONS: "--no-single-b= ranch"
- ru= n: ./autogen.sh
- = working-directory: libressl
- - name: "libressl: configure"
- if: steps.libressl-cache.outputs.ca= che-hit !=3D 'true'
- run: ./configure --prefix=3D${{ env.LIBRESSL_INSTALL }}
- working-directory: = libressl
- - name:= "libressl: make all"
- if: steps.libressl-cache.outputs.cache-hit !=3D 'true= '
- run: mak= e -j3
- working-= directory: libressl
- = - name: "libressl: make install"
- if: steps.libressl-cache.outputs.cache-hit= !=3D 'true'
- = run: sudo make install
- working-directory: libressl
- - name: "ldconfig"
- run: sudo ldconfig
- - name: Checkout OpenVPN

- uses: actions/chec= kout@...2998... # v6.0.2
- run: autoreconf -fvi
- - name: configure
- run: |
- OPENSSL_CFLAGS=3D"-I${{ env.LIBRESSL_INSTALL }}/includ= e" \
- OP= ENSSL_LIBS=3D"-L${{ env.LIBRESSL_INSTALL }}/lib -lssl -lcrypto" \=
- LDFLAGS=3D&= quot;-Wl,-rpath=3D${{ env.LIBRESSL_INSTALL }}/lib" \
- ./configure --with-crypto-lib= rary=3Dopenssl --enable-werror ${{matrix.configureflags}}
- - name: make all
- run: make -j3
- - name: Ensure the build uses Li= breSSL
- run: |<= /span>
- ./src/openvp= n/openvpn --version
- = ./src/openvpn/openvpn --version | grep -q "library versions: L= ibreSSL"
- - = name: configure checks
= - run: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_ser= ver_null.rc
- - na= me: make check
- = run: make -j3 check VERBOSE=3D1
-
- openssl:=
- strategy:<= br>- fail-fast: false=
- matrix:
- os: [ubuntu-24.04]
- ssllib: [openssl]
- build: [ normal, as= an ]
- configure= flags: ["--with-openssl-engine=3Dno"]
- include:
- - build: asan
- cflags: "-fsanitize=3Daddress -fno-= sanitize-recover=3Dall -fno-optimize-sibling-calls -fsanitize-address-use-= after-scope -fno-omit-frame-pointer -g -O1"
- ldflags: -fsanitize=3Daddress -fno-s= anitize-recover=3Dall
-= cc: clang
-= - build: normal
- cflags: "-O2 -g"
- ldflags: ""
- cc: gcc
-
- name: "${{matrix.cc}} ${{matrix.build}} - ${{matrix.os}= } - ${{matrix.ssllib}} - 4.0"
- runs-on: ${{matrix.os}}
- env:
- CFLAGS: ${{ matrix.cflags }}
- LDFLAGS: ${{ matrix.ldflags }}
- CC: ${{matrix.cc}}
- UBSAN_OPTIONS: print_stacktrace= =3D1
+ openssl4:
+ uses: ./.github/wor= kflows/test-ssllib.yml
+ l= ibname: openssl
+ = ovpnlibdesc: OpenSSL 4.
# versioning=3Dsemver-coer= ced
- OPENSSL_REPO= : openssl/openssl
- = OPENSSL_VERSION: openssl-4.0.0-beta1
- OPENSSL_INSTALL: /opt/openssl
-
- steps:
-= - name: Install dependencies
- run: sudo apt update && sudo apt install -y li= blzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang libcmocka-d= ev python3-docutils libtool automake autoconf pkg-config libcap-ng-dev libn= l-genl-3-dev
- - n= ame: Restore OpenSSL 4.0 from cache
- uses: actions/cache@...3010...
- id: openssl-cache
- with:
- path: ${{ env.OPENSSL_INSTALL }}
- key: ${{ matrix.= os }}-openssl-${{matrix.build }}-${{ env.OPENSSL_VERSION }}
- - name: "openssl: checkout= "

- if: ste= ps.openssl-cache.outputs.cache-hit !=3D 'true'
- uses: actions/checkout@...2998... = # v6.0.2
- with:=
- path: opens= sl
- repositor= y: ${{ env.OPENSSL_REPO }}
- ref: ${{ env.OPENSSL_VERSION }}
- - name: "openssl: configure"
- if: steps.openssl-c= ache.outputs.cache-hit !=3D 'true'
- run: ./Configure --prefix=3D${{ env.OPENSSL_I= NSTALL }} --libdir=3D${{ env.OPENSSL_INSTALL }}/lib --openssldir=3D${{ env.= OPENSSL_INSTALL }} -g
-= working-directory: openssl
- - name: "openssl: make all"
- if: steps.openssl-cache.outputs.= cache-hit !=3D 'true'
- run: make -j3
- working-directory: openssl
- - name: "openssl: make install"=
- if: steps.openssl-ca= che.outputs.cache-hit !=3D 'true'
- run: sudo make install
- working-directory: openssl
<= span style=3D"color: hsl(0, 100%, 40%);">- - name: "ldconfig"= ;

- run: sudo ld= config
- - name: C= heckout OpenVPN
- = uses: actions/checkout@...2998... # v6.0.2
- - name: autoconf
- run: autoreconf -fvi
- - name: configure
- run: |
- OPENSSL_CFLAGS=3D"-I${{ env.OPENS= SL_INSTALL }}/include" \
- OPENSSL_LIBS=3D"-L${{ env.OPENSSL_INSTALL }}/lib -ls= sl -lcrypto" \
- = LDFLAGS=3D"-Wl,-rpath=3D${{ env.OPENSSL_INSTALL }}/lib" \=
- ./configure= --with-crypto-library=3Dopenssl --enable-werror ${{matrix.configureflags}}=
- - name: make al= l
- run: make -j= 3
- - name: Ensure= the build uses Openssl
- run: |
- = ./src/openvpn/openvpn --version
- ./src/openvpn/openvpn --version | grep -q "li= brary versions: OpenSSL 4.0"
- - name: configure checks
- run: echo 'RUN_SUDO=3D"sudo -E"&= #39; >tests/t_server_null.rc
- - name: make check
- run: make -j3 check VERBOSE=3D1
+ ghrepo: openssl/openssl
<= span style=3D"color: hsl(120, 100%, 40%);">+ gitref: openssl-4.0.0-bet= a1

+ libconfigur= e: ./Configure --prefix=3D$LIBPREFIX --libdir=3D$LIBPREFIX/lib --openssldir= =3D$LIBPREFIX -g

mbedtls4:
<= span style=3D"color: hsl(0, 100%, 40%);">- strategy:

- fail-fast: false
- matrix:
- os: [ubuntu-24.04]
- ssllib: [mbedtls4]
- build: [ normal, asan ]=
- include:
<= span style=3D"color: hsl(0, 100%, 40%);">- - build: asan- cflags: "-fsan= itize=3Daddress -fno-sanitize-recover=3Dall -fno-optimize-sibling-calls -f= sanitize-address-use-after-scope -fno-omit-frame-pointer -g -O1"
- ldflags: -fsani= tize=3Daddress -fno-sanitize-recover=3Dall
- cc: clang
- - build: normal
- cflags: "-O2 -g"
<= span style=3D"color: hsl(0, 100%, 40%);">- ldflags: ""=

- cc: gcc
-
- name: "${{matrix.cc}} ${{matrix.bu= ild}} - ${{matrix.os}} - ${{matrix.ssllib}}"
- runs-on: ${{matrix.os}}
- env:
- CFLAGS: ${{ matrix.cflags }}
- LDFLAGS: ${{ matrix.ldflags }}
- CC: ${{matrix.cc}}
- UBSAN_OPTIONS: pr= int_stacktrace=3D1
- = PKG_CONFIG_PATH: /opt/mbedtls4/lib/pkgconfig
+ uses: ./.github/workflows/test-ssllib.yml
+ with:
<= span style=3D"color: hsl(120, 100%, 40%);">+ libname: mbedtls
+ ovpnlibname: mbedtls
+ ovpnlibdesc: mb= ed TLS 4.
# versioning=3Dsemver-coerced
- MBEDTLS_REPO: Mbed-TLS/mbedt= ls

- MBEDTLS_VERSI= ON: v4.0.0
- MBEDT= LS_INSTALL: /opt/mbedtls4
-
- steps:=
- - name: Install depend= encies
- run: su= do apt update && sudo apt install -y liblzo2-dev libpam0g-dev liblz= 4-dev linux-libc-dev man2html clang libcmocka-dev python3-docutils python3-= jinja2 python3-jsonschema libtool automake autoconf pkg-config libcap-ng-de= v libnl-genl-3-dev
- = - name: Restore mbed TLS from cache
- uses: actions/cache@...3010...
- id: mbedtls-cache
- with:

- path: ${{ env.MBEDTLS_INSTALL }}<= /span>
- key: ${{ mat= rix.os }}-mbedtls-${{matrix.build }}-${{ env.MBEDTLS_VERSION }}
<= span style=3D"color: hsl(0, 100%, 40%);">- - name: "mbedtls: chec= kout"

- if:= steps.mbedtls-cache.outputs.cache-hit !=3D 'true'
- uses: actions/checkout@...3022...= ... # v6.0.2
- w= ith:
- path: m= bedtls
- submo= dules: recursive
- = repository: ${{ env.MBEDTLS_REPO }}
- ref: ${{ env.MBEDTLS_VERSION }}
- - uses: lukka/get-cmake@...3007...= 9... # v4.2.3

- - = name: "mbedtls: cmake"
- if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true= '
- run: cma= ke -B build -DCMAKE_INSTALL_PREFIX=3D${{ env.MBEDTLS_INSTAL }}
- working-directory: mbedtls=

- - name: "m= bedtls: cmake --build"
- if: steps.mbedtls-cache.outputs.cache-hit !=3D 'true'=
- run: cmake --= build build
- wo= rking-directory: mbedtls
- if: steps.mbedtls-cache.outputs.cac= he-hit !=3D 'true'
- run: sudo cmake --install build
- working-directory: mbedtls
- - name: Checkout OpenVPN- uses: actions/checkout= @...2998... # v6.0.2
- = - name: autoconf
-= run: autoreconf -fvi
- - name: configure
- run: ./configure --with-crypto-library=3Dmbedtls --enable-= werror
- - name: m= ake all
- run: m= ake -j3
- - name: = Ensure the build uses mbed TLS ${{ env.MBEDTLS_VERSION }}
- run: |
- ./src/openvpn/openvpn --version
- ./src/openvpn/op= envpn --version | grep -q "library versions: mbed TLS 4."<= br>- - name: configure check= s
- run: echo &#= 39;RUN_SUDO=3D"sudo -E"' >tests/t_server_null.rc- - name: make check=
- run: make -j3 check = VERBOSE=3D1
+ gh= repo: Mbed-TLS/mbedtls
+ libconfigure: cmake -B build -DCMAKE_INSTALL_PREFIX=3D$LIBPREFIX<= /span>
+ libmake: cmake= --build build
+ = libinstall: sudo cmake --install build
+ ovpnconfigureenv: PKG_CONFIG_PATH=3D$LIBPREFIX/li= b/pkgconfig

aws-lc:
- strategy:
- fail-fast: false
- matrix:
- os: [ubuntu-24.04]
- ssllib: [ awslc ]
- build: [ normal, asan ]
- include:

- - build: asan
- cflags: "-fsanitize=3D= address -fno-sanitize-recover=3Dall -fno-optimize-sibling-calls -fsanitize= -address-use-after-scope -fno-omit-frame-pointer -g -O1"
- ldflags: -fsanitize=3Da= ddress -fno-sanitize-recover=3Dall

- cc: clang
- cxx: clang++
- - build: normal
- cflags: "-O2 -g"
- ldflags: ""
- cc: gcc=
- cxx: c++<= br>-
- name: "${{matrix.cc}} ${{matrix.build}} -= ${{matrix.os}} - ${{matrix.ssllib}}"
- runs-on: ${{matrix.os}}
- env:
- CFLAGS: ${{ matrix.cflags }}
- LDFLAGS: ${{ matrix.ldflags }}
<= span style=3D"color: hsl(0, 100%, 40%);">- CC: ${{matrix.cc}}
- CXX: ${{matrix.cxx}}
- UBSAN_OPTIONS: prin= t_stacktrace=3D1
- = AWS_LC_INSTALL: /opt/aws-lc
+ uses: ./.github/workflows/test-ssllib.yml
+ with:
+ libname: aws-lc
+ ovpnlibdesc: AWS-LC
= # versioning=3Dsemver-coerced
- AWS_LC_REPO: aws/aws-lc
- AWS_LC_VERSION: v1.70.0
-
- steps:
- -= name: Install dependencies
- run: sudo apt update && sudo apt install -y gcc golan= g make liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html clang li= bcmocka-dev python3-docutils python3-jinja2 python3-jsonschema libtool auto= make autoconf pkg-config libcap-ng-dev libnl-genl-3-dev
- - name: Restore AWS-LC from cache
- uses: actions/c= ache@...3010...
- = id: aws-lc-cache
- = with:
- p= ath: ${{ env.AWS_LC_INSTALL }}
- key: ${{ matrix.os }}-aws-lc-${{matrix.build }}-${{ env.= AWS_LC_VERSION }}
- = - name: "AWS-LC: checkout"
- if: steps.aws-lc-cache.outputs.cache-hit !=3D '= ;true'
- use= s: actions/checkout@...2998... # v6.0.2
- with:
- path: aws-lc
- repository: ${{ env.AWS_LC_REPO }}
- ref: ${{ env.AWS_LC_VERSION }}<= /span>
- - uses: lukka/ge= t-cmake@...2999... # v4.2.3
- - name: "AWS-LC: build"
- if: steps.aws-lc-cache.outputs.cache-hit != =3D 'true'
- = run: |
- = mkdir build
- = cd build
- cma= ke -GNinja -DCMAKE_BUILD_TYPE=3DRelease -DCMAKE_INSTALL_PREFIX=3D"${{ = env.AWS_LC_INSTALL }}" -DBUILD_SHARED_LIBS=3D1 ../
- ninja install
- working-directory: aws-lc
- - name: Checkout Open= VPN
- uses: acti= ons/checkout@...2998... # v6.0.2
- - name: autoconf
- run: autoreconf -fvi
- - name: configure with AWS-LC
- run: |
- OPENSSL_CFLAGS=3D"-I${{ env.AWS_LC= _INSTALL }}/include" \
- OPENSSL_LIBS=3D"-L${{ env.AWS_LC_INSTALL }}/lib -lssl = -lcrypto" \
- = LDFLAGS=3D"-Wl,-rpath=3D${{ env.AWS_LC_INSTALL }}/lib" \
- ./configure --w= ith-crypto-library=3Dopenssl
- - name: make all
- run: make -j3
- - name: Ensure the build uses AWS-LC
- run: |
- ./src/openvpn/openvpn --version
<= span style=3D"color: hsl(0, 100%, 40%);">- ./src/openvpn/openvpn -= -version | grep -q "library versions: AWS-LC"

- - name: configure checks
= - run: echo 'RUN_SUDO= =3D"sudo -E"' >tests/t_server_null.rc
- - name: make check
- run: make -j3 check VERBOSE=3D1=
+ ghrepo: aws/a= ws-lc
+ gitref: = v1.70.0
+ libcon= figure: cmake -B build -GNinja -DCMAKE_BUILD_TYPE=3DRelease -DCMAKE_INSTALL= _PREFIX=3D"$LIBPREFIX" -DBUILD_SHARED_LIBS=3D1
+ libmake: cmake --build build
+ libinstall: sudo = cmake --install build
+ # not ready for --enable-werror
+ ovpnconfigureflags:
diff --git a/= .github/workflows/test-ssllib.yml b/.github/workflows/test-ssllib.yml
new file mode 100644
index 0000000..4e37fef
--- /dev/null
+++ b/.github/workflows/test-ssll= ib.yml
@@ -0,0 +1,117 @@
+name: test_ssllib
+
+= on:
+ workflow_call:=
+ inputs:<= br>+ libname:
+ required: true
+ type: string+ ovpnlibname:+ type: string+ default: openssl
+ ovpnlibdesc:
+ required: true
+ type: string<= /span>
+ ghrepo:=
+ required: true
+ type: string
+ gitref:+ required: true
+ type: string
+ libconfigure:
+ required: true
+ type: string<= /span>
+ libmake:
+ type: string
+ default: "m= ake -j3"
+ = libinstall:
+ = type: string
+ = default: "sudo make install"
+ ovpnconfigureenv:
+ type: string
+ default: >-
+ OPENSSL_CFLAGS=3D"-I$LIBPREFIX/i= nclude"
+ = OPENSSL_LIBS=3D"-L$LIBPREFIX/lib -lssl -lcrypto"
+ LDFLAGS=3D"-Wl,-rp= ath=3D$LIBPREFIX/lib"

+ ovpnconfigureflags:
+ type: string
+ default: --enable-werror --with-openssl-engine=3Dno
+
+jobs:
+ test_ssllib:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ubuntu-24.04]
+ build: [normal, asan]
+ include:
+ - build: asan
+ cflags: "-fsanitize=3Daddress -fn= o-sanitize-recover=3Dall -fno-optimize-sibling-calls -fsanitize-address-us= e-after-scope -fno-omit-frame-pointer -g -O1"
+ ldflags: -fsanitize=3Daddress -f= no-sanitize-recover=3Dall
+ cc: clang
+ cxx: clang++
+ - build: normal
+ cflags: "-O2 -g"
+ ldflags: ""
+ cc: gcc
+ cxx: g++
+
+ name: "${{matrix.cc}} ${{matrix.= build}} - ${{matrix.os}} - ${{inputs.libname}}"
+ runs-on: ${{matrix.os}}
+ env:

+ CFLAGS: ${{matrix.cflags}}
<= span style=3D"color: hsl(120, 100%, 40%);">+ LDFLAGS: ${{matrix.ldflag= s}}

+ CC: ${{mat= rix.cc}}
+ CXX: = ${{matrix.cxx}}
+ = UBSAN_OPTIONS: print_stacktrace=3D1
+ LIBPREFIX: /opt/${{inputs.libname}}
+

+ steps:
+ - name: Install dependencies
+ run: sudo apt update && sudo apt= install -y liblzo2-dev libpam0g-dev liblz4-dev linux-libc-dev man2html cla= ng libcmocka-dev python3-docutils libtool automake autoconf pkg-config libc= ap-ng-dev libnl-genl-3-dev
+ - name: Restore ${{inputs.libname}} from cache
+ uses: actions/cache@...3023...= ...

+ id: ssll= ib-cache
+ wit= h:
+ path: $= {{env.LIBPREFIX}}
+ = key: ${{matrix.os}}-${{inputs.libname}}-${{matrix.build }}-${{input= s.gitref}}
+ - n= ame: "${{inputs.libname}}: checkout"
+ if: steps.ssllib-cache.outputs.cache-hit= !=3D 'true'
= + uses: actions/checkout@...2998... # v6.0.2
+ with:
+ submodules: recursive
+ path: ${{inputs.libname}}=

+ repositor= y: ${{inputs.ghrepo}}
+ ref: ${{inputs.gitref}}
+ - name: "${{inputs.libname}}: configure"
+ if: steps.ssll= ib-cache.outputs.cache-hit !=3D 'true'
+ run: ${{inputs.libconfigure}}
= + working-directory: ${{= inputs.libname}}
+ = - name: "${{inputs.libname}}: build"
+ if: steps.ssllib-cache.outputs.cache-= hit !=3D 'true'
+ run: ${{inputs.libmake}}
+ working-directory: ${{inputs.libname}}
<= span style=3D"color: hsl(120, 100%, 40%);">+ - name: "${{inputs.l= ibname}}: install"

+ if: steps.ssllib-cache.outputs.cache-hit !=3D 'true'
+ run: ${{inputs= .libinstall}}
+ = working-directory: ${{inputs.libname}}
+ - name: Run ldconfig
+ run: sudo ldconfig
+ - name: "OpenVPN: checkout&qu= ot;
+ uses: ac= tions/checkout@...2998... # v6.0.2
+ - name: "OpenVPN: autoreconf"
+ run: autoreconf -fvi
+ - name: "OpenV= PN: configure"
+= run: |
+ = ${{inputs.ovpnconfigureenv}} \
+ ./configure --with-crypto-library=3D${{inputs.ovp= nlibname}} ${{inputs.ovpnconfigureflags}}
+ - name: "OpenVPN: build"
+ run: make -j3

= + - name: Ensure the build= uses ${{inputs.libname}}
+ run: |
= + ./src/openvpn/openvpn --version
+ ./src/openvpn/openvpn --version | grep -q = "library versions: ${{inputs.ovpnlibdesc}}"
+ - name: "OpenVPN: configure ch= ecks"
+ r= un: echo 'RUN_SUDO=3D"sudo -E"' >tests/t_server_null.r= c
+ - name: &quo= t;OpenVPN: make check"
+ run: make -j3 check VERBOSE=3D1
diff --git = a/renovate.json b/renovate.json
index f9c62c4..809ac3f 1006= 44
--- a/renovate.json
+++ b/renovate.json<= /span>
@@ -40,7 +40,7 @@
"/^= \\.github/workflows/.+\\.ya?ml$/"
],
"matchStrings": [
- "versioning=3D(?<ve= rsioning>.*?)\\n\\s*.*?_REPO:\\s*(?<depName>.*?)\\n\\s*.*?_VERSION= :\\s*(?<currentValue>.*?)\\n"
+ "versioning=3D(?<versioning>= ;.*?)\\n\\s*ghrepo:\\s*(?<depName>.*?)\\n\\s*gitrepo:\\s*(?<curren= tValue>.*?)\\n"
],
= "datasourceTemplate": "github-tags" }

To view, visit change 1630. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3d89016ccae297cfa596897c11a= 518f1ffbe3dc8
Gerrit-Change-Number: 1630
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
= --4Br628x+Wdw=--