From: "cron2 (Code Review)" Date: Tue, 7 Apr 2026 10:56:19 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <0977e46887b56189e7a5ed47bae2a1e6e6d0411e-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="eAQOnwdVkW0="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: test_buffer: Add test for buf_null_terminate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --eAQOnwdVkW0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1580?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by cron2 Change subject: test_buffer: Add test for buf_null_terminate ...................................................................... test_buffer: Add test for buf_null_terminate Change-Id: I01683153a68e1809a4d7ab455eb346f53780e219 Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1580 Message-Id: <20260407095044.28528-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 532.html Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_buffer.c 1 file changed, 27 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/80/1580/2 diff --git a/tests/unit_tests/openvpn/test_buffer.c b/tests/unit_tests/open= vpn/test_buffer.c index 5f43e0d..326de40 100644 --- a/tests/unit_tests/openvpn/test_buffer.c +++ b/tests/unit_tests/openvpn/test_buffer.c @@ -460,6 +460,32 @@ gc_free(&gc); } +void +test_buffer_null_terminate(void **state) +{ + struct gc_arena gc =3D gc_new(); + + struct buffer buf =3D alloc_buf_gc(5, &gc); + const char test1[] =3D "1234"; + const char test2[] =3D "12345"; + assert_true(buf_write(&buf, test1, sizeof(test1))); + assert_string_equal(BSTR(&buf), "1234"); + buf_null_terminate(&buf); + assert_string_equal(BSTR(&buf), "1234"); + + assert_true(buf_inc_len(&buf, -1)); + assert_true(buf_write_u8(&buf, '5')); + assert_memory_equal(BPTR(&buf), test2, strlen(test2)); + buf_null_terminate(&buf); + assert_string_equal(BSTR(&buf), "1234"); + + struct buffer buf2; + CLEAR(buf2); + buf_null_terminate(&buf2); + + gc_free(&gc); +} + /* for building long texts */ #define A_TIMES_256 "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAO" @@ -540,6 +566,7 @@ cmocka_unit_test(test_snprintf), cmocka_unit_test(test_checked_snprintf), cmocka_unit_test(test_buffer_chomp), + cmocka_unit_test(test_buffer_null_terminate), cmocka_unit_test(test_buffer_parse) }; -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1580?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I01683153a68e1809a4d7ab455eb346f53780e219 Gerrit-Change-Number: 1580 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --eAQOnwdVkW0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by cron2

test_buffer: Add test for buf_null_=
terminate

Change-Id: I01683153a68e1809a4d7ab455eb346f53780e219
Si= gned-off-by: Frank Lichtenheld <frank@...2641...>
Acked-by: Gert D= oering <gert@...1296...>
Gerrit URL: https://gerrit.openvpn.net/c/= openvpn/+/1580
Message-Id: <20260407095044.28528-1-gert@...1296...>= ;
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/= msg36532.html
Signed-off-by: Gert Doering <gert@...1296...>
---=
M tests/unit_tests/openvpn/test_buffer.c
1 file changed, 27 insertio= ns(+), 0 deletions(-)

git pull ssh://gerrit.open=
vpn.net:29418/openvpn refs/changes/80/1580/2
diff --git a/tests/uni=
t_tests/openvpn/test_buffer.c b/tests/unit_tests/openvpn/test_buffer.c
index 5f43e0d..326de40 100644
--- a/tests/unit_= tests/openvpn/test_buffer.c
+++ b/tests/unit_tests/openvpn/= test_buffer.c
@@ -460,6 +460,32 @@
gc_= free(&gc);
}

+void
+test_buffer_null_terminate(void **state)
+{

+ struct gc_arena gc =3D gc_new();
+
+ struct buffer buf =3D alloc_buf_gc(5, &gc);
+ const char test1[] = =3D "1234";
+ const char test2[] =3D "12345";
+ assert_true(buf_write(&buf, test1, size= of(test1)));
+ ass= ert_string_equal(BSTR(&buf), "1234");
+ buf_null_terminate(&buf);<= br>+ assert_string_equal(BST= R(&buf), "1234");
+
+ ass= ert_true(buf_inc_len(&buf, -1));
+ assert_true(buf_write_u8(&buf, '5'));
+ assert_memory_equal(= BPTR(&buf), test2, strlen(test2));
+ buf_null_terminate(&buf);
+ assert_string_equal(BSTR(&buf), &= quot;1234");
+
+ struct buffer buf= 2;
+ CLEAR(buf2);<= /span>
+ buf_null_termina= te(&buf2);
+
+ gc_free(&gc);
+}
+
/* for building long t= exts */
#define A_TIMES_256 "AAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= AAAAAAO"

@@ -540,6 +566,7 @@<= br> cmocka_unit_test(test_snprintf),
= cmocka_unit_test(test_checked_snprintf),
cmocka_u= nit_test(test_buffer_chomp),
+ cmocka_unit_test(test_buffer_null_terminate),
cmocka_unit_test(test_buffer_parse)

};


To view, visit change 1580= . To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I01683153a68e1809a4d7ab455eb= 346f53780e219
Gerrit-Change-Number: 1580
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --eAQOnwdVkW0=--