From: Lyude Paul Subject: Re: [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode Date: Fri, 17 Aug 2018 16:43:22 -0400 Message-ID: <09af2df770d43203254b0c165443cc3decc645df.camel@redhat.com> References: <1526523706-12226-1-git-send-email-manasi.d.navare@intel.com> <20180817204049.GC5643@intel.com> Reply-To: lyude@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk0-f196.google.com (mail-qk0-f196.google.com [209.85.220.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3CD4D6E6DE for ; Fri, 17 Aug 2018 20:43:24 +0000 (UTC) Received: by mail-qk0-f196.google.com with SMTP id p71-v6so1911257qka.9 for ; Fri, 17 Aug 2018 13:43:24 -0700 (PDT) In-Reply-To: <20180817204049.GC5643@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE4LTA4LTE3IGF0IDEzOjQwIC0wNzAwLCBNYW5hc2kgTmF2YXJlIHdyb3RlOgo+ IE9uIEZyaSwgQXVnIDE3LCAyMDE4IGF0IDA0OjMyOjA5UE0gLTA0MDAsIEx5dWRlIFBhdWwgd3Jv dGU6Cj4gPiBBZnRlciByZWFkaW5nIHRoZSBkaXNjdXNzaW9uIHNvIGZhciBvbiB0aGlzIHBhdGNo LCB0aGlzIHNvdW5kcyBjb3JyZWN0ISBPbmUKPiA+IG5pdAo+ID4gcGljayBiZWxvdyB0aG91Z2g6 Cj4gPiAKPiA+IE9uIFdlZCwgMjAxOC0wNS0xNiBhdCAxOToyMSAtMDcwMCwgTWFuYXNpIE5hdmFy ZSB3cm90ZToKPiA+ID4gVGhpcyBwYXRjaCBmaXhlcyB0aGUgb3JpZ2luYWwgY29tbWl0IGMwY2Zi MTBkOWUxZGU0OSAoImRybS9pOTE1L2VkcDoKPiA+ID4gRG8gbm90IGRvIGxpbmsgdHJhaW5pbmcg ZmFsbGJhY2sgb3IgcHJ1bmUgbW9kZXMgb24gRURQIikgdGhhdCBjYXVzZXMKPiA+ID4gYSBibGFu ayBzY3JlZW4gaW4gY2FzZSBvZiBjZXJ0YWluIGVEUCBwYW5lbHMgKEVnOiBzZWVuIG9uIERlbGwg WFBTMTMgOTM1MCkKPiA+ID4gd2hlcmUgZmlyc3QgbGluayB0cmFpbmluZyBmYWlscyBhbmQgYSBy ZXRyYWluaW5nIGlzIHJlcXVpcmVkIGJ5IGZhbGxpbmcKPiA+ID4gYmFjayB0byBsb3dlciBsaW5r IHJhdGUvbGFuZSBjb3VudC4KPiA+ID4gSW4gY2FzZSBvZiBzb21lIHBhbmVscyB0aGV5IGFkdmVy dGlzZSBoaWdoZXIgbGluayByYXRlL2xhbmUgY291bnQKPiA+ID4gdGhhbiB3aGF0cyByZXF1aXJl ZCBmb3Igc3VwcG9ydGluZyB0aGUgcGFuZWwncyBuYXRpdmUgbW9kZS4KPiA+ID4gQnV0IHdlIGFs d2F5cyBsaW5rIHRyYWluIGF0IGhpZ2hlc3QgbGluayByYXRlL2xhbmUgY291bnQgZm9yIGVEUAo+ ID4gPiBhbmQgaWYgdGhhdCBmYWlscyB3ZSBjYW4gc3RpbGwgZmFsbGJhY2sgdG8gbG93ZXIgbGlu ayByYXRlL2xhbmUgY291bnQKPiA+ID4gYXMgbG9uZyBhcyB0aGUgZmFsbGJhY2sgbGluayBCVyBz dGlsbCBmaXRzIHRoZSBuYXRpdmUgbW9kZSB0byBhdm9pZAo+ID4gPiBwcnVuaW5nIHRoZSBwYW5l bCdzIG5hdGl2ZSBtb2RlIHlldCByZXRyYWluaW5nIGF0IGZhbGxiYWNrIHZhbHVlcwo+ID4gPiB0 byByZWNvdmVyIGZyb20gYSBibGFuayBzY3JlZW4uCj4gPiA+IAo+ID4gPiBDYzogQ2xpbnRvbiBU YXlsb3IgPGNsaW50b24uYS50YXlsb3JAaW50ZWwuY29tPgo+ID4gPiBDYzogSmFuaSBOaWt1bGEg PGphbmkubmlrdWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gQ2M6IFZpbGxlIFN5cmphbGEgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiBDYzogRGFuaWVsIFZldHRlciA8ZGFu aWVsLnZldHRlckBmZndsbC5jaD4KPiA+ID4gQ2M6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVt YXJjaGlAaW50ZWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBNYW5hc2kgTmF2YXJlIDxtYW5h c2kuZC5uYXZhcmVAaW50ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2RwLmMgICAgICAgICAgICAgICB8IDI1Cj4gPiA+ICsrKysrKysrKysrKysrKysr KysrKysrKysKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2xpbmtfdHJhaW5p bmcuYyB8IDI2ICsrKysrKysrKy0tLS0tLS0tLS0tLS0KPiA+ID4gLS0tLQo+ID4gPiAgMiBmaWxl cyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+IGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBpbmRleCAyY2M1ODU5Ni4uN2Y3MjAy YSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+IEBAIC0zODcsNiAr Mzg3LDIxIEBAIHN0YXRpYyBib29sIGludGVsX2RwX2xpbmtfcGFyYW1zX3ZhbGlkKHN0cnVjdAo+ ID4gPiBpbnRlbF9kcAo+ID4gPiAqaW50ZWxfZHAsIGludCBsaW5rX3JhdGUsCj4gPiA+ICAJcmV0 dXJuIHRydWU7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gK3N0YXRpYyBib29sIGludGVsX2RwX2Nh bl9saW5rX3RyYWluX2ZhbGxiYWNrX2Zvcl9lZHAoc3RydWN0IGludGVsX2RwCj4gPiA+ICppbnRl bF9kcCwKPiA+ID4gKwkJCQkJCSAgICAgaW50IGxpbmtfcmF0ZSwKPiA+ID4gKwkJCQkJCSAgICAg dWludDhfdCBsYW5lX2NvdW50KQo+ID4gPiArewo+ID4gPiArCXN0cnVjdCBkcm1fZGlzcGxheV9t b2RlICpmaXhlZF9tb2RlID0gaW50ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3Rvci0KPiA+ID4gPiBw YW5lbC5maXhlZF9tb2RlOwo+ID4gPiAKPiA+ID4gKwlpbnQgbW9kZV9yYXRlLCBtYXhfcmF0ZTsK PiA+ID4gKwo+ID4gPiArCW1vZGVfcmF0ZSA9IGludGVsX2RwX2xpbmtfcmVxdWlyZWQoZml4ZWRf bW9kZS0+Y2xvY2ssIDE4KTsKPiA+ID4gKwltYXhfcmF0ZSA9IGludGVsX2RwX21heF9kYXRhX3Jh dGUobGlua19yYXRlLCBsYW5lX2NvdW50KTsKPiA+ID4gKwlpZiAobW9kZV9yYXRlID4gbWF4X3Jh dGUpCj4gPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+ID4gKwo+ID4gPiArCXJldHVybiB0cnVlOwo+ ID4gPiArfQo+ID4gPiArCj4gPiA+ICBpbnQgaW50ZWxfZHBfZ2V0X2xpbmtfdHJhaW5fZmFsbGJh Y2tfdmFsdWVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gPiA+ICAJCQkJCSAgICBpbnQg bGlua19yYXRlLCB1aW50OF90IGxhbmVfY291bnQpCj4gPiA+ICB7Cj4gPiA+IEBAIC0zOTYsOSAr NDExLDE5IEBAIGludCBpbnRlbF9kcF9nZXRfbGlua190cmFpbl9mYWxsYmFja192YWx1ZXMoc3Ry dWN0Cj4gPiA+IGludGVsX2RwICppbnRlbF9kcCwKPiA+ID4gIAkJCQkgICAgaW50ZWxfZHAtPm51 bV9jb21tb25fcmF0ZXMsCj4gPiA+ICAJCQkJICAgIGxpbmtfcmF0ZSk7Cj4gPiA+ICAJaWYgKGlu ZGV4ID4gMCkgewo+ID4gPiArCQlpZiAoaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSAmJgo+ID4g PiArCQkgICAgIWludGVsX2RwX2Nhbl9saW5rX3RyYWluX2ZhbGxiYWNrX2Zvcl9lZHAoaW50ZWxf ZHAsCj4gPiA+ICsJCQkJCQkJICAgICBpbnRlbF9kcC0KPiA+ID4gPiBjb21tb25fcmF0ZXNbaW5k ZXgtMV0sCj4gPiA+IAo+ID4gPiArCQkJCQkJCSAgICAgIGxhbmVfY291bnQpKQo+ID4gPiArCQkJ cmV0dXJuIC0xOwo+ID4gPiAgCQlpbnRlbF9kcC0+bWF4X2xpbmtfcmF0ZSA9IGludGVsX2RwLT5j b21tb25fcmF0ZXNbaW5kZXggLSAxXTsKPiA+ID4gIAkJaW50ZWxfZHAtPm1heF9saW5rX2xhbmVf Y291bnQgPSBsYW5lX2NvdW50Owo+ID4gPiAgCX0gZWxzZSBpZiAobGFuZV9jb3VudCA+IDEpIHsK PiA+ID4gKwkJaWYgKGludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkgJiYKPiA+ID4gKwkJICAgICFp bnRlbF9kcF9jYW5fbGlua190cmFpbl9mYWxsYmFja19mb3JfZWRwKGludGVsX2RwLAo+ID4gPiAr CQkJCQkJCSAgICAgIGludGVsX2RwX21heF9jb21tbwo+ID4gPiBuX3JhdGUoaW50ZWxfZHApLAo+ ID4gPiArCQkJCQkJCSAgICAgIGxhbmVfY291bnQgPj4gMSkpCj4gPiA+ICsJCQlyZXR1cm4gLTE7 Cj4gPiAKPiA+IFRoZSBhcmd1bWVudHMgeW91IHBhc3MgdG8gaW50ZWxfZHBfY2FuX2xpbmtfdHJh aW5fZmFsbGJhY2tfZm9yX2VkcCgpIGFyZSB0aGUKPiA+IHNhbWUgb25lcyB0aGF0IHlvdSBhc3Np Z24gdG8gaW50ZWxfZHAtPm1heF9saW5rX3JhdGUgYW5kIGludGVsX2RwLQo+ID4gPiBtYXhfbGlu a19sYW5lX2NvdW50LCB3aHkgbm90IGp1c3Qgc2V0IHRob3NlIGxhdHRlciB0d28gZmlyc3QgdGhl biBwYXNzCj4gPiA+IHRoZW0gdG8KPiA+IAo+ID4gaW50ZWxfZHBfY2FuX2xpbmtfdHJhaW5fZmFs bGJhY2tfZm9yX2VkcCgpIGFmdGVyd2FyZHM/Cj4gCj4gQWN0dWFsbHkgSSBoYWQgdGhvdWdodCBv ZiB0aGF0LiBIb3dldmVyIGlmIHRoZQo+IGludGVsX2RwX2Nhbl9saW5rX3RyYWluX2ZhbGxiYWNr X2Zvcl9lZHAoKQo+IHJldHVybnMgZmFsc2UgdGhlbiB3ZSBkb250IHdhbm5hIHVwZGF0ZSB0aGUg aW50ZWxfZHAtPm1heF9saW5rX3JhdGUgYW5kCj4gbGFuZV9jb3VudCB0bwo+IHJlZHVjZWQgZmFs bGJhY2sgdmFsdWVzLgpBaGhoLCB0aGF0IG1ha2VzIHNlbnNlISBJZ25vcmUgdGhhdCBuaXRwaWNr IHRoZW4gOikKCj4gCj4gVGhlIG90aGVyIGNvbmNlcm5zIG1lbnRpb25lZCBvbiB0aGlzIHBhdGNo IHdlcmUgYWJvdXQgY2hlY2tpbmcgdGhlbSBhZ2FpbnN0Cj4gZG93bmNsb2NrIG1vZGUKPiB3aGlj aCB3aWxsIGJlIHdpdGggbG93ZXIgcmVmcmVzaCByYXRlIGhlbmNlIG1pZ2h0IGZpdCB0aGUgcmVk dWNlZCBCVy4gQnV0Cj4gY3VycmVudGx5IHRoZQo+IGRvd25jbG9jayBtb2RlIGlzIGFzc2lnbmVk IG9ubHkgYXMgcGFydCBvZiBpbnRlbF9kcF9kcnJzX3N1cHBvcnQoKSBzbyBmaXJzdCB3ZQo+IHdv dWxkCj4gbmVlZCB0byBtYXkgYmUgZmluZCB0aGF0IGluIGVkcF9pbml0IGFuZCBzYXZlIGl0IGFz IHBhcnQgb2YgaW50ZWxfZHAgb3IKPiBzb21ldGhpbmcuCj4gQXMgd2VsbCBhcyB0ZXN0aW5nIGFn YWluc3QgYWx0ZXJuYXRlIG1vZGUuCj4gQW55IHRob3VnaHRzIG9uIHRoYXQ/CgpUaGF0IHNvdW5k cyBmaW5lIHRvIG1lISBJdCBpcyBwcm9iYWJseSBhIGJpdCBzYWZlciB0aGVuIGp1c3QgYmxpbmRs eSBkb3duZ3JhZGluZwp0aGUgbGluawoKPiAKPiBNYW5hc2kKPiAKPiA+ID4gIAkJaW50ZWxfZHAt Pm1heF9saW5rX3JhdGUgPSBpbnRlbF9kcF9tYXhfY29tbW9uX3JhdGUoaW50ZWxfZHApOwo+ID4g PiAgCQlpbnRlbF9kcC0+bWF4X2xpbmtfbGFuZV9jb3VudCA9IGxhbmVfY291bnQgPj4gMTsKPiA+ ID4gIAl9IGVsc2Ugewo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHBfbGlua190cmFpbmluZy5jCj4gPiA+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHBfbGlua190cmFpbmluZy5jCj4gPiA+IGluZGV4IDNmY2FhOTguLjY2NzM5NzUgMTAwNjQ0Cj4g PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwX2xpbmtfdHJhaW5pbmcuYwo+ ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcF9saW5rX3RyYWluaW5nLmMK PiA+ID4gQEAgLTMzNSwyMiArMzM1LDE0IEBAIGludGVsX2RwX3N0YXJ0X2xpbmtfdHJhaW4oc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+ID4gIAlyZXR1cm47Cj4gPiA+ICAKPiA+ID4gICBm YWlsdXJlX2hhbmRsaW5nOgo+ID4gPiAtCS8qIERvbnQgZmFsbGJhY2sgYW5kIHBydW5lIG1vZGVz IGlmIGl0cyBlRFAgKi8KPiA+ID4gLQlpZiAoIWludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkpIHsK PiA+ID4gLQkJRFJNX0RFQlVHX0tNUygiW0NPTk5FQ1RPUjolZDolc10gTGluayBUcmFpbmluZyBm YWlsZWQgYXQgbGluawo+ID4gPiByYXRlID0gJWQsIGxhbmUgY291bnQgPSAlZCIsCj4gPiA+IC0J CQkgICAgICBpbnRlbF9jb25uZWN0b3ItPmJhc2UuYmFzZS5pZCwKPiA+ID4gLQkJCSAgICAgIGlu dGVsX2Nvbm5lY3Rvci0+YmFzZS5uYW1lLAo+ID4gPiAtCQkJICAgICAgaW50ZWxfZHAtPmxpbmtf cmF0ZSwgaW50ZWxfZHAtPmxhbmVfY291bnQpOwo+ID4gPiAtCQlpZiAoIWludGVsX2RwX2dldF9s aW5rX3RyYWluX2ZhbGxiYWNrX3ZhbHVlcyhpbnRlbF9kcCwKPiA+ID4gLQkJCQkJCQkgICAgIGlu dGVsX2RwLQo+ID4gPiA+IGxpbmtfcmF0ZSwKPiA+ID4gCj4gPiA+IC0JCQkJCQkJICAgICBpbnRl bF9kcC0KPiA+ID4gPiBsYW5lX2NvdW50KSkKPiA+ID4gCj4gPiA+IC0JCQkvKiBTY2hlZHVsZSBh IEhvdHBsdWcgVWV2ZW50IHRvIHVzZXJzcGFjZSB0byBzdGFydAo+ID4gPiBtb2Rlc2V0ICovCj4g PiA+IC0JCQlzY2hlZHVsZV93b3JrKCZpbnRlbF9jb25uZWN0b3ItPm1vZGVzZXRfcmV0cnlfd29y ayk7Cj4gPiA+IC0JfSBlbHNlIHsKPiA+ID4gLQkJRFJNX0VSUk9SKCJbQ09OTkVDVE9SOiVkOiVz XSBMaW5rIFRyYWluaW5nIGZhaWxlZCBhdCBsaW5rIHJhdGUgPQo+ID4gPiAlZCwgbGFuZSBjb3Vu dCA9ICVkIiwKPiA+ID4gLQkJCSAgaW50ZWxfY29ubmVjdG9yLT5iYXNlLmJhc2UuaWQsCj4gPiA+ IC0JCQkgIGludGVsX2Nvbm5lY3Rvci0+YmFzZS5uYW1lLAo+ID4gPiAtCQkJICBpbnRlbF9kcC0+ bGlua19yYXRlLCBpbnRlbF9kcC0+bGFuZV9jb3VudCk7Cj4gPiA+IC0JfQo+ID4gPiArCURSTV9E RUJVR19LTVMoIltDT05ORUNUT1I6JWQ6JXNdIExpbmsgVHJhaW5pbmcgZmFpbGVkIGF0IGxpbmsg cmF0ZSA9ICVkLAo+ID4gPiBsYW5lIGNvdW50ID0gJWQiLAo+ID4gPiArCQkgICAgICBpbnRlbF9j b25uZWN0b3ItPmJhc2UuYmFzZS5pZCwKPiA+ID4gKwkJICAgICAgaW50ZWxfY29ubmVjdG9yLT5i YXNlLm5hbWUsCj4gPiA+ICsJCSAgICAgIGludGVsX2RwLT5saW5rX3JhdGUsIGludGVsX2RwLT5s YW5lX2NvdW50KTsKPiA+ID4gKwlpZiAoIWludGVsX2RwX2dldF9saW5rX3RyYWluX2ZhbGxiYWNr X3ZhbHVlcyhpbnRlbF9kcCwKPiA+ID4gKwkJCQkJCSAgICAgaW50ZWxfZHAtPmxpbmtfcmF0ZSwK PiA+ID4gKwkJCQkJCSAgICAgaW50ZWxfZHAtPmxhbmVfY291bnQpKQo+ID4gPiArCQkvKiBTY2hl ZHVsZSBhIEhvdHBsdWcgVWV2ZW50IHRvIHVzZXJzcGFjZSB0byBzdGFydCBtb2Rlc2V0ICovCj4g PiA+ICsJCXNjaGVkdWxlX3dvcmsoJmludGVsX2Nvbm5lY3Rvci0+bW9kZXNldF9yZXRyeV93b3Jr KTsKPiA+ID4gIAlyZXR1cm47Cj4gPiA+ICB9CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK