Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 24DBBE00867; Fri, 31 Jul 2015 18:22:51 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [93.17.128.19 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 HTML_MESSAGE BODY: HTML included in message Received: from smtp23.services.sfr.fr (smtp23.services.sfr.fr [93.17.128.19]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 248D8E00498 for ; Fri, 31 Jul 2015 18:22:43 -0700 (PDT) Received: from filter.sfr.fr (localhost [1.169.182.217]) by msfrf2319.sfr.fr (SMTP Server) with ESMTP id 8928970000BB; Sat, 1 Aug 2015 03:22:41 +0200 (CEST) Authentication-Results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header.from=herve.jourdain@neuf.fr Received: from hjo-pc (1-169-182-217.dynamic.hinet.net [1.169.182.217]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by msfrf2319.sfr.fr (SMTP Server) with ESMTP id 0C37270000B4; Sat, 1 Aug 2015 03:22:38 +0200 (CEST) X-SFR-UUID: 20150801012239501.0C37270000B4@msfrf2319.sfr.fr Received: from hjopc by hjo-pc (PGP Universal service); Sat, 01 Aug 2015 03:22:37 +0100 X-PGP-Universal: processed; by hjo-pc on Sat, 01 Aug 2015 03:22:37 +0100 From: Herve Jourdain To: 'Petter =?iso-8859-1?q?Mab=E4cker=27?= , francois@concept-embarque.fr, 'Andrei Gherzan' References: <086901d0ca77$9e8f1300$dbad3900$@neuf.fr> <55BB7830.8010909@technux.se> In-Reply-To: <55BB7830.8010909@technux.se> Date: Sat, 1 Aug 2015 03:22:30 +0200 Message-ID: <09b101d0cbf8$8d1ab4d0$a7501e70$@neuf.fr> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQJERVvr1J4YCSmkVzINsflNMWl7ygHG32SgnQEq7wA= Cc: yocto@yoctoproject.org Subject: Re: [meta-raspberrypi] Adding an additional device tree overlay in the SDCard X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Aug 2015 01:22:51 -0000 Content-Type: multipart/alternative; boundary="----=_NextPart_000_09B2_01D0CC09.50A4BD50" Content-Language: fr ------=_NextPart_000_09B2_01D0CC09.50A4BD50 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi Petter, =20 Thanks for your answers. At some point, I=92ve set it in the disto.conf =96 it works there =96 = but for maintenance reasons I=92d love to be able to keep it =93localized=94 = with the kernel .bbappend =96 since it clearly depends on the kernel. =20 For now, I=92ve just patched the sdcard_image-rpi.bbclass, to take the existing ${KERNEL_IMAGE}*.dtb in the ${DEPLOY_DIR_DIRECTORY}, split them = in overlay and non-overlay, and then do the processing like it=92s done = now. It does work in my case, and I can provide the patch if it=92s deemed of interest. But I=92m not sure whether or not there can be some side = effects =96 looks like rather safe, but more opinions are definitely needed on that. =20 Regarding the kernel, yes I=92m using the 3.18 that is supported by the meta-raspberry layer. As I mentioned in another thread, with more recent kernels, the RaspberryPi overlay layers were added in a separate = directory, so in addition to a patch to build the newer kernel, the sdcard_image-rpi.bbclass will also have to be modified to get the files = in the proper directory, when we switch to those newer kernels. =20 Best regards, =20 Herve =20 From: Petter Mab=E4cker [mailto:petter@technux.se]=20 Sent: vendredi 31 juillet 2015 15:29 To: Herve Jourdain ; = francois@concept-embarque.fr; Andrei Gherzan Cc: yocto@yoctoproject.org Subject: Re: [yocto] [meta-raspberrypi] Adding an additional device tree overlay in the SDCard =20 Hi Herve, See inline answers. BR, Petter On 07/30/2015 05:27 AM, Herve Jourdain wrote: Hello, =20 I=92m trying to add a specific .dts file to the raspberrypi. Therefore, in my own layer, I have made a = linux-raspberrypi_3.%.bbappend, that applies a patch to the arch/arm/boot/dts makefile to add my own = layer, and a new rule that copies my specific .dts file to the kernel source directory. And, initially, I had also defined KERNEL_DEVICETREE +=3D = =93myown-overlay.dtb=94 in there. =20 It definitely compiles well, installation process is smooth, I get the Image-myown-overlay.dtb in tmp/deploy/raspberrypi2. =20 BUT when I flash my SDCard, it does NOT appear in the =93overlays=94 = directory of the DOS partition! =20 If I add it manually, everything works fine, so I know my overlay has = been correctly generated and is working. =20 What I discovered is that, the sdcard_image_rpi class takes the list of = .dtb to be considered from split_overlays(), which is defined in linux-raspberrypi-base class. And split_overlays() basically gets the value of KERNEL_DEVICETREE (dts = =3D d.getVar("KERNEL_DEVICETREE", True)). =20 But when I set KERNEL_DEVICETREE in linux-raspberrypi_3.%.bbappend, it = seems the additional value it defines is NOT taken into account when linux-raspberry-class evaluates the value of KERNEL_DEVICETREE. I=92ve checked in the create_image.rpi-sdimg script created, it does not appear in DTS nor DT_OVERLAYS. =20 But when I define KERNEL_DEVICETREE in my distro.conf, THEN it is taken = into account=85 =20 My goal would be to add that overlay by NOT modifying distro.conf = (distros are not necessarily RaspberryPi centric) nor in the raspberry machine = files (or local.conf). This leads me to several questions: #1 Is there a specific reason why my addition to KERNEL_DEVICETREE gets = lost when creating the image? I mean, is it normal, or are there some steps I missed there? Yes, in the current solution KERNEL_DEVICETREE is needed in both the = kernel recipe and image creation context. When appending KERNEL_DEVICETREE in linux-raspberrypi_3.%.bbappend your new overlay will only be visible = within the linux-raspberrypi scope and NOT within the image class. #2 Is there a way that I could achieve adding my .dtb overlay in the = sdcard image only from my linux kernel bbappend? If I remember the code correct within the kernel scope we are only interesting if device tree should be used. At least in theory (assuming = you are using a >=3D 3.18 kernel since then KERNEL_DEVICETREE will bve set = by default) you should be able to skip the KERNEL_DEVICETREE +=3D code in linux-raspberrypi_3.%.bbappend (since it will be set any way and the overlays themselves isn't really used in here..) then append the KERNEL_DEVICETREE within the image scope. If you don't want to put this = into the layer.conf or similiar in your own layer I guess it should work to "prepend" for example the IMAGE_CMD. But in the current solution I guess local.conf, layer.conf (in your own layer) or rpi-base.inc (in meta-raspberrypi) is the easiest options.. #3 On a more general note, wouldn=92t it be simpler (better?) to just = add all the .dtb that are found in the deploy/images/ directory to the DOS = partition of the SDCard? After all, the .dtb need to be compiled from a .dts, so = all the .dtb that appear in deploy/images are =93legit=94. That might perhaps be a better solution. Have you tried it out? Andrei = or Francois might have some comments about this? =20 Herve =20 ------=_NextPart_000_09B2_01D0CC09.50A4BD50 Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

Hi = Petter,

 

Thanks for = your answers.

At some point, I’ve set it in = the disto.conf – it works there – but for maintenance = reasons I’d love to be able to keep it “localized” = with the kernel .bbappend – since it clearly depends on the = kernel.

 

For now, = I’ve just patched the sdcard_image-rpi.bbclass, to take the = existing ${KERNEL_IMAGE}*.dtb in the ${DEPLOY_DIR_DIRECTORY}, split them = in overlay and non-overlay, and then do the processing like it’s = done now.

It does work in my case, and I can provide the = patch if it’s deemed of interest. But I’m not sure whether = or not there can be some side effects – looks like rather safe, = but more opinions are definitely needed on that.

 

Regarding = the kernel, yes I’m using the 3.18 that is supported by the = meta-raspberry layer. As I mentioned in another thread, with more recent = kernels, the RaspberryPi overlay layers were added in a separate = directory, so in addition to a patch to build the newer kernel, the = sdcard_image-rpi.bbclass will also have to be modified to get the files = in the proper directory, when we switch to those newer = kernels.

 

Best = regards,

 

Herve

 

From: Petter = Mab=E4cker [mailto:petter@technux.se]
Sent: vendredi 31 = juillet 2015 15:29
To: Herve Jourdain = <herve.jourdain@neuf.fr>; francois@concept-embarque.fr; Andrei = Gherzan <andrei@gherzan.ro>
Cc: = yocto@yoctoproject.org
Subject: Re: [yocto] [meta-raspberrypi] = Adding an additional device tree overlay in the = SDCard

 

Hi = Herve,

See inline answers.

BR,
Petter

On = 07/30/2015 05:27 AM, Herve Jourdain wrote:

=

Hello,

 

I’m trying to add a specific .dts file to the = raspberrypi.

Therefore, in my own layer, I have made a = linux-raspberrypi_3.%.bbappend, that applies a patch to the = arch/arm/boot/dts makefile to add my own layer, and a new rule that = copies my specific .dts file to the kernel source = directory.

And, initially, I had also defined KERNEL_DEVICETREE +=3D = “myown-overlay.dtb” in there.

 

It definitely compiles well, = installation process is smooth, I get the Image-myown-overlay.dtb in = tmp/deploy/raspberrypi2.

 

BUT when I flash my SDCard, it does NOT appear in the = “overlays” directory of the DOS = partition!

 

If I add it manually, everything works fine, so I know my = overlay has been correctly generated and is = working.

 

What I discovered is that, the sdcard_image_rpi class takes = the list of .dtb to be considered from split_overlays(), which is = defined in linux-raspberrypi-base class.

And split_overlays() = basically  gets the value of KERNEL_DEVICETREE (dts =3D = d.getVar("KERNEL_DEVICETREE", True)).

 

But when I set KERNEL_DEVICETREE in = linux-raspberrypi_3.%.bbappend, it seems the additional value it defines = is NOT taken into account when linux-raspberry-class evaluates the value = of KERNEL_DEVICETREE.

I’ve checked in the create_image.rpi-sdimg script = created, it does not appear in DTS nor = DT_OVERLAYS.

 

But when I define KERNEL_DEVICETREE in my distro.conf, THEN = it is taken into account…

 

My goal would be to add that = overlay by NOT modifying distro.conf (distros are not necessarily = RaspberryPi centric) nor in the raspberry machine files (or = local.conf).

This leads me to several questions:

#1 Is there a specific reason why = my addition to KERNEL_DEVICETREE gets lost when creating the image? I = mean, is it normal, or are there some steps I missed = there?

Yes, in the current solution = KERNEL_DEVICETREE is needed in = both the kernel recipe and image creation context. When appending = KERNEL_DEVICETREE in linux-raspberrypi_3.%.bbappend your new overlay = will only be visible within the linux-raspberrypi scope and NOT within = the image class.


<= blockquote style=3D'margin-top:5.0pt;margin-bottom:5.0pt'>

#2 Is there a way that I could = achieve adding my .dtb overlay in the sdcard image only from my linux = kernel bbappend?


If I remember the code correct = within the kernel scope we are only interesting if device tree should be = used. At least in theory (assuming you are using a >=3D 3.18 kernel = since then KERNEL_DEVICETREE will bve set by default) you should be able = to skip the
KERNEL_DEVICETREE +=3D code in = linux-raspberrypi_3.%.bbappend (since it will be set any way and the = overlays themselves isn't really used in here..) then append the = KERNEL_DEVICETREE within the image scope. If you don't want to put this = into the layer.conf or similiar in your own layer I guess it should work = to "prepend" for example the IMAGE_CMD. But in the current solution I = guess local.conf, layer.conf (in your own layer) or rpi-base.inc (in = meta-raspberrypi) is the easiest = options..


#3 On a more general note, = wouldn’t it be simpler (better?) to just add all the .dtb that are = found in the deploy/images/ directory to the DOS partition of the = SDCard? After all, the .dtb need to be compiled from a .dts, so all the = .dtb that appear in deploy/images are = “legit”.


That might perhaps be a better = solution. Have you tried it out? Andrei or Francois might have some = comments about this?

 

Herve



 

<= /body> ------=_NextPart_000_09B2_01D0CC09.50A4BD50--