From: "flichtenheld (Code Review)"
Date: Mon, 14 Jul 2025 19:36:59 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, gert@...1296...
Message-ID: <09f283eccf30de74e429aba56e0f02b0bb5336c1-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="7aKd6Rg3z0k="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: Cleanup/simplify
mbed TLS related define from autoconf
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: plaisthos
Cc: openvpn-devel
--7aKd6Rg3z0k=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/1081?usp=3Demail )
Change subject: Cleanup/simplify mbed TLS related define from autoconf
......................................................................
Patch Set 6: Code-Review-2
(2 comments)
Patchset:
PS1:
> Okay, I will put it in #1079 and rebase that on top of your change
Done
File src/openvpn/mbedtls_compat.h:
http://gerrit.openvpn.net/c/openvpn/+/1081/comment/a66a43b0_418c29b4 :
PS6, Line 51: #ifdef HAVE_MBEDTLS_PSA_CRYPTO_H
This is wrong, we always define it, just to 0
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1081?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c5fcf0f6f74efd
Gerrit-Change-Number: 1081
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Comment-Date: Mon, 14 Jul 2025 19:36:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--7aKd6Rg3z0k=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: plaisthos.
Patch set 6:Code-Review -2=
V=
iew Change
2 comments:
Patchset:
Patch Set #1:
Okay, I will pu=
t it in #1079 and rebase that on top of your change
Done
=
File src/openvpn/mbedtls_compat.h:<=
/p>
=
ul>To view, visit change 1081. To unsubscribe, or for help writing mail filt=
ers, visit settings.
=
<=
meta itemprop=3D"name" content=3D"View Change"/>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I0f325800ebeb20bd5ef3ff78e5c=
5fcf0f6f74efd
Gerrit-Change-Number: 1081
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <arne-openvpn@...1711...=
27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Comment-Date: Mon, 14 Jul 2025 19:36:59=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <arne-openvp=
n@...1227...>
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--7aKd6Rg3z0k=--