From: "cron2 (Code Review)" Date: Tue, 28 Jan 2025 14:15:14 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <09f404c85aba63e77660d51e458d719241a3f1cf-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="R5y3zcv2NC4="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: mroute/management: fix unitialized variable (UNINIT) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: plaisthos , flichtenheld , openvpn-devel --R5y3zcv2NC4= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/880?usp=3Demail ) Change subject: mroute/management: fix unitialized variable (UNINIT) ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Patchset: PS1: close. Please extend doc/management-notes.txt with the new syntax as well. File src/openvpn/manage.c: http://gerrit.openvpn.net/c/openvpn/+/880/comment/89921c64_ce4843fe : PS1, Line 573: port, p3); not sure we should use `p3` here (what if a user sends 'foo'?). Also, proto traditionall gets printed in front ("tcp:10.0.0.3:1194") so we = shouldn't start printing it at the end here... File src/openvpn/mroute.c: http://gerrit.openvpn.net/c/openvpn/+/880/comment/75d367d4_1b83c9e4 : PS1, Line 441: if ((maddr.type & MR_WITH_PROTO)) double `(())` braces... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/880?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd3178eee1f60fff1 Gerrit-Change-Number: 880 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 28 Jan 2025 14:15:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --R5y3zcv2NC4= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, plaistho= s.

Patch set 1:Code-Review -1=

Vi= ew Change

3 comments:

  • Patchset:

    • Patch Set #1:

      close. Please extend doc/management-notes.tx= t with the new syntax as well.

  • File src/openvpn/manage.c:

    • Patch Set #1, Line 573: port, p3);

      not sure we should = use `p3` here (what if a user sends 'foo'?).

      Also, proto traditionall gets print= ed in front ("tcp:10.0.0.3:1194") so we shouldn't start print= ing it at the end here...

  • File src/openvpn/mroute.c:

To view, visit change 880. To unsubscri= be, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4be0ff4d308213d2ef8ba66bd31= 78eee1f60fff1
Gerrit-Change-Number: 880
Gerrit-PatchSet: 1
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 28 Jan 2025 14:15:14= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--R5y3zcv2NC4=--