Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mail.openembedded.org (Postfix) with ESMTP id 6581977FF9 for ; Wed, 12 Jul 2017 02:51:45 +0000 (UTC) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2017 19:51:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,347,1496127600"; d="scan'208,217";a="125448177" Received: from scdalrym-mobl1.amr.corp.intel.com ([10.254.189.219]) by fmsmga005.fm.intel.com with ESMTP; 11 Jul 2017 19:51:46 -0700 From: Tim Orling Message-Id: <0A125451-F862-48AD-8905-27348AFEFB0E@linux.intel.com> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Date: Tue, 11 Jul 2017 19:51:45 -0700 In-Reply-To: To: Ming Liu References: <1499791478-2407-1-git-send-email-liu.ming50@gmail.com> <1499791478-2407-4-git-send-email-liu.ming50@gmail.com> <18D3A338-C9CF-4313-A570-DB325E456160@linux.intel.com> X-Mailer: Apple Mail (2.3273) X-Content-Filtered-By: Mailman/MimeDel 2.1.12 Cc: Ming Liu , openembedded-devel Subject: Re: [meta-oe/meta-perl] [PATCH 3/8] libterm-readkey-perl: add recipe X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Jul 2017 02:51:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > On Jul 11, 2017, at 7:07 PM, Ming Liu wrote: >=20 > Hi, Tim: >=20 > po4a is providing some perl modules and also some normal binaries, and = it's named as "po4a" on debian/ubuntu distributions as well, that's why = I did not take po4a-perl as its name, shouldn't we let it have a = identical name as debian distributions have, to follow debian naming? >=20 In that case the po4a recipe is unclear and too simple. I would expect = to see the libraries broken out into a sub package which does follow = Debian naming. There is nothing in the recipe or commit message to = indicate it is NOT a standard perl package. It will be read by = non-informed users as open season to use any naming scheme they want. = Hence my concern. Just my 2 cents. =E2=80=94Tim > the best, > thank you=20 >=20 > 2017-07-12 0:34 GMT+02:00 Tim Orling >: > The original po4a recipe should have been named libpo4a-perl, to = follow Debian naming. Notice that every other perl module you have in = DEPENDS or RRECOMMENDS __are__ following Debian naming. Please help us = keep the metadata consistent in the meta-perl layer. Thank you. >=20 > See 4.2 in: > = https://www.debian.org/doc/packaging-manuals/perl-policy/ch-module_package= s.html = >=20 >=20 > > On Jul 11, 2017, at 9:44 AM, liu.ming50@gmail.com = wrote: > > > > From: Ming Liu > > > > > Term::ReadKey - A perl module for simple terminal control. > > > > It's being strongly recommended by po4a. > > > > Signed-off-by: Ming Liu > > > --- > > .../libterm/libterm-readkey-perl_2.37.bb = | 36 = ++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > create mode 100644 = meta-perl/recipes-perl/libterm/libterm-readkey-perl_2.37.bb = > > > > diff --git = a/meta-perl/recipes-perl/libterm/libterm-readkey-perl_2.37.bb = = b/meta-perl/recipes-perl/libterm/libterm-readkey-perl_2.37.bb = > > new file mode 100644 > > index 0000000..6b76682 > > --- /dev/null > > +++ b/meta-perl/recipes-perl/libterm/libterm-readkey-perl_2.37.bb = > > @@ -0,0 +1,36 @@ > > +SUMMARY =3D "Term::ReadKey - A perl module for simple terminal = control." > > +DESCRIPTION =3D "Term::ReadKey is a compiled perl module dedicated = to providing simple \ > > +control over terminal driver modes (cbreak, raw, cooked, etc.,) = support \ > > +for non-blocking reads, if the architecture allows, and some = generalized \ > > +handy functions for working with terminals. One of the main goals = is to \ > > +have the functions as portable as possible, so you can just plug in = "use \ > > +Term::ReadKey" on any architecture and have a good likelihood of it = \ > > +working." > > +HOMEPAGE =3D "http://search.cpan.org/~jstowe/TermReadKey-${PV} = " > > +SECTION =3D "libraries" > > + > > +LICENSE =3D "Artistic-1.0 | GPLv1+" > > +LIC_FILES_CHKSUM =3D = "file://README;md5=3Dc275db663c8489a5709ebb22b185add5" > > + > > +SRC_URI =3D = "${CPAN_MIRROR}/authors/id/J/JS/JSTOWE/TermReadKey-${PV}.tar.gz" > > + > > +SRC_URI[md5sum] =3D "e8ea15c16333ac4f8d146d702e83cc0c" > > +SRC_URI[sha256sum] =3D = "4a9383cf2e0e0194668fe2bd546e894ffad41d556b41d2f2f577c8db682db241" > > + > > +S =3D "${WORKDIR}/TermReadKey-${PV}" > > + > > +# It needs depend on native to let dynamic loader use native = modules > > +# rather than target ones. > > +DEPENDS =3D "libterm-readkey-perl-native" > > + > > +inherit cpan > > + > > +do_configure_append () { > > + # Hack the dynamic module loader so that it use native modules = since it can't load > > + # the target ones. > > + if [ "${BUILD_SYS}" !=3D "${HOST_SYS}" ]; then > > + sed -i -e = "s#-I\$(INST_ARCHLIB)#-I${STAGING_BINDIR_NATIVE}/perl-native/perl/vendor_p= erl/${@get_perl_version(d)}#g" Makefile > > + fi > > +} > > + > > +BBCLASSEXTEND =3D "native" > > -- > > 2.7.4 > > > > -- > > _______________________________________________ > > Openembedded-devel mailing list > > Openembedded-devel@lists.openembedded.org = > > http://lists.openembedded.org/mailman/listinfo/openembedded-devel = >=20 >=20