From: Akio Takebe <takebe_akio@jp.fujitsu.com>
Subject: Re: [Xen-devel] Re: [PATCH] kexec: framework and
	i386 (Take XIV)
Date: Mon, 28 May 2007 15:25:04 +0900
Message-ID: <0C7A0F0EDCB52takebe_akio@jp.fujitsu.com>
References: <A6C6CDA30C4336takebe_akio@jp.fujitsu.com>
	<20060901102116.GN17801@verge.net.au>
	<BDC6D06B746C01takebe_akio@jp.fujitsu.com>
	<20070528052833.GA4374@verge.net.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Return-path: <xen-ia64-devel-bounces@lists.xensource.com>
In-Reply-To: <20070528052833.GA4374@verge.net.au>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>,
	<mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-ia64-devel@lists.xensource.com>
List-Help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>,
	<mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-ia64-devel-bounces@lists.xensource.com
Errors-To: xen-ia64-devel-bounces@lists.xensource.com
To: Horms <horms@verge.net.au>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>, Kazuo Moriwaka <moriwaka@valinux.co.jp>, xen-devel@lists.xensource.com, Ian Campbell <ian.campbell@xensource.com>, "Zou,
	Nanhai" <nanhai.zou@intel.com>, Isaku Yamahata <yamahata@valinux.co.jp>, Magnus Damm <magnus@valinux.co.jp>, xen-ia64-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Hi, Horms and Ian

Thank you for your reply, Horms.
I forgot Signed-off-by of the patch.

Signed-off-by: Horms <horms@verge.net.au>
Signed-off-by: Akio Takebe <takebe_akio@jp.fujitsu.com>

Is the Signed-off-by OK, Horms?

Best Regards,

Akio Takebe

>[ Ian Campbell added to CC list ]
>
>On Tue, Sep 05, 2006 at 06:45:35AM +0900, Akio Takebe wrote:
>> Hi, Horms
>> 
>> I tested the following patch with Horms kexec patch.
>> 
>> My tests is:
>>   push NMI bottun after loading kdump kernel.
>>   
>> The results is:
>>   OK, I could get vmcore
>
>
>Hi Takebe-san,
>
>this patch seems ok to me, but it seems that it never went into the
>tree. Ian, what are your thoughts on it?
>
>> diff -r b688d4a68a3e xen/arch/x86/traps.c
>> --- a/xen/arch/x86/traps.c      Tue Aug 22 14:59:16 2006 +0100
>> +++ b/xen/arch/x86/traps.c      Tue Sep 05 06:37:49 2006 +0900
>> @@ -105,6 +105,8 @@ static int debug_stack_lines = 20;
>>  static int debug_stack_lines = 20;
>>  integer_param("debug_stack_lines", debug_stack_lines);
>>  
>> +extern void crash_kexec(struct cpu_user_regs *regs);
>> +
>>  #ifdef CONFIG_X86_32
>>  #define stack_words_per_line 8
>>  #define ESP_BEFORE_EXCEPTION(regs) ((unsigned long *)&regs->esp)
>> @@ -1611,8 +1613,10 @@ asmlinkage void do_nmi(struct cpu_user_r
>>              mem_parity_error(regs);
>>          else if ( reason & 0x40 )
>>              io_check_error(regs);
>> -        else if ( !nmi_watchdog )
>> +        else if ( !nmi_watchdog ){
>> +            crash_kexec(NULL);
>>              unknown_nmi_error((unsigned char)(reason&0xff));
>> +        }
>>      }
>>  }
>>  
>> 
>> 
>> Best Regards,
>> 
>> Akio Takebe